New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 770392 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 764126



Sign in to add a comment

[MD Extensions] make all views within view manager attach only when visible

Project Member Reported by scottchen@chromium.org, Sep 29 2017

Issue description

currently all the views (within view-manager in manager.html) are in the dom even when hidden, which makes the page heavier than necessary. They should be behind a dom-if with restamp.
 
Owner: dschuyler@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
CL at https://chromium-review.googlesource.com/c/chromium/src/+/731884
Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
The CL reduces the time to page render from 575 ms to 528 ms (on a very fast machine*); A savings of 47 ms or around 8%.

*So the improvement will be much greater in total time for average users (and likely similar by percentage).

Comment 4 by dpa...@chromium.org, Oct 27 2017

Blocking: 764126
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc9df5d5ac34fb5c4f706745b4d0dc7172d2ddd6

commit fc9df5d5ac34fb5c4f706745b4d0dc7172d2ddd6
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Tue Oct 31 03:03:08 2017

[MD extensions] cr-lazy-render on pages so they are attached on demand

This CL wraps the MD extensions pages (details view, error
page, and shortcuts page) in cr-lazy-render to accelerate the initial page load.
The item list is not lazily rendered because it's the main page.

Bug:  770392 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5cc1d58f42c7bf56463d222a9a2dda7e0aa494ce
Reviewed-on: https://chromium-review.googlesource.com/731884
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512725}
[modify] https://crrev.com/fc9df5d5ac34fb5c4f706745b4d0dc7172d2ddd6/chrome/browser/resources/md_extensions/manager.html
[modify] https://crrev.com/fc9df5d5ac34fb5c4f706745b4d0dc7172d2ddd6/chrome/browser/resources/md_extensions/view_manager.js
[modify] https://crrev.com/fc9df5d5ac34fb5c4f706745b4d0dc7172d2ddd6/chrome/test/data/webui/extensions/extension_manager_test.js

Status: Fixed (was: Started)

Sign in to add a comment