[MD Extensions] make all dialogs attach only when visible |
||||
Issue descriptioncurrently all the dialogs in manager.html are in the dom even when hidden, which makes the page heavier than necessary. They should be behind a dom-if with restamp.
,
Oct 19 2017
CL at https://chromium-review.googlesource.com/c/chromium/src/+/727540
,
Oct 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a568040718b6f18c75c02668c84f86ca9ec1875 commit 4a568040718b6f18c75c02668c84f86ca9ec1875 Author: Dave Schuyler <dschuyler@chromium.org> Date: Fri Oct 20 19:49:43 2017 [MD extensions] dialogs in dom-if's until needed This CL places the dialogs within MD extensions with template dom-if wrappers. Bug: 770391 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1a61794b043e136dcfe6439cd8c190da147cc2e7 Reviewed-on: https://chromium-review.googlesource.com/727540 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#510530} [modify] https://crrev.com/4a568040718b6f18c75c02668c84f86ca9ec1875/chrome/browser/resources/md_extensions/manager.html [modify] https://crrev.com/4a568040718b6f18c75c02668c84f86ca9ec1875/chrome/browser/resources/md_extensions/manager.js [modify] https://crrev.com/4a568040718b6f18c75c02668c84f86ca9ec1875/chrome/browser/resources/md_extensions/options_dialog.html [modify] https://crrev.com/4a568040718b6f18c75c02668c84f86ca9ec1875/chrome/browser/resources/md_extensions/service.js [modify] https://crrev.com/4a568040718b6f18c75c02668c84f86ca9ec1875/chrome/test/data/webui/extensions/extension_manager_test.js
,
Oct 20 2017
,
Oct 20 2017
,
Nov 1 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dschuyler@chromium.org
, Oct 18 2017Status: Assigned (was: Available)