New issue
Advanced search Search tips

Issue 770374 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

18.4% regression in smoothness.key_silk_cases at 504957:505034

Project Member Reported by shend@chromium.org, Sep 29 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Sep 29 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=770374

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=271f0dd70e7da3394d080bb4375c9ad4537c412f6b702ab45afbf313512ee906


Bot(s) for this bug's original alert(s):

android-nexus6
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Sep 30 2017

Cc: brianosman@google.com
Owner: brianosman@google.com
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author brianosman@google.com ===

Hi brianosman@google.com, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Brian Osman
  Commit : 36dcd7f25d1ffee8571a7d424eb02f60cd474fa7
  Date   : Thu Sep 28 13:06:57 2017
  Subject: Enable caching of path mask textures by default

Bisect Details
  Configuration: android_nexus6_perf_bisect
  Benchmark    : smoothness.key_silk_cases
  Metric       : avg_surface_fps/http___jsfiddle.net_xLuvC_1_show_
  Change       : 20.61% | 38.0 -> 30.1666666667

Revision                             Result                   N
chromium@504956                      38.0 +- 1.41421          6      good
chromium@504995                      37.6667 +- 1.1547        6      good
chromium@505015                      38.0 +- 0.0              6      good
chromium@505025                      37.8333 +- 0.912871      6      good
chromium@505030                      37.6667 +- 1.1547        6      good
chromium@505032                      37.5 +- 1.22474          6      good
chromium@505033                      37.6667 +- 1.1547        6      good
chromium@505033,skia@36dcd7f25d      30.3333 +- 1.1547        6      bad       <--
chromium@505034                      30.1667 +- 0.912871      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http...jsfiddle.net.xLuvC.1.show. smoothness.key_silk_cases

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8967081440893630208


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Sep 30 2017

 Issue 770447  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7943ecb42a7841ebff9b51eb85ac7f4937537243

commit 7943ecb42a7841ebff9b51eb85ac7f4937537243
Author: Brian Osman <brianosman@google.com>
Date: Tue Oct 03 20:43:12 2017

Disable SW path renderer mask caching in Skia

When this was enabled by default in Skia, we saw some perf regressions
in chromium. Turning it off here to go back to the old behavior.

Bug:  770374 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ia5aedb25d1f00d12c827a9c6bfb065b93ff687e5
Reviewed-on: https://chromium-review.googlesource.com/695464
Reviewed-by: Robert Phillips <robertphillips@google.com>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Brian Osman <brianosman@google.com>
Cr-Commit-Position: refs/heads/master@{#506163}
[modify] https://crrev.com/7943ecb42a7841ebff9b51eb85ac7f4937537243/gpu/skia_bindings/grcontext_for_gles2_interface.cc

Status: Fixed (was: Assigned)

Sign in to add a comment