Raster has inconsistent color spaces in CoreAnimation renderer |
||||
Issue description
Run chrome with
- GPU raster disabled
- a non-sRGB color profile
- CoreAnimation compositing
Open an image, and drag the window size, as in the attached movie.
Notice that color spaces flicker.
This is because we're getting two different color spaces at GpuMemoryBuffer allocation time:
ScopedWriteLockGpuMemoryBuffer::GetGpuMemoryBuffer gets:
{primaries:[[0.564011,0.240677,0.159515,],
[0.283691,0.650345,0.0659485,],
[0.0181885,0.0565643,0.750443,],],
transfer:[1,0,0,0,0,0,2.2,],
matrix:1, range:2, icc_profile_id:10}
ScopedWriteLockGL::AllocateGpuMemoryBuffer gets:
{primaries:1, transfer:13, matrix:1, range:2, icc_profile_id:0}
But ... the cc::Resources have the same color space. So we get flickering in CoreAnimation rendering only.
This appears to have worked in Chrome 61 and regressed sometime recently.
,
Sep 29 2017
Actually, this is yet another issue with how we cache ICC profiles (that code can't die fast enough). It'll require a small hack merge to 62. And I'm going to get rid of this mess once and for all after that.
,
Oct 2 2017
,
Oct 2 2017
,
Oct 2 2017
Issue 770398 has been merged into this issue.
,
Oct 2 2017
Issue 770418 has been merged into this issue.
,
Oct 2 2017
,
Oct 23 2017
Issue 777205 has been merged into this issue.
,
Oct 23 2017
The checking to fix this was in r505491, in issue 770219 . |
||||
►
Sign in to add a comment |
||||
Comment 1 by ccameron@chromium.org
, Sep 29 20175.7 MB
5.7 MB Download