virtual/threaded/animations/unanimated-style.html flaky timing out on Linux Dbg |
||||
Issue descriptionwebkit_layout_tests failing on Linux Trusty dbg https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29/builds/5580
,
Oct 2 2017
,
Oct 3 2017
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25818e61889281f27a6406f1d556d62bbc374ed3 commit 25818e61889281f27a6406f1d556d62bbc374ed3 Author: Eric Willigers <ericwilligers@chromium.org> Date: Wed Oct 04 20:18:07 2017 Fix flaky unanimated-style.html animations/unanimated-style.html was using setTimout(0) to wait for the initial style calculations before starting the animation. This isn't a reliable method. We now force style recalc explicitly by reading an element's offsetTop. BUG= 770362 Change-Id: Icf518b3a43b51d854de81cc2fab371922e271e16 Reviewed-on: https://chromium-review.googlesource.com/699974 Reviewed-by: Ali Juma <ajuma@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#506497} [modify] https://crrev.com/25818e61889281f27a6406f1d556d62bbc374ed3/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/25818e61889281f27a6406f1d556d62bbc374ed3/third_party/WebKit/LayoutTests/animations/unanimated-style.html
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/affde46412e40f7cc1627c51442e7471f4688e13 commit affde46412e40f7cc1627c51442e7471f4688e13 Author: Eric Willigers <ericwilligers@chromium.org> Date: Wed Oct 04 20:19:49 2017 animation-events tests: force style recalc at start Instead of using setTimeout to hope for a style recalculation, we now read offsetTop to force a style recalculation. Bug: 770362 Change-Id: Ic4918cd336aef56641e483ce2ae8d31ceb29acc9 Reviewed-on: https://chromium-review.googlesource.com/700154 Reviewed-by: Ali Juma <ajuma@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#506499} [modify] https://crrev.com/affde46412e40f7cc1627c51442e7471f4688e13/third_party/WebKit/LayoutTests/animations/prefixed/animation-events-prefixed-02.html [modify] https://crrev.com/affde46412e40f7cc1627c51442e7471f4688e13/third_party/WebKit/LayoutTests/animations/prefixed/animation-events-prefixed-03.html [modify] https://crrev.com/affde46412e40f7cc1627c51442e7471f4688e13/third_party/WebKit/LayoutTests/animations/prefixed/animation-events-unprefixed-01.html [modify] https://crrev.com/affde46412e40f7cc1627c51442e7471f4688e13/third_party/WebKit/LayoutTests/animations/timing/longhand-timing-function.html
,
Oct 4 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Oct 1 2017