New issue
Advanced search Search tips

Issue 770362 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

virtual/threaded/animations/unanimated-style.html flaky timing out on Linux Dbg

Project Member Reported by rdevlin....@chromium.org, Sep 29 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab8287430319a0a413f80ba4d38a1ede1d1269e0

commit ab8287430319a0a413f80ba4d38a1ede1d1269e0
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Sun Oct 01 03:59:25 2017

[Sheriff] Update expectations for virtual/threaded/animations/unanimated-style.html

webkit_layout_tests failing on Linux Trusty dbg

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29/builds/5580

TBR=fsamuel@chromium.org

Bug:  770362 
Change-Id: I1b422c2185effdcfea75d87d30176ad9e10a44ad
Reviewed-on: https://chromium-review.googlesource.com/693290
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505499}
[modify] https://crrev.com/ab8287430319a0a413f80ba4d38a1ede1d1269e0/third_party/WebKit/LayoutTests/TestExpectations

Comment 2 by rtoy@chromium.org, Oct 2 2017

Components: -Blink Blink>Animation
Labels: Test-Layout Update-Fortnightly
Owner: ericwilligers@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25818e61889281f27a6406f1d556d62bbc374ed3

commit 25818e61889281f27a6406f1d556d62bbc374ed3
Author: Eric Willigers <ericwilligers@chromium.org>
Date: Wed Oct 04 20:18:07 2017

Fix flaky unanimated-style.html

animations/unanimated-style.html was using setTimout(0) to wait for the
initial style calculations
before starting the animation. This isn't a reliable method.

We now force style recalc explicitly by reading an element's offsetTop.

BUG= 770362 

Change-Id: Icf518b3a43b51d854de81cc2fab371922e271e16
Reviewed-on: https://chromium-review.googlesource.com/699974
Reviewed-by: Ali Juma <ajuma@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506497}
[modify] https://crrev.com/25818e61889281f27a6406f1d556d62bbc374ed3/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/25818e61889281f27a6406f1d556d62bbc374ed3/third_party/WebKit/LayoutTests/animations/unanimated-style.html

Status: Fixed (was: Started)

Sign in to add a comment