New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 770359 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification

Blocking:
issue 717738



Sign in to add a comment

Make the Mojo Linux Perf FYI bot green

Project Member Reported by yzshen@chromium.org, Sep 29 2017

Issue description

This bot runs the telemetry loading.desktop.network_service test.

https://build.chromium.org/p/chromium.perf.fyi/builders/Mojo%20Linux%20Perf

It used to be in a fairly good shape but has regressed over time.
We need to make it consistently green, so that we could ask network service sheriffs to watch over it.

How to run the telemetry tests locally:
- build out/Release/chrome
- run the following command line:
tools/perf/run_benchmark --browser=release loading.desktop.network_service







 

Comment 1 by yzshen@chromium.org, Sep 29 2017

Blocking: 717738

Comment 2 by juncai@chromium.org, Sep 29 2017

Cc: -juncai@chromium.org
Owner: juncai@chromium.org
Status: Assigned (was: Untriaged)
Thanks yzshen@, I'll take a look.

Comment 3 by juncai@chromium.org, Oct 11 2017

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8315b60debec6ad8ff65619310f4050705785d6b

commit 8315b60debec6ad8ff65619310f4050705785d6b
Author: Jun Cai <juncai@chromium.org>
Date: Wed Oct 25 19:24:34 2017

Fix Mojo Linux Perf FYI network service telemetry tests

Some of the network service telemetry tests currently timeout. This is due to
the change of the flag that is given to Chrome. The flag that was used before
was:
'--ignore-certificate-errors'
And now we are using:
'--ignore-certificate-errors-spki-list='
The current network service code doesn't handle this flag and causes the Chrome
browser to wait until timeout during the test.

To fix it, an IgnoreErrorsCertVerifier can be set when creating
URLRequestContextBuilder for the network service. Currently the
IgnoreErrorsCertVerifier is in //content/public/browser which prevents
//content/network code from using it. This CL moves it to
//content/public/network since it is related to that.

Bug:  770359 
Change-Id: I9e2c1d601e4a771e512bdb2578553555584c894b
Reviewed-on: https://chromium-review.googlesource.com/710513
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511549}
[modify] https://crrev.com/8315b60debec6ad8ff65619310f4050705785d6b/chrome/browser/io_thread.cc
[modify] https://crrev.com/8315b60debec6ad8ff65619310f4050705785d6b/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/8315b60debec6ad8ff65619310f4050705785d6b/content/browser/BUILD.gn
[modify] https://crrev.com/8315b60debec6ad8ff65619310f4050705785d6b/content/browser/utility_process_host_impl.cc
[modify] https://crrev.com/8315b60debec6ad8ff65619310f4050705785d6b/content/network/network_context.cc
[modify] https://crrev.com/8315b60debec6ad8ff65619310f4050705785d6b/content/public/browser/BUILD.gn
[modify] https://crrev.com/8315b60debec6ad8ff65619310f4050705785d6b/content/public/network/BUILD.gn
[rename] https://crrev.com/8315b60debec6ad8ff65619310f4050705785d6b/content/public/network/ignore_errors_cert_verifier.cc
[rename] https://crrev.com/8315b60debec6ad8ff65619310f4050705785d6b/content/public/network/ignore_errors_cert_verifier.h
[rename] https://crrev.com/8315b60debec6ad8ff65619310f4050705785d6b/content/public/network/ignore_errors_cert_verifier_unittest.cc
[modify] https://crrev.com/8315b60debec6ad8ff65619310f4050705785d6b/content/shell/BUILD.gn
[modify] https://crrev.com/8315b60debec6ad8ff65619310f4050705785d6b/content/shell/browser/layout_test/layout_test_url_request_context_getter.cc
[modify] https://crrev.com/8315b60debec6ad8ff65619310f4050705785d6b/content/test/BUILD.gn

Comment 5 by juncai@chromium.org, Oct 26 2017

Update: the bot that runs the telemetry loading.desktop.network_service test:
https://build.chromium.org/p/chromium.perf.fyi/builders/Mojo%20Linux%20Perf
turns to "success".

Comment 6 by juncai@chromium.org, Oct 26 2017

Status: Fixed (was: Started)

Comment 7 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Sign in to add a comment