New issue
Advanced search Search tips

Issue 770356 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove kReduceSecurityForTesting command line argument

Project Member Reported by elawrence@chromium.org, Sep 29 2017

Issue description

It's defunct and not checked by anyone.

// Enables more web features over insecure connections. Designed to be used
// for testing purposes only.
const char kReduceSecurityForTesting[]      = "reduce-security-for-testing";
 
Status: Started (was: Untriaged)
https://chromium-review.googlesource.com/c/chromium/src/+/693289
This flag was originally introduced for testing autofill, but is no longer used by that code.

 crbug.com/272512 
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ceee68628ebb2501bd0f084f3cc148a045840e6

commit 8ceee68628ebb2501bd0f084f3cc148a045840e6
Author: Eric Lawrence <elawrence@chromium.org>
Date: Tue Oct 17 19:22:57 2017

Remove kReduceSecurityForTesting command line argument

Previously, the "reduce-security-for-testing" flag was used by autofill
and an Android media playback codepath to workaround limitations in test
code. Everything that previously checked this flag is now gone and now
the flag itself can be removed.

Bug:  770356 
Change-Id: I414d55a88d39c5f1116a4d9cf96682fd648b7089
Reviewed-on: https://chromium-review.googlesource.com/693289
Commit-Queue: Eric Lawrence <elawrence@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509485}
[modify] https://crrev.com/8ceee68628ebb2501bd0f084f3cc148a045840e6/chrome/browser/ui/startup/bad_flags_prompt.cc
[modify] https://crrev.com/8ceee68628ebb2501bd0f084f3cc148a045840e6/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/8ceee68628ebb2501bd0f084f3cc148a045840e6/content/public/common/content_switches.cc
[modify] https://crrev.com/8ceee68628ebb2501bd0f084f3cc148a045840e6/content/public/common/content_switches.h
[modify] https://crrev.com/8ceee68628ebb2501bd0f084f3cc148a045840e6/tools/perf/benchmarks/blink_perf.py

Status: Fixed (was: Started)

Sign in to add a comment