New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 770347 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

code search missing xrefs

Project Member Reported by szager@chromium.org, Sep 29 2017

Issue description

Comment 1 by szager@chromium.org, Sep 29 2017

Note that render_frame_impl.cc does not appear to have any code search annotations at all (no links at all when viewing it in code search).

Comment 2 by jpar...@google.com, Sep 29 2017

Cc: aga...@chromium.org
Components: -Infra Infra>Codesearch
Sigh, thank you for the report.

I thought we had alerting in place to detect when this happened?

Comment 3 by emso@chromium.org, Sep 30 2017

Owner: emso@chromium.org
Status: Assigned (was: Untriaged)
Thanks for the report and sorry for this drop to of Xrefs. I'm suspecting a bad push of an index pack. 

We do have alerts and one for Xref alerts fired yesterday. We don't have an alert for Xrefs disappearing because it is tricky to setup based on the data we have.  

While investigating the Xrefs latency issue yesterday I may have found an issue related to this behavior, having to do with how index packs are pushed and picked up by the Xrefs pipeline.

Comment 4 by emso@chromium.org, Oct 2 2017

Status: WontFix (was: Assigned)
It doesn't seem like the index pack push issue is the cause of this problem. The cause here is likely a compilation issue in the gen bot for chromium/Linux, e.g., 

"ninja: Entering directory `/b/build/slave/codesearch-gen-chromium-linux/build/src/out/Debug'
ninja: error: toolchain.ninja:65: loading 'obj/base/base_i18n_perftests.ninja': No such file or directory
subninja obj/base/base_i18n_perftests.ninja
                                           ^ near here"

Similar issues for revision 505268 - 505463, then the compile became successful again. Unfortunately, this can happen but we can work on improving the alerting and how to recover on failure.

Sign in to add a comment