frecon: Usage output is incorrect |
||
Issue descriptionThe output of frecon states that setting loop-count to 0 causes it to loop forever, but the actual behavior is setting 0 causes it not to playback at all. I've got a patch incoming that changes the documentation to match the behavior, as that seems like the safest fix, but it's also pretty easy to check for zero in splash_set_loop_count. I figured not changing the behavior was the best approach in this case, even though it's easy to make the behavior the same as it's documented.
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/frecon/+/199d0446da10ead08944fdc5be6f02e3dbcbfea7 commit 199d0446da10ead08944fdc5be6f02e3dbcbfea7 Author: Pat Erley <perley@chromium.org> Date: Wed Oct 04 03:01:17 2017 frecon: Fix documentation on loop-count The loop-count argument specifies setting it to zero causes it to loop forever. Setting zero, in fact, causes it to not play back at all. Rather than change the behavior of the program by fixing this behavior, change the documentation to match the behavior. BUG=chromium:770346 TEST=No functional change. Change-Id: Id47e7e83622fc1e01dcc32288955ccc80aeb9cfd Reviewed-on: https://chromium-review.googlesource.com/693047 Commit-Ready: Pat Erley <perley@chromium.org> Tested-by: Dominik Behr <dbehr@chromium.org> Tested-by: Pat Erley <perley@chromium.org> Reviewed-by: Dominik Behr <dbehr@chromium.org> [modify] https://crrev.com/199d0446da10ead08944fdc5be6f02e3dbcbfea7/main.c
,
Aug 1
|
||
►
Sign in to add a comment |
||
Comment 1 by perley@chromium.org
, Sep 29 2017