New issue
Advanced search Search tips

Issue 770331 link

Starred by 1 user
Status: Fixed
Owner:
seobrien@chromium.org
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

touchtests replay have different properties applied than devices

Project Member Reported by seobrien@chromium.org, Sep 29 2017 
The touchtests suite doesn't apply properties from the first stanza in 40-touchpad-cmt.conf. This stanza applied to every device, so there is a difference between original and replay gestures.

We should move these properties to the gesture library source code.

Also, we should look into a better way to apply properties for touchtests.  Either apply the default stanza to all tests, or do some matching so we don't have to explicitly tell touchtests which stanzas to apply
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/gestures/+/98f544f86f6800087b61ec5e726a27d0d6924438

commit 98f544f86f6800087b61ec5e726a27d0d6924438
Author: Sean O'Brien <seobrien@google.com>
Date: Fri Oct 06 22:51:09 2017

Move gesture properties from xorg-conf to gesture library

Some properties in xorg-conf are applied to every device.  This CL adds
those properties to the gesture library source code.

BUG= chromium:770331 
TEST=build and deploy to device

Change-Id: I6f071a847c592746ff2928f1739b01a930afa031
Reviewed-on: https://chromium-review.googlesource.com/692513
Commit-Ready: Sean O'Brien <seobrien@chromium.org>
Tested-by: Sean O'Brien <seobrien@chromium.org>
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>

[modify] https://crrev.com/98f544f86f6800087b61ec5e726a27d0d6924438/src/accel_filter_interpreter.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/xorg-conf/+/7f5d9c4cf3b87d0cbfe4f0dfdab136472477d1e5

commit 7f5d9c4cf3b87d0cbfe4f0dfdab136472477d1e5
Author: Sean O'Brien <seobrien@google.com>
Date: Fri Oct 06 22:51:09 2017

Move gesture properties from xorg-conf to gesture library

Some properties in xorg-conf are applied to every device. This CL
removes those properties from the configuration, after they added to the
gesture library by the linked CL.

BUG= chromium:770331 
TEST=build and deploy to device
CQ-DEPEND=CL:692513

Change-Id: I121a926cc0734e3e4f2ea86357378738aadc3c65
Reviewed-on: https://chromium-review.googlesource.com/692698
Commit-Ready: Sean O'Brien <seobrien@chromium.org>
Tested-by: Sean O'Brien <seobrien@chromium.org>
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>

[modify] https://crrev.com/7f5d9c4cf3b87d0cbfe4f0dfdab136472477d1e5/40-touchpad-cmt.conf
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/touchpad-tests/+/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad

commit f41a41cbe139d1d537c1d4ed69d5df5477cd83ad
Author: Sean O'Brien <seobrien@google.com>
Date: Sat Oct 07 04:31:10 2017

Scale scroll/fling length to match gesture library change

Gesture properties were moved from xorg-conf to the gesture library,
causing touchtest replays to report different (more accurate) scroll and
fling lengths.  This CL scales the changed gestures by the appropriate
amount.

BUG= chromium:770331 
TEST=run touchtests with gesture library change and change to
touchtests. Change in score is <1% for all tests.
CQ-DEPEND=CL:692513

Change-Id: I52e6e16e576780fca410345ca040fe476a78c463
Reviewed-on: https://chromium-review.googlesource.com/692703
Commit-Ready: Sean O'Brien <seobrien@chromium.org>
Tested-by: Sean O'Brien <seobrien@chromium.org>
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>

[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/rambi-elan-0.0/baseline/scroll.props
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/kip-elan-3.0/baseline/fling.props
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/leon-1.0/jumpy_scroll.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/rambi-elan-0.0/baseline/fling.props
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/logitech-t620/jerky_scroll.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/snow2.3/scrolling_with_low_press_fingers_2.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/leon-1.0/jumpy_scroll5.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/snow2.3/scrolling_with_sensor_jump.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/mario/base_scroll_left.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/wolf-elan-2.0/baseline/fling.props
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/stout/move_when_scroll_intended.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/samus-atmel-1.0-1/two_finger_back1.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/snow2.3/scroll_down_fling2.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/snow2.3/refling.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/mario/base_scroll_up_regardless_prior_state.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/snow2.3/missed_2f_scroll.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/falco-2.0/false_scrolling_long.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/samus-atmel-1.0-1/scroll_fling1.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/snow2.3/scrolling_with_low_press_fingers_3.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/snow1.3/scroll_with_pause.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/mario/base_scroll_right.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/mario/base_scroll_down.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/kip-elan-3.0/baseline/scroll.props
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/snow1.3/vertical_scrolls_down.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/snow2.3/scrolling_with_low_press_fingers_5.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/blaze-elan-1.0/baseline/scroll.props
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/snow2.3/scrolling_with_low_press_fingers_4.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/butterfly1.0/quick_scroll.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/leon-1.0/jumpy_scroll4.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/snow2.3/slow_start_scroll.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/quawks-elan-6.0/baseline/scroll.props
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/leon-1.0/jumpy_scroll3.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/parrot1.2/quick_scroll.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/candy/scroll_fail_1.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/mario/base_scroll_up.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/big-elan-5.0/baseline/scroll.props
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/snow2.3/scroll_down_fling.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/snow2.3/quick_scroll.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/snow2.3/scrolling_with_low_press_fingers.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/lumpy/scroll_without_fling2.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/quawks-elan-6.0/baseline/fling.props
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/blaze-elan-1.0/baseline/fling.props
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/leon-1.0/jumpy_scroll2.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/stout/null_when_scroll_intended3.py
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/gnawty-elan-4.0/baseline/scroll.props
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/wolf-elan-2.0/baseline/scroll.props
[modify] https://crrev.com/f41a41cbe139d1d537c1d4ed69d5df5477cd83ad/tests/gnawty-elan-4.0/baseline/fling.props

Comment 4 by seobrien@chromium.org, Feb 14 2018

Status: Fixed (was: Started)
►

Sign in to add a comment