New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 770327 link

Starred by 3 users
Status: Fixed
Owner:
aga...@chromium.org
Closed: Dec 2017
Cc:
█ susanjuniab@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 600469


Sign in to add a comment

Remove all mutating APIs and UI from Rietveld

Project Member Reported by aga...@chromium.org, Sep 29 2017 
For the sake of reducing confusion, no one should be able to make (or think they can make) Rietveld calls which would attempt to mutate the datastore.

* APIs which accept POST/PUT/DELETE requests
* Buttons which submit forms
* Forms themselves
* Links which navigate to forms

Comment 1 by aga...@chromium.org, Sep 29 2017

Blockedon: 600469
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/e82afb15d8717e19dea29cb034cb0fc0cd99a828

commit e82afb15d8717e19dea29cb034cb0fc0cd99a828
Author: Aaron Gable <agable@chromium.org>
Date: Tue Oct 17 23:27:59 2017

Rietveld: Remove ability to trigger tryjobs and the CQ

Bug:  770327 
Change-Id: Iac47435a174d1197fbe6b6ab111a19ca1786e1c1
Reviewed-on: https://chromium-review.googlesource.com/722161
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Jason Robbins <jrobbins@chromium.org>

[modify] https://crrev.com/e82afb15d8717e19dea29cb034cb0fc0cd99a828/appengine/chromium_rietveld/new_static/components/cr-issue.html
[modify] https://crrev.com/e82afb15d8717e19dea29cb034cb0fc0cd99a828/appengine/chromium_rietveld/codereview/buildbucket.py
[modify] https://crrev.com/e82afb15d8717e19dea29cb034cb0fc0cd99a828/appengine/chromium_rietveld/templates/issue.html
[modify] https://crrev.com/e82afb15d8717e19dea29cb034cb0fc0cd99a828/appengine/chromium_rietveld/templates/issue_row.html
[delete] https://crrev.com/77a520f2366832e5c51732f4f1393d9535281706/appengine/chromium_rietveld/new_static/components/cr-issue-cq-dry-run-dialog.html
[delete] https://crrev.com/77a520f2366832e5c51732f4f1393d9535281706/appengine/chromium_rietveld/templates/edit_flags.html
[delete] https://crrev.com/77a520f2366832e5c51732f4f1393d9535281706/appengine/chromium_rietveld/new_static/components/cr-try-dialog.html
[modify] https://crrev.com/e82afb15d8717e19dea29cb034cb0fc0cd99a828/appengine/chromium_rietveld/new_static/components/cr-issue-meta.html
[modify] https://crrev.com/e82afb15d8717e19dea29cb034cb0fc0cd99a828/appengine/chromium_rietveld/codereview/views_chromium.py
[modify] https://crrev.com/e82afb15d8717e19dea29cb034cb0fc0cd99a828/appengine/chromium_rietveld/codereview/urls.py
[modify] https://crrev.com/e82afb15d8717e19dea29cb034cb0fc0cd99a828/appengine/chromium_rietveld/static/script.js
[modify] https://crrev.com/e82afb15d8717e19dea29cb034cb0fc0cd99a828/appengine/chromium_rietveld/new_static/components/cr-issue-patchset.html
[modify] https://crrev.com/e82afb15d8717e19dea29cb034cb0fc0cd99a828/appengine/chromium_rietveld/templates/patchset.html
[modify] https://crrev.com/e82afb15d8717e19dea29cb034cb0fc0cd99a828/appengine/chromium_rietveld/tests/test_buildbucket.py
[modify] https://crrev.com/e82afb15d8717e19dea29cb034cb0fc0cd99a828/appengine/chromium_rietveld/new_static/components/cr-issue-publish-dialog.html
[modify] https://crrev.com/e82afb15d8717e19dea29cb034cb0fc0cd99a828/appengine/chromium_rietveld/new_static/model/issue.js
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/999be03fbbad217aa1fa319e378a59df18e8fa3d

commit 999be03fbbad217aa1fa319e378a59df18e8fa3d
Author: Aaron Gable <agable@chromium.org>
Date: Tue Oct 17 23:59:50 2017

Rietveld: Remove one-click ability to one-click revert changes

Bug:  770327 
Change-Id: I7951715448d3ec8f963820e8ad040ff4e337d870
Reviewed-on: https://chromium-review.googlesource.com/721777
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Jason Robbins <jrobbins@chromium.org>

[modify] https://crrev.com/999be03fbbad217aa1fa319e378a59df18e8fa3d/appengine/chromium_rietveld/new_static/components/cr-issue.html
[modify] https://crrev.com/999be03fbbad217aa1fa319e378a59df18e8fa3d/appengine/chromium_rietveld/codereview/buildbucket.py
[modify] https://crrev.com/999be03fbbad217aa1fa319e378a59df18e8fa3d/appengine/chromium_rietveld/templates/patchset.html
[modify] https://crrev.com/999be03fbbad217aa1fa319e378a59df18e8fa3d/appengine/chromium_rietveld/codereview/views_chromium.py
[modify] https://crrev.com/999be03fbbad217aa1fa319e378a59df18e8fa3d/appengine/chromium_rietveld/codereview/urls.py
[modify] https://crrev.com/999be03fbbad217aa1fa319e378a59df18e8fa3d/appengine/chromium_rietveld/new_static/components/cr-app.html
[modify] https://crrev.com/999be03fbbad217aa1fa319e378a59df18e8fa3d/appengine/chromium_rietveld/tests/test_buildbucket.py
[delete] https://crrev.com/bf01cea4981c6a8c32eab77b5071bb290981321d/appengine/chromium_rietveld/new_static/components/cr-issue-revert-dialog.html
[modify] https://crrev.com/999be03fbbad217aa1fa319e378a59df18e8fa3d/appengine/chromium_rietveld/new_static/model/issue.js
[modify] https://crrev.com/999be03fbbad217aa1fa319e378a59df18e8fa3d/appengine/chromium_rietveld/codereview/views.py
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4847d8db35d75b3e2bc05b52a07d51ae32748b73

commit 4847d8db35d75b3e2bc05b52a07d51ae32748b73
Author: Aaron Gable <agable@chromium.org>
Date: Wed Oct 18 00:14:00 2017

Rietveld: remove in-line commenting and draft editing

Bug:  770327 
Change-Id: If948d24e71b336451127a2d8d161fb103d78b36b
Reviewed-on: https://chromium-review.googlesource.com/722219
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Jason Robbins <jrobbins@chromium.org>

[modify] https://crrev.com/4847d8db35d75b3e2bc05b52a07d51ae32748b73/appengine/chromium_rietveld/new_static/components/cr-issue.html
[modify] https://crrev.com/4847d8db35d75b3e2bc05b52a07d51ae32748b73/appengine/chromium_rietveld/templates/patch.html
[modify] https://crrev.com/4847d8db35d75b3e2bc05b52a07d51ae32748b73/appengine/chromium_rietveld/templates/inline_comment.html
[modify] https://crrev.com/4847d8db35d75b3e2bc05b52a07d51ae32748b73/appengine/chromium_rietveld/new_static/diff/cr-diff.html
[modify] https://crrev.com/4847d8db35d75b3e2bc05b52a07d51ae32748b73/appengine/chromium_rietveld/templates/diff.html
[modify] https://crrev.com/4847d8db35d75b3e2bc05b52a07d51ae32748b73/appengine/chromium_rietveld/new_static/components/cr-issue-message.html
[modify] https://crrev.com/4847d8db35d75b3e2bc05b52a07d51ae32748b73/appengine/chromium_rietveld/new_static/model/patch_file.js
[modify] https://crrev.com/4847d8db35d75b3e2bc05b52a07d51ae32748b73/appengine/chromium_rietveld/static/styles.css
[modify] https://crrev.com/4847d8db35d75b3e2bc05b52a07d51ae32748b73/appengine/chromium_rietveld/new_static/diff/cr-diff-cursor.html
[modify] https://crrev.com/4847d8db35d75b3e2bc05b52a07d51ae32748b73/appengine/chromium_rietveld/new_static/diff/cr-diff-messages.html
[modify] https://crrev.com/4847d8db35d75b3e2bc05b52a07d51ae32748b73/appengine/chromium_rietveld/templates/diff2.html
[delete] https://crrev.com/999be03fbbad217aa1fa319e378a59df18e8fa3d/appengine/chromium_rietveld/new_static/components/cr-issue-message-reply.html
[modify] https://crrev.com/4847d8db35d75b3e2bc05b52a07d51ae32748b73/appengine/chromium_rietveld/static/script.js
[delete] https://crrev.com/999be03fbbad217aa1fa319e378a59df18e8fa3d/appengine/chromium_rietveld/new_static/components/cr-issue-discard-drafts-dialog.html
[delete] https://crrev.com/999be03fbbad217aa1fa319e378a59df18e8fa3d/appengine/chromium_rietveld/templates/draft_message.html
[modify] https://crrev.com/4847d8db35d75b3e2bc05b52a07d51ae32748b73/appengine/chromium_rietveld/codereview/urls.py
[modify] https://crrev.com/4847d8db35d75b3e2bc05b52a07d51ae32748b73/appengine/chromium_rietveld/new_static/diff/cr-diff-message.html
[modify] https://crrev.com/4847d8db35d75b3e2bc05b52a07d51ae32748b73/appengine/chromium_rietveld/new_static/model/issue.js
[modify] https://crrev.com/4847d8db35d75b3e2bc05b52a07d51ae32748b73/appengine/chromium_rietveld/codereview/views.py
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/afb87de132bdd9feb84365955e2071966a4188f9

commit afb87de132bdd9feb84365955e2071966a4188f9
Author: Aaron Gable <agable@chromium.org>
Date: Wed Oct 18 00:27:10 2017

Rietveld: Remove "Publish+Mail" support for sending messages

Bug:  770327 
Change-Id: Ieb4967645a69283c9b37f6eea2ee7f5ccef895c3
Reviewed-on: https://chromium-review.googlesource.com/721077
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Jason Robbins <jrobbins@chromium.org>

[modify] https://crrev.com/afb87de132bdd9feb84365955e2071966a4188f9/appengine/chromium_rietveld/new_static/components/cr-issue.html
[modify] https://crrev.com/afb87de132bdd9feb84365955e2071966a4188f9/appengine/chromium_rietveld/templates/patch.html
[modify] https://crrev.com/afb87de132bdd9feb84365955e2071966a4188f9/appengine/chromium_rietveld/templates/base.html
[delete] https://crrev.com/4847d8db35d75b3e2bc05b52a07d51ae32748b73/appengine/chromium_rietveld/templates/publish.html
[modify] https://crrev.com/afb87de132bdd9feb84365955e2071966a4188f9/appengine/chromium_rietveld/templates/diff2.html
[modify] https://crrev.com/afb87de132bdd9feb84365955e2071966a4188f9/appengine/chromium_rietveld/templates/issue.html
[modify] https://crrev.com/afb87de132bdd9feb84365955e2071966a4188f9/appengine/chromium_rietveld/new_static/views/cr-file-view.html
[modify] https://crrev.com/afb87de132bdd9feb84365955e2071966a4188f9/appengine/chromium_rietveld/codereview/urls.py
[modify] https://crrev.com/afb87de132bdd9feb84365955e2071966a4188f9/appengine/chromium_rietveld/static/script.js
[modify] https://crrev.com/afb87de132bdd9feb84365955e2071966a4188f9/appengine/chromium_rietveld/templates/diff.html
[modify] https://crrev.com/afb87de132bdd9feb84365955e2071966a4188f9/appengine/chromium_rietveld/new_static/components/cr-app.html
[modify] https://crrev.com/afb87de132bdd9feb84365955e2071966a4188f9/appengine/chromium_rietveld/tests/test_views.py
[modify] https://crrev.com/afb87de132bdd9feb84365955e2071966a4188f9/appengine/chromium_rietveld/templates/issue_base.html
[delete] https://crrev.com/4847d8db35d75b3e2bc05b52a07d51ae32748b73/appengine/chromium_rietveld/new_static/components/cr-issue-publish-dialog.html
[modify] https://crrev.com/afb87de132bdd9feb84365955e2071966a4188f9/appengine/chromium_rietveld/new_static/model/issue.js
[modify] https://crrev.com/afb87de132bdd9feb84365955e2071966a4188f9/appengine/chromium_rietveld/codereview/views.py
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b3421915d7ceaea00ae51b946c097a3ae874e459

commit b3421915d7ceaea00ae51b946c097a3ae874e459
Author: Aaron Gable <agable@chromium.org>
Date: Wed Oct 18 17:30:44 2017

Rietveld: Fix some removals which got reverted by bad rebases

I'm not sure what happened, but some of the code which I had
deleted got re-added. In particular, the buildbucket.py deletions
in e82afb1 got accidentally reverted in 999be03, and the star width
in issue_row which got narrowed in 77a520f was reset in e82afb1.

TBR=tandrii

Bug:  770327 
Change-Id: I7adb7995fcbdb18db38cac2b47e6ebd7e71f566c
Reviewed-on: https://chromium-review.googlesource.com/726361
Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Jason Robbins <jrobbins@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/b3421915d7ceaea00ae51b946c097a3ae874e459/appengine/chromium_rietveld/codereview/buildbucket.py
[modify] https://crrev.com/b3421915d7ceaea00ae51b946c097a3ae874e459/appengine/chromium_rietveld/tests/test_buildbucket.py
[modify] https://crrev.com/b3421915d7ceaea00ae51b946c097a3ae874e459/appengine/chromium_rietveld/codereview/views_chromium.py
[modify] https://crrev.com/b3421915d7ceaea00ae51b946c097a3ae874e459/appengine/chromium_rietveld/templates/issue_row.html
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/6b0dc61cd5f0ccfacea301fd9501f5c3a6e9d06e

commit 6b0dc61cd5f0ccfacea301fd9501f5c3a6e9d06e
Author: Aaron Gable <agable@chromium.org>
Date: Wed Oct 18 17:47:53 2017

Rietveld: Remove support for editing and deleting changes

Bug:  770327 
Change-Id: I108b9c6a817b47c680f67e30e8ef31f5450bd97d
Reviewed-on: https://chromium-review.googlesource.com/721846
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Jason Robbins <jrobbins@chromium.org>

[modify] https://crrev.com/6b0dc61cd5f0ccfacea301fd9501f5c3a6e9d06e/appengine/chromium_rietveld/new_static/components/cr-issue.html
[delete] https://crrev.com/d65cf28a6e093fb194f37da8ce06068ccc597ec0/appengine/chromium_rietveld/templates/edit.html
[modify] https://crrev.com/6b0dc61cd5f0ccfacea301fd9501f5c3a6e9d06e/appengine/chromium_rietveld/static/styles.css
[delete] https://crrev.com/d65cf28a6e093fb194f37da8ce06068ccc597ec0/appengine/chromium_rietveld/new_static/components/cr-issue-editor.html
[modify] https://crrev.com/6b0dc61cd5f0ccfacea301fd9501f5c3a6e9d06e/appengine/chromium_rietveld/codereview/urls.py
[modify] https://crrev.com/6b0dc61cd5f0ccfacea301fd9501f5c3a6e9d06e/appengine/chromium_rietveld/templates/issue_base.html
[delete] https://crrev.com/d65cf28a6e093fb194f37da8ce06068ccc597ec0/appengine/chromium_rietveld/new_static/components/cr-issue-edit-dialog.html
[modify] https://crrev.com/6b0dc61cd5f0ccfacea301fd9501f5c3a6e9d06e/appengine/chromium_rietveld/new_static/model/issue.js
[modify] https://crrev.com/6b0dc61cd5f0ccfacea301fd9501f5c3a6e9d06e/appengine/chromium_rietveld/codereview/views.py
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/211edc36a0e630b56e84df193edbbebfbbe53024

commit 211edc36a0e630b56e84df193edbbebfbbe53024
Author: Aaron Gable <agable@chromium.org>
Date: Wed Oct 18 18:07:41 2017

Rietveld: Remove support for editing/deleting patchsets

Bug:  770327 
Change-Id: Ieda0966cdcad7106757ddcee78ae386c1b15eff5
Reviewed-on: https://chromium-review.googlesource.com/721847
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Jason Robbins <jrobbins@chromium.org>

[modify] https://crrev.com/211edc36a0e630b56e84df193edbbebfbbe53024/appengine/chromium_rietveld/new_static/components/cr-patchset-header.html
[modify] https://crrev.com/211edc36a0e630b56e84df193edbbebfbbe53024/appengine/chromium_rietveld/new_static/model/patch_set.js
[delete] https://crrev.com/6b0dc61cd5f0ccfacea301fd9501f5c3a6e9d06e/appengine/chromium_rietveld/new_static/components/cr-patchset-edit-dialog.html
[modify] https://crrev.com/211edc36a0e630b56e84df193edbbebfbbe53024/appengine/chromium_rietveld/templates/patchset.html
[modify] https://crrev.com/211edc36a0e630b56e84df193edbbebfbbe53024/appengine/chromium_rietveld/codereview/urls.py
[modify] https://crrev.com/211edc36a0e630b56e84df193edbbebfbbe53024/appengine/chromium_rietveld/codereview/models.py
[modify] https://crrev.com/211edc36a0e630b56e84df193edbbebfbbe53024/appengine/chromium_rietveld/templates/issue.html
[modify] https://crrev.com/211edc36a0e630b56e84df193edbbebfbbe53024/appengine/chromium_rietveld/static/script.js
[modify] https://crrev.com/211edc36a0e630b56e84df193edbbebfbbe53024/appengine/chromium_rietveld/codereview/views.py
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/f1024647247b8636ddd40e5f7247ec09ad59867b

commit f1024647247b8636ddd40e5f7247ec09ad59867b
Author: Aaron Gable <agable@chromium.org>
Date: Wed Oct 18 18:24:31 2017

Rietveld: remove specialized "revert patchset" ability and support

Bug:  770327 
Change-Id: I061ccdd2488c8dc4dde15cbbe258f005bd8a53b0
Reviewed-on: https://chromium-review.googlesource.com/721251
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/f1024647247b8636ddd40e5f7247ec09ad59867b/appengine/chromium_rietveld/codereview/exceptions.py
[modify] https://crrev.com/f1024647247b8636ddd40e5f7247ec09ad59867b/appengine/chromium_rietveld/new_static/model/patch_set.js
[delete] https://crrev.com/211edc36a0e630b56e84df193edbbebfbbe53024/appengine/chromium_rietveld/codereview/revert_patchset.py
[delete] https://crrev.com/211edc36a0e630b56e84df193edbbebfbbe53024/appengine/chromium_rietveld/codereview/invert_patches.py
[modify] https://crrev.com/f1024647247b8636ddd40e5f7247ec09ad59867b/appengine/chromium_rietveld/codereview/urls.py
[modify] https://crrev.com/f1024647247b8636ddd40e5f7247ec09ad59867b/appengine/chromium_rietveld/codereview/models.py
[delete] https://crrev.com/211edc36a0e630b56e84df193edbbebfbbe53024/appengine/chromium_rietveld/tests/test_invert_patches.py
[modify] https://crrev.com/f1024647247b8636ddd40e5f7247ec09ad59867b/appengine/chromium_rietveld/static/script.js
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/82b4634464fa21492d036dbcd4f024597769c65c

commit 82b4634464fa21492d036dbcd4f024597769c65c
Author: Aaron Gable <agable@chromium.org>
Date: Wed Oct 18 18:45:01 2017

Rietveld: Remove ability to upload new changes and patchsets

Bug:  770327 
Change-Id: Icfbb1434fc773bdfeba441ae4f80fa479d7561a3
Reviewed-on: https://chromium-review.googlesource.com/721855
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Jason Robbins <jrobbins@chromium.org>

[delete] https://crrev.com/12072973af2915b6c15c7d52179d65522520aac0/appengine/chromium_rietveld/upload.py
[modify] https://crrev.com/82b4634464fa21492d036dbcd4f024597769c65c/appengine/chromium_rietveld/settings.py
[delete] https://crrev.com/12072973af2915b6c15c7d52179d65522520aac0/appengine/chromium_rietveld/tools/uploadopts2wiki.py
[modify] https://crrev.com/82b4634464fa21492d036dbcd4f024597769c65c/appengine/chromium_rietveld/codereview/urls.py
[modify] https://crrev.com/82b4634464fa21492d036dbcd4f024597769c65c/appengine/chromium_rietveld/templates/issue_base.html
[modify] https://crrev.com/82b4634464fa21492d036dbcd4f024597769c65c/appengine/chromium_rietveld/codereview/views.py
[delete] https://crrev.com/12072973af2915b6c15c7d52179d65522520aac0/appengine/chromium_rietveld/templates/new.html
[delete] https://crrev.com/12072973af2915b6c15c7d52179d65522520aac0/appengine/chromium_rietveld/templates/use_uploadpy.html
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4ee58456be92f565d065a753951a0edb27c1f329

commit 4ee58456be92f565d065a753951a0edb27c1f329
Author: Aaron Gable <agable@chromium.org>
Date: Wed Oct 18 19:05:14 2017

Rietveld: Clean up and document miscellaneous POST handlers

This change removes a few of the remaining POST-only handlers.
It also removes the POST-handling code from some handlers which
previously accepted both GET and POST. In addition, it decorates
each remaining handler with an explicit documentation of which
methods it accepts, to return appropriate error codes to old
clients.

It does leave a few POST handlers behind; these are mostly
paths used by automated cron jobs which will be cleand up
in a followup.

R=jrobbins, tandrii

Bug:  770327 
Change-Id: Idb0d18847eaa91231a0f2a937502996999d5a925
Reviewed-on: https://chromium-review.googlesource.com/723855
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/4ee58456be92f565d065a753951a0edb27c1f329/appengine/chromium_rietveld/codereview/decorators.py
[modify] https://crrev.com/4ee58456be92f565d065a753951a0edb27c1f329/appengine/chromium_rietveld/codereview/views.py
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/55de161bab2eda13cdf1a7fa027f7a1eeeb469c9

commit 55de161bab2eda13cdf1a7fa027f7a1eeeb469c9
Author: Aaron Gable <agable@chromium.org>
Date: Wed Oct 18 19:44:26 2017

Rietveld: Remove RSS feeds

These feeds are unused (note the typo in the /rss/closd/ path),
and now have no updates to publish, so they're useless.

Bug:  770327 
Change-Id: I000011ec69344875e4206ae4dcd3725a52b769f8
Reviewed-on: https://chromium-review.googlesource.com/723612
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[delete] https://crrev.com/d460cbc01ca63c9b765b30fef44db48c2a2878c0/appengine/chromium_rietveld/templates/feeds/reviews_title.html
[modify] https://crrev.com/55de161bab2eda13cdf1a7fa027f7a1eeeb469c9/appengine/chromium_rietveld/static/robots.txt
[delete] https://crrev.com/d460cbc01ca63c9b765b30fef44db48c2a2878c0/appengine/chromium_rietveld/templates/feeds/all_description.html
[delete] https://crrev.com/d460cbc01ca63c9b765b30fef44db48c2a2878c0/appengine/chromium_rietveld/templates/feeds/closed_description.html
[delete] https://crrev.com/d460cbc01ca63c9b765b30fef44db48c2a2878c0/appengine/chromium_rietveld/templates/feeds/all_title.html
[delete] https://crrev.com/d460cbc01ca63c9b765b30fef44db48c2a2878c0/appengine/chromium_rietveld/templates/feeds/issue_title.html
[modify] https://crrev.com/55de161bab2eda13cdf1a7fa027f7a1eeeb469c9/appengine/chromium_rietveld/templates/base.html
[delete] https://crrev.com/d460cbc01ca63c9b765b30fef44db48c2a2878c0/appengine/chromium_rietveld/templates/feeds/issue_description.html
[delete] https://crrev.com/d460cbc01ca63c9b765b30fef44db48c2a2878c0/appengine/chromium_rietveld/templates/feeds/closed_title.html
[delete] https://crrev.com/d460cbc01ca63c9b765b30fef44db48c2a2878c0/appengine/chromium_rietveld/templates/feeds/template_description.html
[delete] https://crrev.com/d460cbc01ca63c9b765b30fef44db48c2a2878c0/appengine/chromium_rietveld/templates/feeds/mine_description.html
[modify] https://crrev.com/55de161bab2eda13cdf1a7fa027f7a1eeeb469c9/appengine/chromium_rietveld/codereview/urls.py
[delete] https://crrev.com/d460cbc01ca63c9b765b30fef44db48c2a2878c0/appengine/chromium_rietveld/templates/feeds/mine_title.html
[delete] https://crrev.com/d460cbc01ca63c9b765b30fef44db48c2a2878c0/appengine/chromium_rietveld/templates/feeds/reviews_description.html
[delete] https://crrev.com/d460cbc01ca63c9b765b30fef44db48c2a2878c0/appengine/chromium_rietveld/templates/feeds/template_title.html
[delete] https://crrev.com/d460cbc01ca63c9b765b30fef44db48c2a2878c0/appengine/chromium_rietveld/codereview/feeds.py
Project Member

Comment 18 by bugdroid1@chromium.org, Oct 19 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/39eb64c8fd03fddf49370eba710084ed03b66d48

commit 39eb64c8fd03fddf49370eba710084ed03b66d48
Author: Aaron Gable <agable@chromium.org>
Date: Thu Oct 19 16:22:05 2017
Project Member

Comment 19 by bugdroid1@chromium.org, Oct 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/50a99ceeab2deb29b328a0134b3b975b5c7cfaf1

commit 50a99ceeab2deb29b328a0134b3b975b5c7cfaf1
Author: Aaron Gable <agable@chromium.org>
Date: Fri Oct 27 23:37:27 2017

Rietveld: remove more dead code

This removes some code which became dead when I deleted various
email functionality, as well as code related to setting
dependencies, all of which is now unreachable.

Bug:  770327 
Change-Id: Ifec09667d45a539f9ba520995d99847e90b2b925
Reviewed-on: https://chromium-review.googlesource.com/742444
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[delete] https://crrev.com/0a1b4fc22f17d20fa50e4f52dafb65976156005b/appengine/chromium_rietveld/codereview/dependency_utils.py
[delete] https://crrev.com/0a1b4fc22f17d20fa50e4f52dafb65976156005b/appengine/chromium_rietveld/tests/test_dependency_utils.py
[modify] https://crrev.com/50a99ceeab2deb29b328a0134b3b975b5c7cfaf1/appengine/chromium_rietveld/codereview/models.py
[modify] https://crrev.com/50a99ceeab2deb29b328a0134b3b975b5c7cfaf1/appengine/chromium_rietveld/codereview/views.py
Project Member

Comment 20 by bugdroid1@chromium.org, Oct 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/e97ed50ae684c812fb9672fd1d9acbab30e1226a

commit e97ed50ae684c812fb9672fd1d9acbab30e1226a
Author: Aaron Gable <agable@chromium.org>
Date: Fri Oct 27 23:39:58 2017

Rietveld: remove db write operations when computing diffs

This is technically removing functionality -- without these
database writes, some information will have to be recomputed
more often rather than being cached. But we don't expect to
hit these codepaths very often anymore, so it isn't worth it.

Bug:  770327 
Change-Id: Icb40cc25b67a2e83e7b4ae5e5b4981c6d5c9008f
Reviewed-on: https://chromium-review.googlesource.com/742461
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/e97ed50ae684c812fb9672fd1d9acbab30e1226a/appengine/chromium_rietveld/codereview/models.py
[modify] https://crrev.com/e97ed50ae684c812fb9672fd1d9acbab30e1226a/appengine/chromium_rietveld/codereview/views.py
Project Member

Comment 21 by bugdroid1@chromium.org, Oct 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/efc10ee0f2c56f1f48e4138a8420cc2541b74912

commit efc10ee0f2c56f1f48e4138a8420cc2541b74912
Author: Aaron Gable <agable@chromium.org>
Date: Fri Oct 27 23:40:18 2017

Rietveld: fix old UI rendering of message threads

Turns out the old UI needs to have a div at the bottom
of each message to prevent them from overlapping each
other. Since it no longer contains any controls (namely
"reply"), I renamed the div as well.

Bug:  770327 
Change-Id: I58df57ac398cb7fdd30451f45fe9c3891b8d0f8c
Reviewed-on: https://chromium-review.googlesource.com/742445
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/efc10ee0f2c56f1f48e4138a8420cc2541b74912/appengine/chromium_rietveld/static/styles.css
[modify] https://crrev.com/efc10ee0f2c56f1f48e4138a8420cc2541b74912/appengine/chromium_rietveld/templates/issue.html
Project Member

Comment 22 by bugdroid1@chromium.org, Nov 2 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/af8cef975fab1f9e84ab7690de13ae6bce730b9a

commit af8cef975fab1f9e84ab7690de13ae6bce730b9a
Author: Aaron Gable <agable@chromium.org>
Date: Thu Nov 02 16:59:15 2017
Project Member

Comment 23 by bugdroid1@chromium.org, Nov 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/c59738523c35c088d2f665b2169ea2dd9e07a508

commit c59738523c35c088d2f665b2169ea2dd9e07a508
Author: Aaron Gable <agable@chromium.org>
Date: Thu Nov 02 20:34:36 2017

Change rietveld.py to use GET on get_depends_on_patchset

Bug:  770327 
Change-Id: I9dd0ed0be0761de4968136f563e8986b979c35cf
Reviewed-on: https://chromium-review.googlesource.com/723824
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Ravi Mistry <rmistry@chromium.org>

[modify] https://crrev.com/c59738523c35c088d2f665b2169ea2dd9e07a508/rietveld.py
Project Member

Comment 26 by bugdroid1@chromium.org, Nov 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/dc598cd813f7e476be0f84d73886b884cf3d4c9a

commit dc598cd813f7e476be0f84d73886b884cf3d4c9a
Author: Aaron Gable <agable@chromium.org>
Date: Thu Nov 02 23:57:59 2017

Rietveld: remove all account statistic tracking and display

Bug:  770327 
Change-Id: I24af3dd1f778d2aedf5d0ccbac24d434d97524d9
Reviewed-on: https://chromium-review.googlesource.com/752196
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/dc598cd813f7e476be0f84d73886b884cf3d4c9a/appengine/chromium_rietveld/index.yaml
[delete] https://crrev.com/9c381f0af83e208d6e93a9fa95d5fa6011bd7447/appengine/chromium_rietveld/tests/skip_test_views_stats.py
[delete] https://crrev.com/9c381f0af83e208d6e93a9fa95d5fa6011bd7447/appengine/chromium_rietveld/templates/user_stats.html
[delete] https://crrev.com/9c381f0af83e208d6e93a9fa95d5fa6011bd7447/appengine/chromium_rietveld/static/leaderboard.css
[modify] https://crrev.com/dc598cd813f7e476be0f84d73886b884cf3d4c9a/appengine/chromium_rietveld/codereview/urls.py
[modify] https://crrev.com/dc598cd813f7e476be0f84d73886b884cf3d4c9a/appengine/chromium_rietveld/codereview/models.py
[delete] https://crrev.com/9c381f0af83e208d6e93a9fa95d5fa6011bd7447/appengine/chromium_rietveld/templates/leaderboard.html
[modify] https://crrev.com/dc598cd813f7e476be0f84d73886b884cf3d4c9a/appengine/chromium_rietveld/codereview/views.py

Comment 29 by aga...@chromium.org, Nov 3 2017

Cc: susanjuniab@chromium.org
 Issue 776717  has been merged into this issue.
Project Member

Comment 30 by bugdroid1@chromium.org, Dec 1 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/b0f13afe9de5b9df2547925e4f4258d96d0ee80b

commit b0f13afe9de5b9df2547925e4f4258d96d0ee80b
Author: Aaron Gable <agable@chromium.org>
Date: Fri Dec 01 23:08:02 2017

Comment 31 by aga...@chromium.org, Dec 18 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment