New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 770325 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature



Sign in to add a comment

Update reef-uni touch firmware to use cros_config

Project Member Reported by sjg@chromium.org, Sep 29 2017

Issue description

At present the ebuild does lots of manual operations.

Update it to do this automatically as a test of the cros_config approach.

binding here:

https://chromium-review.googlesource.com/c/chromiumos/platform2/+/690435

 

Comment 1 by sjg@chromium.org, Sep 29 2017

Status: Started (was: Untriaged)

Comment 2 by sjg@chromium.org, Sep 29 2017

Owner: sjg@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 4 2017

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 4 2017

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 5 2017

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 10 2017

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/adee2e5380a776378dc415bf4fd7d2a28217a753

commit adee2e5380a776378dc415bf4fd7d2a28217a753
Author: Simon Glass <sjg@chromium.org>
Date: Tue Oct 10 03:07:53 2017

chromeos-config: Tweak the README for touch firmware

The wacom firmware should have the subdirectory included. Also switch
one of the examples to weida since it allows use of the data code.

BUG= chromium:770325 
TEST=FEATURES=test emerge-reef-uni chromeos-config-tools

Change-Id: I5e254ab26a06930a461e6a3d5ca7ddc0d78223c7
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/706606
Reviewed-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: Alec Thilenius <athilenius@chromium.org>

[modify] https://crrev.com/adee2e5380a776378dc415bf4fd7d2a28217a753/chromeos-config/README.md

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 16 2017

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e120a5dfa658e3bd97889f8974646f6be696a362

commit e120a5dfa658e3bd97889f8974646f6be696a362
Author: Simon Glass <sjg@chromium.org>
Date: Wed Oct 18 15:30:14 2017

cros-unibuild: Add the missing _install_fw() function

This is present on reef but not coral. We should not be relying on the
including ebuild to provide this. Add a local implementation.

BUG= chromium:770325 
TEST=With YH's CL *474653
emerge-coral --nodeps chromeos-touch-firmware-coral
$ find /build/coral/opt/google/touch/firmware/
/build/coral/opt/google/touch/firmware/
/build/coral/opt/google/touch/firmware/elan
/build/coral/opt/google/touch/firmware/elan/154.0_2.0.bin
/build/coral/opt/google/touch/firmware/elan/1cd2_5603.bin
/build/coral/opt/google/touch/firmware/wacom
/build/coral/opt/google/touch/firmware/wacom/wacom_1636.hex

Check that symlinks in /lib/firmware point to these files

Change-Id: I1cb149e33610e4188dc22440f53f7624286b6655
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/723727
Commit-Ready: YH Lin <yueherngl@chromium.org>
Tested-by: YH Lin <yueherngl@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/e120a5dfa658e3bd97889f8974646f6be696a362/eclass/cros-unibuild.eclass

Comment 10 by sjg@chromium.org, Oct 19 2017

Status: Fixed (was: Started)
Labels: Merge-Request-63 OS-Chrome
Project Member

Comment 12 by sheriffbot@chromium.org, Dec 5 2017

Labels: -Merge-Request-63 Merge-Review-63 Hotlist-Merge-Review
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-63 Merge-Approved-63
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 5 2017

Labels: merge-merged-release-R63-10032.B
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/baseboard-reef-private/+/0bf502af689528a7d74bd73f68243b5c8b43d2e9

commit 0bf502af689528a7d74bd73f68243b5c8b43d2e9
Author: Simon Glass <sjg@chromium.org>
Date: Tue Dec 05 23:22:25 2017

Project Member

Comment 15 by sheriffbot@chromium.org, Dec 11 2017

Cc: ssmadan@chromium.org gkihumba@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 16 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 17 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
Project Member

Comment 18 by sheriffbot@chromium.org, Feb 12 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment