unit_tests ActiveTabTest.DelegateIsSet is flaky https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=unit_tests&tests=ActiveTabTest http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20(1)/builds/45191 https://chromium-swarm.appspot.com/task?id=38e62ba86a648d10&refresh=10&show_raw=1 [ RUN ] ActiveTabTest.DelegateIsSet ../../chrome/browser/extensions/active_tab_unittest.cc:480: Failure Value of: IsAllowed(extension, google) Actual: false Expected: true [ FAILED ] ActiveTabTest.DelegateIsSet (24 ms)
Still extremely flaky, so I'm going to disable this test.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef9f5167b5af04e9795d88dce2c091544af72953 commit ef9f5167b5af04e9795d88dce2c091544af72953 Author: Marijn Kruisselbrink <mek@chromium.org> Date: Fri Dec 22 19:04:56 2017 Disable ActiveTabTest.DelegateIsSet because it is extremely flaky. TBR=rdevlin.cronin@chromium.org Bug: 770305 Change-Id: Ia8f61e1bbc8aa9f2af1fe4f47bcb7a2d1050edaa Reviewed-on: https://chromium-review.googlesource.com/842223 Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#526035} [modify] https://crrev.com/ef9f5167b5af04e9795d88dce2c091544af72953/chrome/browser/extensions/active_tab_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae9ea252a77feb19465be85ef4e57bffe7384601 commit ae9ea252a77feb19465be85ef4e57bffe7384601 Author: Ivan Sandrk <isandrk@google.com> Date: Tue Jan 09 16:49:36 2018 Unflake ActiveTabTest.DelegateIsSet Source of flakiness: base::RunLoop().RunUntilIdle() Bug: chromium:770305 Change-Id: I9b37092b67d4189f7afceeed286c9f2210985b25 Reviewed-on: https://chromium-review.googlesource.com/852534 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#528020} [modify] https://crrev.com/ae9ea252a77feb19465be85ef4e57bffe7384601/chrome/browser/chromeos/extensions/active_tab_permission_granter_delegate_chromeos.cc [modify] https://crrev.com/ae9ea252a77feb19465be85ef4e57bffe7384601/chrome/browser/chromeos/extensions/active_tab_permission_granter_delegate_chromeos.h [modify] https://crrev.com/ae9ea252a77feb19465be85ef4e57bffe7384601/chrome/browser/extensions/active_tab_unittest.cc
Sorry for not tending to this earlier, it should be fixed now.
Comment 1 by mek@chromium.org
, Dec 22 2017