New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 770273 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

TestSimpleChromeWorkflow: wrong version of `cros` used

Project Member Reported by michae...@chromium.org, Sep 29 2017

Issue description

TestSimpleChromeWorkflow tests the SimpleChrome workflow, which builds Chrome for a board by entering a chroot via `cros chrome-sdk --board=$BOARD`.

When you run `cros`, the depot_tools "cros" script runs (depot_tools is in your $PATH). But the real `cros` script actually lives in the chromite repository. So depot_tools redirects the call to cros by searching for your chromite directory and running chromite/scripts/cros.

depot_tools searches several places for chromite, but starts by looking for a Chrome OS repo before looking for a Chrome checkout.[1]

Developers using SimpleChrome are likely running the `cros` command from their Chrome checkout, so the `cros` that runs is the version in src/third_party/bin/cros.

However, the TestSimpleChromeWorkflow stage runs `cros` from the chromite repo, Chrome OS style. TestSimpleChromeWorkflow should be updated to run `cros` inside of the chrome src directory.

If other chromite binaries run from outside the chrome src directory, we should ensure they also use the correct version.

[1] https://cs.chromium.org/chromium/tools/depot_tools/support/chromite_wrapper?q=file:tools/depot_tools/support/chromite_wrapper+_findchromite&l=32

 
Labels: -Pri-1 Pri-2
Cc: steve...@chromium.org
Owner: ----
Status: Available (was: Assigned)
Hi, this bug has not been updated recently. Please acknowledge the bug and provide status within two weeks (6/22/2018), or the bug will be archived. Thank you.

Sign in to add a comment