TestSimpleChromeWorkflow: wrong version of `cros` used |
||
Issue descriptionTestSimpleChromeWorkflow tests the SimpleChrome workflow, which builds Chrome for a board by entering a chroot via `cros chrome-sdk --board=$BOARD`. When you run `cros`, the depot_tools "cros" script runs (depot_tools is in your $PATH). But the real `cros` script actually lives in the chromite repository. So depot_tools redirects the call to cros by searching for your chromite directory and running chromite/scripts/cros. depot_tools searches several places for chromite, but starts by looking for a Chrome OS repo before looking for a Chrome checkout.[1] Developers using SimpleChrome are likely running the `cros` command from their Chrome checkout, so the `cros` that runs is the version in src/third_party/bin/cros. However, the TestSimpleChromeWorkflow stage runs `cros` from the chromite repo, Chrome OS style. TestSimpleChromeWorkflow should be updated to run `cros` inside of the chrome src directory. If other chromite binaries run from outside the chrome src directory, we should ensure they also use the correct version. [1] https://cs.chromium.org/chromium/tools/depot_tools/support/chromite_wrapper?q=file:tools/depot_tools/support/chromite_wrapper+_findchromite&l=32
,
Nov 30 2017
,
Jun 8 2018
Hi, this bug has not been updated recently. Please acknowledge the bug and provide status within two weeks (6/22/2018), or the bug will be archived. Thank you. |
||
►
Sign in to add a comment |
||
Comment 1 by michae...@chromium.org
, Sep 29 2017