New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 770263 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

cryptotoken should be closure compiled for typechecking

Project Member Reported by rdevlin....@chromium.org, Sep 29 2017

Issue description

chrome/browser/resources/cryptotoken contains the source for the cryptotoken extension.  We should make sure it's being closure compiled for typechecking.  This will ensure that changes in the chromium tree break the closure compiler bot if there's type failures.

I'll see if I can't add a few quick targets for this to start the process, but probably won't have the bandwidth the whole project.  Other folks, feel free to jump in once I've landed the first few. :)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e5fdc9e81f854a0aeb0fa92203d17129887cbc5

commit 0e5fdc9e81f854a0aeb0fa92203d17129887cbc5
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Thu Oct 05 14:50:13 2017

[Cryptotoken] Begin closure compiling the cryptotoken resources

The cryptotoken resources aren't currently closure compiled, but
probably should be. Add a few of the simple targets to start.

Bug: 770263
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I41284a7b3e4ec8a1d4ec2394f8cd340150b6e271
Reviewed-on: https://chromium-review.googlesource.com/692983
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506730}
[add] https://crrev.com/0e5fdc9e81f854a0aeb0fa92203d17129887cbc5/chrome/browser/resources/cryptotoken/compiled_resources2.gyp
[modify] https://crrev.com/0e5fdc9e81f854a0aeb0fa92203d17129887cbc5/third_party/closure_compiler/compiled_resources2.gyp

Project Member

Comment 2 by sheriffbot@chromium.org, Oct 5

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)
Status: Untriaged (was: Available)
Available, but no owner or component? Please find a component, as no one will ever find this without one.

Sign in to add a comment