Flickering in content suggestions when articles gets added to the Reading list |
||||||||
Issue description
App Version: 62.0.3202.39 beta
iOS Version: 11.0
Device: iPhone 8
URL: NA
Precondition:
Device Settings --> Chrome Beta --> Experimental Settings --> Enable Content Suggestions : Enabled
Steps to reproduce:
1. Launch the app
2. Open NTP
3. Scroll down to the Articles section
3. Long Tap on Articles
4. From the Menu choose Read Later
5. Tap on Read Later
Observed results:
Notice that when articles is added to the top of the reading list, the page flickers
Expected results:
The page flickers while adding Articles to Reading list
Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA
Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA
Bug reproducible on current stable build (App Version, iOS Version): M61 , No
Bug reproducible on the current beta channel build (App Version, iOS Version): M62, Yes
Bug reproducible on Chrome desktop? No
Link to image:
https://drive.google.com/a/google.com/file/d/0BwSBFDzHIX-mVDFNQzdDUWZGbzg/view
,
Sep 29 2017
,
Oct 2 2017
,
Oct 2 2017
,
Oct 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/716dd42d4a06ec7e9407c11ff52b3c57fcfac717 commit 716dd42d4a06ec7e9407c11ff52b3c57fcfac717 Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Oct 20 13:07:33 2017 Remove flicker on NTP when saving items for later When adding a suggestion to the Reading List, a visible flicker is seen on the Reading List section of the NTP because an empty section item is added to it before replacing it by the new Reading List pages. This CL prevents this flickering by not adding the transient empty section item. Bug: 770258 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie8c8c0ab6a40ce26e833ceba14462b9ea83aa313 Reviewed-on: https://chromium-review.googlesource.com/730683 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#510415} [modify] https://crrev.com/716dd42d4a06ec7e9407c11ff52b3c57fcfac717/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
,
Oct 20 2017
,
Oct 24 2017
Tested the following Build, this issue is not fixed yet. please check if the fix has been merged to latest Canary build Build -64.0.3248.0 canary Devices - iPhone 8, iPad mini, iPhone 6 iOS - 11.1 , 11.0.2 , 11.0.3
,
Oct 24 2017
,
Oct 25 2017
There is still a flickering as we are replacing the current items displayed, which indicate that something has happened. This flickering also happens when we are adding once again the first Reading List item displayed. In that case the state of the Reading List section is the same before and after the addition, but there is still a flickering. This is expected as it is treated as a different item in the backend (some properties of the object are changed). But the flickering of the "That's all" empty item is fixed.
,
Oct 25 2017
Verified fix for the issue "Flickering in content suggestions when articles gets added to the Reading list" Build - 64.0.3249.0 Canary Devices -iPad mini, iPhone 8, iPhone 6 iOS - 11.1, 11.0.3 |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by jdhakshinamoor@chromium.org
, Sep 29 2017