PFQ failure in TestSimpleChromeWorkflow: chrome checkout not found |
|||||||
Issue descriptionThe PFQ builders amd64-generic-chromium-pfq, arm-generic-chromium-pfq, and daisy-chromium-pfq have begun failing in TestSimpleChromeWorkflow (the other PFQ builders don't get to that step due to issue 769369). It seems the chrome checkout can't be found. Sample failure: https://uberchromegw.corp.google.com/i/chromeos/builders/amd64-generic-chromium-pfq/builds/10665 Unlike good builds, in these failures the args.gn file does not exist where the builder expects it: ``` 23:36:32: WARNING: No args.gn file: /b/c/cbuild/repository/.cache/distfiles/target-master/chrome-src/src/out_amd64-generic/Release/args.gn ``` Then it runs `gn gen`, which fails with: ``` gn.py: Could not find checkout in any parent of the current path. This must be run inside a checkout. 23:36:32: ERROR: cros chrome-sdk failed before completing. ``` Stack trace: ``` Traceback (most recent call last): File "/b/c/cbuild/repository/chromite/bin/cros", line 168, in <module> DoMain() File "/b/c/cbuild/repository/chromite/bin/cros", line 164, in DoMain commandline.ScriptWrapperMain(FindTarget) File "/b/c/cbuild/repository/chromite/lib/commandline.py", line 910, in ScriptWrapperMain ret = target(argv[1:]) File "/b/c/cbuild/repository/chromite/scripts/cros.py", line 65, in main code = _RunSubCommand(subcommand) File "/b/c/cbuild/repository/chromite/scripts/cros.py", line 50, in _RunSubCommand return subcommand.Run() File "/b/c/cbuild/repository/chromite/cli/cros/cros_chrome_sdk.py", line 1052, in Run goma_dir=goma_dir, goma_port=goma_port) File "/b/c/cbuild/repository/chromite/cli/cros/cros_chrome_sdk.py", line 874, in _SetupEnvironment self._UpdateGnArgsIfStale(gn_args, gn_args_file_path, env['SDK_BOARD']) File "/b/c/cbuild/repository/chromite/cli/cros/cros_chrome_sdk.py", line 652, in _UpdateGnArgsIfStale capture_output=False) File "/b/c/cbuild/repository/chromite/lib/cros_build_lib.py", line 653, in RunCommand raise RunCommandError(msg, cmd_result) chromite.lib.cros_build_lib.RunCommandError: return code: 1; command: gn gen out_amd64-generic/Release '--args=use_ozone = true ... ```
,
Sep 29 2017
,
Sep 29 2017
,
Sep 29 2017
Suspecting stevenjb's change: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/675567 which made it into the first failing builder run.
,
Sep 29 2017
I chumped a revert[1] of that CL. Waiting for builders to go green. The issue was that the culprit CL ran `gn gen` from the CWD. TestSimpleChromeWorkflow runs from a Chrome OS repo, not from a Chrome checkout, so `gn` couldn't find the Chrome checkout. (Since the builder passes the --chrome-src path into SimpleChrome, an easy fix is to use that path as the CWD for the `gn` command.) This error wouldn't have surfaced yet if we ran TestSimpleChromeWorkflow from the Chrome checkout, because running from the Chrome OS repo causes a different version of chromite to be used. The version of chromite used in Chrome doesn't yet include stevenjb's CL. I filed issue 770273 to ensure TestSimpleChromeWorkflow uses the same version of chromite that SimpleChrome users will be using, the Chrome version. [1] https://chromium-review.googlesource.com/c/chromiumos/chromite/+/693114
,
Sep 29 2017
Does this have the same root cause as crbug.com/769369?
,
Sep 29 2017
No, this was unrelated, the suspition in comment in #4 was correct and the offending CL was reverted.
,
Sep 30 2017
,
Jan 22 2018
,
Jan 23 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by michae...@chromium.org
, Sep 29 2017Labels: Hotlist-CrOS-Gardener