New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 770246 link

Starred by 1 user
Status: Fixed
Owner:
emir...@chromium.org
Closed: Oct 2017
Cc:
█ junov@chromium.org
niklase@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Improve reading SkImage pixels in canvas captureStream()

Project Member Reported by emir...@chromium.org, Sep 29 2017 
We use readPixels() to access the underlying data for canvas capture, but there cna be some improvements over it:
- Instead of asking for ARGB specifically, we can use the native N32 type. After accessing pixels, we either way do a conversion to I420 so reading ARGB/ABGR wouldn't matter.
- Handle cases where peekPixels() is available.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29531e32e04f3505590d6f6e6568e2200e53866b

commit 29531e32e04f3505590d6f6e6568e2200e53866b
Author: Emircan Uysaler <emircan@chromium.org>
Date: Fri Oct 06 20:39:37 2017

Improve reading SkImage pixels in canvas captureStream()

- Instead of asking for ARGB specifically, we can use the native N32 type. 
After accessing pixels, we either way do a conversion to I420 so reading 
ARGB/ABGR wouldn't matter.
- Handle cases where peekPixels() is available.

Bug:  770246 
Change-Id: Iab2d129493baf4575389410cd616e1c6eeac2343
Reviewed-on: https://chromium-review.googlesource.com/691041
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507169}
[modify] https://crrev.com/29531e32e04f3505590d6f6e6568e2200e53866b/content/renderer/media_capture_from_element/canvas_capture_handler.cc

Comment 2 by emir...@chromium.org, Oct 6 2017

Status: Fixed (was: Started)
►

Sign in to add a comment