Cannot select LUCI linux_chromium_rel_ng try job in gerrit |
||
Issue descriptionYou can't pick LUCI linux_chromium_rel_ng on gerrit. To reproduce: click on choose try jobs. select LUCI linux_chromium_rel_ng in dialog. click "Add" button. Nothing happens. I've tried tracing this in js, "Add" makes a call to server, which responds with error: "Builder u'LUCI linux_chromium_rel_ng' is not defined in bucket u'luci.chromium.try'" The error is not displayed because resp.ok is true inside cr-tryjob-picker.js:160
,
Sep 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/5fd5f9437ede37b87d6c395839e4d811ba26cedf commit 5fd5f9437ede37b87d6c395839e4d811ba26cedf Author: Nodir Turakulov <nodir@google.com> Date: Fri Sep 29 21:04:43 2017 Check error in buidbucket response _handleTriggerResponse contains check if resp.ok, which is always true because otherwise the function wouldn't be called. Check if response object contains error property instead. R=agable@chromium.org Bug: 770242 Change-Id: Icdc4b1f020008e7aa85e4e39a72e4f56498b9aba Reviewed-on: https://chromium-review.googlesource.com/692565 Reviewed-by: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/5fd5f9437ede37b87d6c395839e4d811ba26cedf/src/main/resources/static/cr-tryjob-picker.js
,
Oct 6 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by no...@chromium.org
, Sep 29 2017