On kernel 4.4 we need to get back missing firmware files |
||
Issue descriptionWe recently landed http://crosreview.com/677606 which stopped running firmware_install on kernel 4.4. The argument was that we would be getting the relevant firmware from the linux-firmware ebuild. However, even though the firmware files _are_ in the linux-firmware ebuild, we don't install them. Moreover the linux-firmware ebuild is older than kernel-4.4's firmware. We should probably go back to installing firmware on kernel 4.4 for now. Even if we don't use any of that firmware for builtin peripherals, I could imagine that it might be relevant for users that are plugging in things from USB (TBD: is this right?). Long term we should figure out a better plan in bug #770230
,
Oct 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/adcca2eff6c70cc5edb4c473ab4ad85ba3f642ab commit adcca2eff6c70cc5edb4c473ab4ad85ba3f642ab Author: Guenter Roeck <groeck@chromium.org> Date: Tue Oct 03 00:27:18 2017 Install kernel firmware on chromeos-4_4 Turns out we still use the in-kernel firmware in our builds, and do not install/use the firmware from the firmware repository. BUG= chromium:770234 TEST=Build and install image and observe files in /lib/firmware Change-Id: I715fe27d3f34590dd82da3543912e4803384a72b Signed-off-by: Guenter Roeck <groeck@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/692617 Reviewed-by: Douglas Anderson <dianders@chromium.org> [modify] https://crrev.com/adcca2eff6c70cc5edb4c473ab4ad85ba3f642ab/profiles/targets/chromeos/package.use
,
Oct 3 2017
,
Jan 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e5497a62e2bfef37f9d44a9a6e18e9e2a2fa764 commit 4e5497a62e2bfef37f9d44a9a6e18e9e2a2fa764 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Wed Jan 17 06:12:31 2018 Don't check position_needs_update_ in PaintLayer::RectIgnoringNeedsPositionUpdate() so that we won't crash in showLayerTree() when some layer has dirty position. Bug: 770234 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I7e2a24413a1a9a5912651101e6d295c782232e19 Reviewed-on: https://chromium-review.googlesource.com/868637 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#529649} [modify] https://crrev.com/4e5497a62e2bfef37f9d44a9a6e18e9e2a2fa764/third_party/WebKit/Source/core/paint/PaintLayer.cpp [modify] https://crrev.com/4e5497a62e2bfef37f9d44a9a6e18e9e2a2fa764/third_party/WebKit/Source/core/paint/PaintLayer.h |
||
►
Sign in to add a comment |
||
Comment 1 by groeck@chromium.org
, Sep 29 2017