Issue metadata
Sign in to add a comment
|
Configure bots to run the same benchmark with and without Heap Profiler |
||||||||||||||||||||||||
Issue descriptionAs a result of long offline discussion we have to check performance of heap profiling by producing multiple graphs in the performance dashboard. All series should measure the same benchmark with different modes of heap profiling. Example bot configuration: [1] https://cs.chromium.org/chromium/src/testing/buildbot/chromium.android.fyi.json?l=2332 Also need to move benchmarks to /contrib enable them on perf FYI waterfall.
,
Sep 29 2017
Issue 757747 has been merged into this issue.
,
Oct 3 2017
The NextAction date has arrived: 2017-10-03
,
Oct 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4bfb883797f56b3eedd928a71752ebb353a9ff33 commit 4bfb883797f56b3eedd928a71752ebb353a9ff33 Author: Greg Kraynov <kraynov@chromium.org> Date: Thu Oct 26 19:33:10 2017 Memory Infra: Telemetry benchmark for heap profiling overhead. Bug: 770203 Change-Id: I033a82cbb67b8ff389f610ec7723311abc844b7e Reviewed-on: https://chromium-review.googlesource.com/725817 Commit-Queue: Grigoriy Kraynov <kraynov@chromium.org> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#511923} [add] https://crrev.com/4bfb883797f56b3eedd928a71752ebb353a9ff33/tools/perf/contrib/heap_profiling/OWNERS [add] https://crrev.com/4bfb883797f56b3eedd928a71752ebb353a9ff33/tools/perf/contrib/heap_profiling/__init__.py [add] https://crrev.com/4bfb883797f56b3eedd928a71752ebb353a9ff33/tools/perf/contrib/heap_profiling/heap_profiling.py [modify] https://crrev.com/4bfb883797f56b3eedd928a71752ebb353a9ff33/tools/perf/page_sets/system_health/system_health_stories.py
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e51b0e8079a3929896e4dcc43feef47f16dd2fc commit 5e51b0e8079a3929896e4dcc43feef47f16dd2fc Author: Greg Kraynov <kraynov@chromium.org> Date: Wed Nov 08 11:27:30 2017 Support Android for (contrib) heap_profiling benchmark. Bug: 770203 Change-Id: Ib56dcbc4bfa74e4c23119f4c3262531227ea9139 Reviewed-on: https://chromium-review.googlesource.com/756840 Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#514799} [modify] https://crrev.com/5e51b0e8079a3929896e4dcc43feef47f16dd2fc/tools/perf/contrib/heap_profiling/heap_profiling.py [modify] https://crrev.com/5e51b0e8079a3929896e4dcc43feef47f16dd2fc/tools/perf/page_sets/system_health/system_health_stories.py
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2404a5191202aa232efccde18439a4d2e6ae34d commit a2404a5191202aa232efccde18439a4d2e6ae34d Author: Greg Kraynov <kraynov@chromium.org> Date: Wed Nov 08 11:58:26 2017 Enable heap profiling benchmark on FYI Memory Infra Tester. Bug: 770203 Change-Id: I0fd3384c79efad32bca60b6e291a4d0fbbb3b524 Reviewed-on: https://chromium-review.googlesource.com/756839 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#514802} [modify] https://crrev.com/a2404a5191202aa232efccde18439a4d2e6ae34d/testing/buildbot/chromium.perf.fyi.json [modify] https://crrev.com/a2404a5191202aa232efccde18439a4d2e6ae34d/tools/perf/chromium.perf.fyi.extras.json
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2ac64152ffa7959288361126d330fd26c554ab8 commit a2ac64152ffa7959288361126d330fd26c554ab8 Author: Greg Kraynov <kraynov@chromium.org> Date: Wed Nov 08 15:49:32 2017 Revert: Enable heap profiling benchmark on FYI Memory Infra Tester. Reason: Memory Infra Tester is on chromium.android.fyi waterfall, not on chromium.perf.fyi one. Sorry for mistake. Bug: 770203 Change-Id: I6a41d40f5c2cde879e254e58ea555459c549f899 Reviewed-on: https://chromium-review.googlesource.com/758267 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#514843} [modify] https://crrev.com/a2ac64152ffa7959288361126d330fd26c554ab8/testing/buildbot/chromium.perf.fyi.json [modify] https://crrev.com/a2ac64152ffa7959288361126d330fd26c554ab8/tools/perf/chromium.perf.fyi.extras.json
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c33d6b1903e95154d1b5a9f773a1b8a844871e23 commit c33d6b1903e95154d1b5a9f773a1b8a844871e23 Author: Greg Kraynov <kraynov@chromium.org> Date: Wed Nov 08 22:09:03 2017 Replace test benchmarks in android.fyi Memory Infra Tester. Replaced system_health tests with new benchmarks which offer better test coverage (checks that heap profiling isn't crashing). That bot may be moved to chromium.perf.fyi waterfall, so we can upload results afterwards, but it's disabled for now. Bug: 770203 Change-Id: Ibc72fe7cd663d642554232215f48e77d74d046c4 Reviewed-on: https://chromium-review.googlesource.com/758269 Reviewed-by: Benjamin Pastene <bpastene@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Primiano Tucci <primiano@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#514963} [modify] https://crrev.com/c33d6b1903e95154d1b5a9f773a1b8a844871e23/testing/buildbot/chromium.android.fyi.json
,
Nov 9 2017
Benchmarks https://cs.chromium.org/chromium/src/tools/perf/contrib/heap_profiling/heap_profiling.py?q=PseudoHeapProfilingDesktopBenchmark are up and running on https://build.chromium.org/p/chromium.android.fyi/builders/Memory%20Infra%20Tester and produce sensible results. However, results aren't uploading to perf dashboard, because benchmarks have to run on chromium.perf* waterfall. I've filed a bug for that https://crbug.com/783201 and closing this bug. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by kraynov@chromium.org
, Sep 29 2017