New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 770168 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 583290



Sign in to add a comment

Record UMA for Doodles on local NTP

Project Member Reported by treib@chromium.org, Sep 29 2017

Issue description

We should record UMA for Doodle impressions, clicks, and latency. It would be nice if we could record the same histograms as on Android, NewTabPage.Logo*.
 

Comment 1 by treib@chromium.org, Sep 29 2017

Blocking: 583290

Comment 2 by treib@chromium.org, Sep 29 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f28c4243705f87d6cfe59aa49bf1d3dab869f1b

commit 8f28c4243705f87d6cfe59aa49bf1d3dab869f1b
Author: Marc Treib <treib@chromium.org>
Date: Mon Oct 02 07:57:42 2017

Local NTP: Record Doodle impression and load time histograms

TBRing simple description updates in histograms.xml
TBR=asvitkine

Bug:  770168 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7f80f3a6644963acfbec769f5c8901737843c72f
Reviewed-on: https://chromium-review.googlesource.com/692294
Reviewed-by: Chris Pickel <sfiera@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505555}
[modify] https://crrev.com/8f28c4243705f87d6cfe59aa49bf1d3dab869f1b/chrome/browser/resources/local_ntp/local_ntp.js
[modify] https://crrev.com/8f28c4243705f87d6cfe59aa49bf1d3dab869f1b/chrome/browser/ui/search/ntp_user_data_logger.cc
[modify] https://crrev.com/8f28c4243705f87d6cfe59aa49bf1d3dab869f1b/chrome/browser/ui/search/ntp_user_data_logger.h
[modify] https://crrev.com/8f28c4243705f87d6cfe59aa49bf1d3dab869f1b/chrome/common/search/ntp_logging_events.h
[modify] https://crrev.com/8f28c4243705f87d6cfe59aa49bf1d3dab869f1b/tools/metrics/histograms/histograms.xml

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e2972e4ba9a79520fa7d75e491b7fdfb1009393

commit 5e2972e4ba9a79520fa7d75e491b7fdfb1009393
Author: Marc Treib <treib@chromium.org>
Date: Mon Oct 02 12:17:47 2017

Local NTP: Record Doodle click histogram

TBRing simple description updates in histograms.xml
TBR=asvitkine

Bug:  770168 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie960ede0c6fc9683d83a3f1b4de959cdcc010d40
Reviewed-on: https://chromium-review.googlesource.com/692021
Reviewed-by: Chris Pickel <sfiera@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505587}
[modify] https://crrev.com/5e2972e4ba9a79520fa7d75e491b7fdfb1009393/chrome/browser/resources/local_ntp/local_ntp.js
[modify] https://crrev.com/5e2972e4ba9a79520fa7d75e491b7fdfb1009393/chrome/browser/ui/search/ntp_user_data_logger.cc
[modify] https://crrev.com/5e2972e4ba9a79520fa7d75e491b7fdfb1009393/chrome/browser/ui/search/ntp_user_data_logger.h
[modify] https://crrev.com/5e2972e4ba9a79520fa7d75e491b7fdfb1009393/chrome/common/search/ntp_logging_events.h
[modify] https://crrev.com/5e2972e4ba9a79520fa7d75e491b7fdfb1009393/tools/metrics/histograms/histograms.xml

Comment 5 by treib@chromium.org, Oct 2 2017

Status: Fixed (was: Started)

Comment 6 by treib@chromium.org, Oct 11 2017

Cc: treib@chromium.org
 Issue 768730  has been merged into this issue.

Sign in to add a comment