Bookmarks "edit" screen is not respecting iPhone X area |
|||
Issue descriptioniPhone X only. What steps will reproduce the problem? (1) Open bookmarks (2) Long press on an element and choose edit What is the expected result? The edit screen should respect the safe area: the elements and the bottom toolbar are displayed outside the safe area. What happens instead? They should respect the safe area. The collection use MDC components, so fixing this is tied to fixes in MDC. However this bug is not merged into the other MDC bugs as this collection uses a table view style. So it is probably necessary to change its contentInsetAdjustmentBehavior to UIScrollViewContentInsetAdjustmentAutomatic and let the cell resize themselves.
,
Oct 19 2017
Hey gambard@ are you working on this issue?
,
Oct 20 2017
,
Oct 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/adad617c371d7b6b1b6b20c03781ff8b2eb50e15 commit adad617c371d7b6b1b6b20c03781ff8b2eb50e15 Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Oct 27 06:58:41 2017 Fix Bookmarks edit screen's toolbar for iPhone X The bottom toolbar of the edit screens of Bookmarks was not respecting the safe area. This CL fixes it by removing the inheritance on MDCButtonBar. Bug: 770158 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I36fd1a09c74296ecfea024401cb0757c2b634537 Reviewed-on: https://chromium-review.googlesource.com/738380 Reviewed-by: Marti Wong <martiw@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#512109} [modify] https://crrev.com/adad617c371d7b6b1b6b20c03781ff8b2eb50e15/ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.mm [modify] https://crrev.com/adad617c371d7b6b1b6b20c03781ff8b2eb50e15/ios/chrome/browser/ui/bookmarks/bookmark_elevated_toolbar.h [modify] https://crrev.com/adad617c371d7b6b1b6b20c03781ff8b2eb50e15/ios/chrome/browser/ui/bookmarks/bookmark_elevated_toolbar.mm [modify] https://crrev.com/adad617c371d7b6b1b6b20c03781ff8b2eb50e15/ios/chrome/browser/ui/bookmarks/bookmark_folder_editor_view_controller.mm
,
Oct 27 2017
,
Oct 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e741a88540395adcb84ed8ea8f4bc2afe09fd8c5 commit e741a88540395adcb84ed8ea8f4bc2afe09fd8c5 Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Oct 27 10:10:58 2017 Fix Bookmarks' edit screen The string to delete a bookmark from the edit screen was incorrectly changed from "delete" to "delete folder" in https://chromium-review.googlesource.com/c/chromium/src/+/738380 This CL fixes it. Bug: 770158 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icd9ba8fcf0396e7ca991869b39d06989d2e5236a Reviewed-on: https://chromium-review.googlesource.com/741240 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#512139} [modify] https://crrev.com/e741a88540395adcb84ed8ea8f4bc2afe09fd8c5/ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.mm
,
Oct 31 2017
Verified on M64.0.3254.0 canary, Device: iPhoneX Simulator Edit Bookmarks screen respects the Safearea. Verified with Regular bookmarks as well as New Gen Bookmarks UI. |
|||
►
Sign in to add a comment |
|||
Comment 1 Deleted