Issue metadata
Sign in to add a comment
|
Regression : Spacing issue is observed between bullet tips on sad tab.
Reported by
avsha...@etouch.net,
Sep 29 2017
|
||||||||||||||||||||||
Issue descriptionChrome version : 63.0.3227.0 (Official Build) fae86d4eec4236e1a02db18228bd435402cc1020-refs/heads/master@{#505231} 32/64 bit OS : Windows(7,8,10), Linux(14.04 LTS) What steps will reproduce the problem? 1. Launch chrome, open two NTPs and hit 'Shift + Esc' to open task manager. 2. Kill both the tabs from task manager and observe the bullet tips given on killed NTP. Actual Result : Spacing issue is observed between bullet tips on sad tab. Expected Result : Proper space should be seen between bullet points on sad tab. This is a regression issue broken in ‘M-63’ and using the per-revision bisect providing the bisect results, Good build : 63.0.3226.0 (Revision : 504842) Bad build : 63.0.3227.0 (Revision : 505231) You are probably looking for a change made after 505092 (known good), but no later than 505094 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/f3bd7c65886dedfdce09ec6af5d0f95907e89b1f..e0660c489e204cdb818676b2f7d45e4f3f0490b0 Suspect : https://chromium.googlesource.com/chromium/src/+/e0660c489e204cdb818676b2f7d45e4f3f0490b0 @ellyjones : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Note : Issue is not seen on Mac(10.12.6) OS
,
Oct 2 2017
This was a deliberate change as part of the linked CL. I'm not convinced that the new spacing is any more or less good than the old one was. wfh@, you seem to have touched this page a bunch - do you have an opinion either way here? If you want the old spacing back I can restore it at the price of complicating the sad tab page's implementation a bit. -> wfh@ for commentary - if you don't like the new spacing please reassign it to me and I'll fix it :)
,
Oct 9 2017
wfh@, Friendly ping to get an update on this issue as per comment#2 as it is marked as a stable blocker. Thanks..!!
,
Oct 9 2017
I followed the express wishes of the UI team when implementing this. Adding the relevant people. I'm pretty sure this isn't a release blocker.
,
Oct 25 2017
The spacing looks fine to me. Closing as WAI but Shimi - please feel free to chime in if you disagree. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ranjitkan@chromium.org
, Sep 29 2017