interactive_ui_tests failing on chromium.chromiumos/Linux ChromiumOS Tests (1) |
||||||||
Issue descriptioninteractive_ui_tests failing on chromium.chromiumos/Linux ChromiumOS Tests (1) Builders failed on: - Linux ChromiumOS Tests (1): Starting in https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/45183, `AppListTest.PressAppListButtonToShowAndDismiss` has been failing with the following: ``` [ RUN ] AppListTest.PressAppListButtonToShowAndDismiss [19942:19942:0929/010521.249395:WARNING:chrome_browser_main_chromeos.cc(620)] Running as stub user with profile dir: test-user [19942:19942:0929/010521.339395:ERROR:input_method_manager_impl.cc(1028)] IMEEngine for "fgoepimhcoialccpbmpnnblemnepkkao" is not registered [19942:19957:0929/010521.349756:WARNING:freezer_cgroup_process_manager.cc(62)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes. [19942:19942:0929/010521.439276:ERROR:touch_devices_controller.cc(22)] Failed to set touchpad enabled state. ../../chrome/browser/ui/ash/app_list/app_list_interactive_uitest.cc:43: Failure Value of: shell->app_list()->GetTargetVisibility() Actual: false Expected: true ../../chrome/browser/ui/ash/app_list/app_list_interactive_uitest.cc:44: Failure Expected: 1u Which is: 1 To be equal to: app_list_container->children().size() Which is: 0 ../../chrome/browser/ui/ash/app_list/app_list_interactive_uitest.cc:45: Failure Value of: app_list_button->is_showing_app_list() Actual: false Expected: true ../../chrome/browser/ui/ash/app_list/app_list_interactive_uitest.cc:51: Failure Expected: 1u Which is: 1 To be equal to: app_list_container->children().size() Which is: 0 [19942:19970:0929/010521.440817:ERROR:service_manager.cc(156)] Connection InterfaceProviderSpec prevented service: content_renderer from binding interface: ukm::mojom::UkmRecorderInterface exposed by: content_browser [19942:19942:0929/010521.462140:INFO:chrome_cryptauth_service.cc(230)] Refresh token not yet available; waiting before starting CryptAuth managers. [ FAILED ] AppListTest.PressAppListButtonToShowAndDismiss, where TypeParam = and GetParam() = (288 ms) ``` Suspecting https://chromium-review.googlesource.com/c/chromium/src/+/682340.
,
Sep 29 2017
Looks like the bot recovered in https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/45188 which included this revert.
,
Sep 29 2017
Hmm, I'm not sure why the linux_chromium_chromeos_rel_ng trybot passed the same test... https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/518664 https://chromium-swarm.appspot.com/task?id=38e538ce94d45a10&refresh=10&show_raw=1 It also passes for me locally... I'll try rebuilding matching the waterfall bot's config. It could be a flakiness issue... I found some other failures on the same bot while my CL was active. browser_tests: ShelfAppBrowserTest.ShelfButtonContextMenu https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/45183 unit_tests: ActiveTabTest.DelegateIsSet https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/45187 Regardless, thank you, I'll try to avoid these failures when relanding.
,
Oct 2 2017
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=interactive_ui_tests&tests=AppListTest.PressAppListButtonToShowAndDismiss shows that you weren't entirely successful in the reland. I'll disable the test; it'd be great if you could take a look.
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/214bef70f3077fe85ec085d3b75409f65ebea902 commit 214bef70f3077fe85ec085d3b75409f65ebea902 Author: Mike West <mkwst@chromium.org> Date: Mon Oct 02 15:08:40 2017 Disabling `AppListTest.PressAppListButtonToShowAndDismiss` It consistently times out on ChromeOS, starting in https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/45263 Bug: 770138 Change-Id: I9cdb8a0b7b8e326715460fc81777d8dc06b28eb4 TBR: msw@chromium.org Reviewed-on: https://chromium-review.googlesource.com/695329 Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#505615} [modify] https://crrev.com/214bef70f3077fe85ec085d3b75409f65ebea902/chrome/browser/ui/ash/app_list/app_list_interactive_uitest.cc
,
Oct 2 2017
Darn, it passed 100 times in a row on my local machine! I'm also seeing flaky failures of two other tests: WindowSizerContextMenuTest.OpenBrowserUsingContextMenuOnOtherDisplay WindowSizerTest.OpenBrowserUsingShelfOnOtherDisplay eg. https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20(1)/builds/45278 I'll disable those now and work on fixing and re-enabling all three asap, thanks!
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02bdcd39580a28e6b48cb4d8f53909425e68eece commit 02bdcd39580a28e6b48cb4d8f53909425e68eece Author: Mike Wasserman <msw@chromium.org> Date: Mon Oct 02 16:42:06 2017 Disable flaky WindowSizer interactive_ui_tests I'll attempt to fix and reenable these tests asap. Bug: 770138 Change-Id: Ica2c5f67b3fe5834a4b1afc9ed034231e30fd658 Reviewed-on: https://chromium-review.googlesource.com/695663 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#505644} [modify] https://crrev.com/02bdcd39580a28e6b48cb4d8f53909425e68eece/chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc
,
Oct 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f8dcf3a5016b8e02ab4c2ae81d298d0548d1b64 commit 3f8dcf3a5016b8e02ab4c2ae81d298d0548d1b64 Author: Mike Wasserman <msw@chromium.org> Date: Tue Oct 03 22:59:06 2017 Ash: Fix and renable AppListTest.PressAppListButtonToShowAndDismiss The test was timing out; I'm not entirely sure why... Add and use AppList::FlushForTesting instead of AppListWaiter. Bug: 770138 Change-Id: Id1ac7ade5504d3e3140c767eb0385f0dcab40d28 Reviewed-on: https://chromium-review.googlesource.com/698291 Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#506219} [modify] https://crrev.com/3f8dcf3a5016b8e02ab4c2ae81d298d0548d1b64/chrome/browser/ui/ash/app_list/app_list_interactive_uitest.cc [modify] https://crrev.com/3f8dcf3a5016b8e02ab4c2ae81d298d0548d1b64/ui/app_list/presenter/app_list.cc [modify] https://crrev.com/3f8dcf3a5016b8e02ab4c2ae81d298d0548d1b64/ui/app_list/presenter/app_list.h
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7594bada9dd71d6328b9043766ce37273845ba61 commit 7594bada9dd71d6328b9043766ce37273845ba61 Author: Michael Wasserman <msw@chromium.org> Date: Wed Oct 04 01:45:28 2017 Revert "Ash: Fix and renable AppListTest.PressAppListButtonToShowAndDismiss" This reverts commit 3f8dcf3a5016b8e02ab4c2ae81d298d0548d1b64. Reason for revert: Failing pretty consistently: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/45347 [ RUN ] AppListTest.PressAppListButtonToShowAndDismiss [27213:27213:1003/171033.748988:WARNING:chrome_browser_main_chromeos.cc(620)] Running as stub user with profile dir: test-user [27213:27213:1003/171034.000522:ERROR:input_method_manager_impl.cc(1028)] IMEEngine for "fgoepimhcoialccpbmpnnblemnepkkao" is not registered [27213:27229:1003/171034.007385:WARNING:freezer_cgroup_process_manager.cc(62)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes. [27213:27213:1003/171034.093905:ERROR:touch_devices_controller.cc(22)] Failed to set touchpad enabled state. ../../chrome/browser/ui/ash/app_list/app_list_interactive_uitest.cc:49: Failure Value of: presenter->GetTargetVisibility() Actual: false Expected: true ../../chrome/browser/ui/ash/app_list/app_list_interactive_uitest.cc:50: Failure Value of: shell->app_list()->GetTargetVisibility() Actual: false Expected: true ../../chrome/browser/ui/ash/app_list/app_list_interactive_uitest.cc:51: Failure Expected: 1u Which is: 1 To be equal to: app_list_container->children().size() Which is: 0 ../../chrome/browser/ui/ash/app_list/app_list_interactive_uitest.cc:52: Failure Value of: app_list_button->is_showing_app_list() Actual: false Expected: true ../../chrome/browser/ui/ash/app_list/app_list_interactive_uitest.cc:61: Failure Expected: 1u Which is: 1 To be equal to: app_list_container->children().size() Which is: 0 [27213:27213:1003/171034.134144:INFO:chrome_cryptauth_service.cc(230)] Refresh token not yet available; waiting before starting CryptAuth managers. [ FAILED ] AppListTest.PressAppListButtonToShowAndDismiss, where TypeParam = and GetParam() = (471 ms) Original change's description: > Ash: Fix and renable AppListTest.PressAppListButtonToShowAndDismiss > > The test was timing out; I'm not entirely sure why... > Add and use AppList::FlushForTesting instead of AppListWaiter. > > Bug: 770138 > Change-Id: Id1ac7ade5504d3e3140c767eb0385f0dcab40d28 > Reviewed-on: https://chromium-review.googlesource.com/698291 > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Michael Wasserman <msw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506219} TBR=jamescook@chromium.org,xiyuan@chromium.org,msw@chromium.org Change-Id: I8bcd0b3bd7fcdbf15263a0334608326866cda19e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 770138 Reviewed-on: https://chromium-review.googlesource.com/699637 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#506271} [modify] https://crrev.com/7594bada9dd71d6328b9043766ce37273845ba61/chrome/browser/ui/ash/app_list/app_list_interactive_uitest.cc [modify] https://crrev.com/7594bada9dd71d6328b9043766ce37273845ba61/ui/app_list/presenter/app_list.cc [modify] https://crrev.com/7594bada9dd71d6328b9043766ce37273845ba61/ui/app_list/presenter/app_list.h
,
Oct 9 2017
,
Oct 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b81f263e6f4535b7b311d180976078d9274dbc89 commit b81f263e6f4535b7b311d180976078d9274dbc89 Author: Mike Wasserman <msw@chromium.org> Date: Mon Oct 09 23:20:13 2017 Ash: Fix and renable AppListTest.PressAppListButtonToShowAndDismiss V2 Use FlushForTesting instead of AppListWaiter to avoid timeouts. Use RunMessageLoopUntilAnimationsDone to avoid animation flakes. Bug: 770138 Change-Id: Id297da23f995d4fdb13a2822b884beabadd3e19b Reviewed-on: https://chromium-review.googlesource.com/706640 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#507528} [modify] https://crrev.com/b81f263e6f4535b7b311d180976078d9274dbc89/chrome/browser/ui/ash/app_list/app_list_interactive_uitest.cc [modify] https://crrev.com/b81f263e6f4535b7b311d180976078d9274dbc89/chrome/browser/ui/ash/app_list/app_list_presenter_service.cc [modify] https://crrev.com/b81f263e6f4535b7b311d180976078d9274dbc89/chrome/browser/ui/ash/app_list/app_list_presenter_service.h [modify] https://crrev.com/b81f263e6f4535b7b311d180976078d9274dbc89/chrome/browser/ui/ash/app_list/app_list_service_ash.h [modify] https://crrev.com/b81f263e6f4535b7b311d180976078d9274dbc89/ui/app_list/presenter/app_list.cc [modify] https://crrev.com/b81f263e6f4535b7b311d180976078d9274dbc89/ui/app_list/presenter/app_list.h
,
Oct 10 2017
Huzzah! It looks like that AppListTest is finally passing reliably :) Time to work on those two WindowSizer tests now.
,
Oct 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f1bd685ce1e8848a1eecb1dad292d47c6e82e1d commit 0f1bd685ce1e8848a1eecb1dad292d47c6e82e1d Author: Mike Wasserman <msw@chromium.org> Date: Wed Oct 11 18:20:58 2017 ash: Fix and re-enable WindowSizerTest fixtures Rewrite tests to hopefully avoid flaky failures: -Ensure shelf init animations produce clickable buttons. -Use new ShelfController/ChromeLauncherController FlushForTesting. -Use EventGenerator for context menu testing too. Other test cleanup/refactor; export ShelfController for testing. Bug: 770138 Change-Id: I21f26102032a3e0088220073c850c0ae2e4250c8 Reviewed-on: https://chromium-review.googlesource.com/710798 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#508040} [modify] https://crrev.com/0f1bd685ce1e8848a1eecb1dad292d47c6e82e1d/ash/shelf/shelf_controller.cc [modify] https://crrev.com/0f1bd685ce1e8848a1eecb1dad292d47c6e82e1d/ash/shelf/shelf_controller.h [modify] https://crrev.com/0f1bd685ce1e8848a1eecb1dad292d47c6e82e1d/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc [modify] https://crrev.com/0f1bd685ce1e8848a1eecb1dad292d47c6e82e1d/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h [modify] https://crrev.com/0f1bd685ce1e8848a1eecb1dad292d47c6e82e1d/chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc
,
Oct 11 2017
Nice, those WindowSizer tests passed at least one build on the bot: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/45642 I'll check back to make sure it isn't flaking in a few hours, but I'm calling this fixed.
,
Jan 22 2018
,
Jan 23 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Sep 29 2017