New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 770102 link

Starred by 2 users
Status: Fixed
Owner:
█ mkwst@chromium.org
Buried. Ping if important.
Closed: Sep 2017
Cc:
█ roc...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

compare_build_artifacts failing on chromium.linux/Deterministic Linux

Project Member Reported by mkwst@chromium.org, Sep 29 2017 
compare_build_artifacts failing on chromium.linux/Deterministic Linux

Builders failed on: 
- Deterministic Linux: 
  https://build.chromium.org/p/chromium.linux/builders/Deterministic%20Linux

---

It looks like this started failing on https://build.chromium.org/p/chromium.linux/builders/Deterministic%20Linux/builds/7150. "Mojo: Scramble message IDs at build time" looks like a good suspect: https://chromium-review.googlesource.com/c/chromium/src/+/685457; will revert.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f50bf7f89798f5f6742a1d3733f3e43c52c2335

commit 1f50bf7f89798f5f6742a1d3733f3e43c52c2335
Author: Mike West <mkwst@chromium.org>
Date: Fri Sep 29 17:44:03 2017

Revert "Mojo: Scramble message IDs at build time"

This patch reverts commit 496fe9b7b6233b74af73c71c87404bc3f27323d4
(https://chromium-review.googlesource.com/c/chromium/src/+/685457)
and commit 902a2b75653a7026820f273838181d777d36108d
(https://chromium-review.googlesource.com/c/chromium/src/+/688751).

I suspect that the former broke the deterministic builder
(https://build.chromium.org/p/chromium.linux/builders/Deterministic%20Linux/builds/7150)
and the latter prevented reverting the former.

TBR=dcheng@chromium.org,rockot@chromium.org,lhchavez@chromium.org,yzshen@chromium.org

Bug: 673417,  770102 
Change-Id: Ic463ed5d56f5535fc4697dd4aa9a219338350214
Reviewed-on: https://chromium-review.googlesource.com/691795
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505413}
[modify] https://crrev.com/1f50bf7f89798f5f6742a1d3733f3e43c52c2335/BUILD.gn
[modify] https://crrev.com/1f50bf7f89798f5f6742a1d3733f3e43c52c2335/chrome/tools/build/chromeos/FILES.cfg
[modify] https://crrev.com/1f50bf7f89798f5f6742a1d3733f3e43c52c2335/chrome/tools/build/linux/FILES.cfg
[modify] https://crrev.com/1f50bf7f89798f5f6742a1d3733f3e43c52c2335/chrome/tools/build/mac/FILES.cfg
[modify] https://crrev.com/1f50bf7f89798f5f6742a1d3733f3e43c52c2335/chrome/tools/build/win/FILES.cfg
[modify] https://crrev.com/1f50bf7f89798f5f6742a1d3733f3e43c52c2335/components/arc/BUILD.gn
[modify] https://crrev.com/1f50bf7f89798f5f6742a1d3733f3e43c52c2335/device/usb/public/interfaces/BUILD.gn
[modify] https://crrev.com/1f50bf7f89798f5f6742a1d3733f3e43c52c2335/mojo/public/interfaces/bindings/tests/BUILD.gn
[modify] https://crrev.com/1f50bf7f89798f5f6742a1d3733f3e43c52c2335/mojo/public/tools/bindings/BUILD.gn
[delete] https://crrev.com/7013e5f9d7a560f4dae0ade5a966292dd833d3e3/mojo/public/tools/bindings/generate_message_id_salt.py
[modify] https://crrev.com/1f50bf7f89798f5f6742a1d3733f3e43c52c2335/mojo/public/tools/bindings/mojom.gni
[modify] https://crrev.com/1f50bf7f89798f5f6742a1d3733f3e43c52c2335/mojo/public/tools/bindings/mojom_bindings_generator.py

Comment 2 by roc...@chromium.org, Sep 29 2017

Status: Fixed (was: Available)
Thanks for the revert!
►

Sign in to add a comment