New issue
Advanced search Search tips

Issue 770051 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 753806



Sign in to add a comment

[Password Manager] Save prompt: if username is empty, then the username text field should grab the focus

Project Member Reported by kolos@chromium.org, Sep 29 2017

Issue description

If username is empty, then the username text field in a save prompt should grab the focus. It is expected that a user wants to enter username value.
 

Comment 1 by kolos@chromium.org, Oct 16 2017

Cc: kolos@chromium.org battre@chromium.org
 Issue 774954  has been merged into this issue.

Comment 2 by kolos@chromium.org, Oct 16 2017

Owner: kolos@chromium.org
Status: Started (was: Available)
starting implementation for Win/Linux/CrOS
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92fe72eb70004bcd00ac5747268cb35024e4c4d9

commit 92fe72eb70004bcd00ac5747268cb35024e4c4d9
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Mon Oct 16 13:18:09 2017

[Password Manager] Username field should grab focus if the username value is empty

Bug:  770051 ,   774954 
Change-Id: I3adbe71766f39aba45f359c5c966daf57f2a2acc
Reviewed-on: https://chromium-review.googlesource.com/720928
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509029}
[modify] https://crrev.com/92fe72eb70004bcd00ac5747268cb35024e4c4d9/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

Comment 4 by kolos@chromium.org, Oct 16 2017

Owner: vasi...@chromium.org
assigning to Vasilii for Mac.
Labels: Needs-Feedback
kolos@ Could you please help us with repro steps to verify this fix from TE-end

Thank You...

Comment 6 by kolos@chromium.org, Oct 17 2017

1. visit facebook.com (username field shouldn't be autofilled; if it was, do clear the field)
2. type password into the password field.
3. open a bubble with omnibox key icon 

Expected:
username field in a prompt is empty
focus should be in the username field.


Comment 7 by kolos@chromium.org, Oct 17 2017

Cc: maxwalker@chromium.org
Max: do you want me to merge it to M-62? The branch point was October 12th. 
I think this isn't critical so it seems ok to get it in M63.
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6afb799f9848657d1955e9bfac1c853e1883df3

commit b6afb799f9848657d1955e9bfac1c853e1883df3
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Mon Oct 23 10:23:28 2017

Make the editable username a key view in the password bubble if it's empty (Mac).

Bug:  770051 
Change-Id: Iad8756cbd7266bbc66711b84ebe3aad9775a84f6
Reviewed-on: https://chromium-review.googlesource.com/730714
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510750}
[modify] https://crrev.com/b6afb799f9848657d1955e9bfac1c853e1883df3/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm

Status: Fixed (was: Started)
Labels: TE-Verified-64.0.3248.0 TE-Verified-M64
Verified the fix on Mac 10.12.6, Win-10 and Ubuntu 14.04 using latest chrome version #64.0.3248.0 as per the comment #6.
Attaching screen cast and screenshot for reference.
Observed that in the save prompt if username is empty, then the username text field grabbed the focus as expected.
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!
770051.mp4
702 KB View Download
770051.png
732 KB View Download

Sign in to add a comment