cleanup AppBannerManagerAndroid::CanHandleNonWebApp |
|||
Issue descriptionIt's currently unclear how many time (if any) AppBannerManagerAndroid::CanHandleNonWebApp() calls ReportStatus(). Rather than calling ReportStatus(), CanHandleNonWebApp() should return an InstallableStatusCode so that PerformInstallableCheck() can pass it to StopWithCode().
,
Sep 29 2017
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90de15fd24c922bb907b308a53dc8ec4f094e0cc commit 90de15fd24c922bb907b308a53dc8ec4f094e0cc Author: Dominick Ng <dominickn@chromium.org> Date: Wed Oct 04 04:34:32 2017 Introduce a WAITING_FOR_NATIVE_DATA state to AppBannerManager. This CL introduces a new internal AppBannerManager state that is used when the Android subclass is waiting for native app data from Java. This allows AppBannerManagerAndroid::CanHandleNonWebApp() to be refactored so that it returns an InstallableStatusCode and hence can use AppBannerManager::StopWithCode(). It also allows metrics to record when the banner pipeline was stopped while we were waiting to query native app data. BUG= 770050 Change-Id: I7c0bb20081c97557343e3c4b09740df29740aded Reviewed-on: https://chromium-review.googlesource.com/696884 Reviewed-by: Matt Giuca <mgiuca@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#506299} [modify] https://crrev.com/90de15fd24c922bb907b308a53dc8ec4f094e0cc/chrome/browser/android/banners/app_banner_manager_android.cc [modify] https://crrev.com/90de15fd24c922bb907b308a53dc8ec4f094e0cc/chrome/browser/android/banners/app_banner_manager_android.h [modify] https://crrev.com/90de15fd24c922bb907b308a53dc8ec4f094e0cc/chrome/browser/banners/app_banner_manager.cc [modify] https://crrev.com/90de15fd24c922bb907b308a53dc8ec4f094e0cc/chrome/browser/banners/app_banner_manager.h [modify] https://crrev.com/90de15fd24c922bb907b308a53dc8ec4f094e0cc/chrome/browser/installable/installable_logging.cc [modify] https://crrev.com/90de15fd24c922bb907b308a53dc8ec4f094e0cc/chrome/browser/installable/installable_logging.h [modify] https://crrev.com/90de15fd24c922bb907b308a53dc8ec4f094e0cc/tools/metrics/histograms/enums.xml
,
Oct 9 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by mcgreevy@chromium.org
, Sep 29 2017