New issue
Advanced search Search tips

Issue 770049 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 753806



Sign in to add a comment

[Password Manager] Eye icon in save prompt shouldn't look disabled

Project Member Reported by kolos@chromium.org, Sep 29 2017

Issue description

On hover, the eye icon in save prompt becomes black. Otherwise, it is gray which looks disabled. Let the eye icon look the same.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0df1998e9c61734616c8b07ff4d44feccd45f9fb

commit 0df1998e9c61734616c8b07ff4d44feccd45f9fb
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Fri Oct 06 06:43:27 2017

[Password Manager] Don't change eye icon on hover

On hover, the eye icon in save prompt becomes black. Otherwise, it is gray which looks disabled. Let the eye icon look the same.

Bug: 753806, 770049 
Change-Id: I4de84d6b8c9b7d8e9036688922fb18b2bff0727b
Reviewed-on: https://chromium-review.googlesource.com/690479
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506998}
[rename] https://crrev.com/0df1998e9c61734616c8b07ff4d44feccd45f9fb/chrome/app/theme/default_100_percent/cros/hide_password.png
[rename] https://crrev.com/0df1998e9c61734616c8b07ff4d44feccd45f9fb/chrome/app/theme/default_100_percent/cros/show_password.png
[rename] https://crrev.com/0df1998e9c61734616c8b07ff4d44feccd45f9fb/chrome/app/theme/default_200_percent/cros/hide_password.png
[rename] https://crrev.com/0df1998e9c61734616c8b07ff4d44feccd45f9fb/chrome/app/theme/default_200_percent/cros/show_password.png
[modify] https://crrev.com/0df1998e9c61734616c8b07ff4d44feccd45f9fb/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/0df1998e9c61734616c8b07ff4d44feccd45f9fb/chrome/browser/ui/cocoa/passwords/passwords_list_view_controller.mm
[modify] https://crrev.com/0df1998e9c61734616c8b07ff4d44feccd45f9fb/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

Comment 2 by kolos@chromium.org, Oct 6 2017

Status: Fixed (was: Started)

Sign in to add a comment