New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 770019 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

depot_tools PRESUBMIT is broken.

Project Member Reported by d...@chromium.org, Sep 29 2017

Issue description

The "depot_tools" "Depot Tools Presubmit" builder is broken. This is a whitespace change that fails:

https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/691319

Don't have time to track down why. P1 b/c this is blocking "depot_tools" changes from being CQ'd.
 
Owner: aga...@chromium.org
Status: Assigned (was: Untriaged)
I believe it's because depot_tools presubmit is fetching infra/infra.git and tehn starts local rietveld server. Since it was turned read-only, end-2-end test fails.
OH OH WE CAN JUST DELETE THESE TESTS NOW!!!!

Comment 4 by d...@chromium.org, Sep 29 2017

pleasepleasepleasepleaseplease

Comment 5 by aga...@chromium.org, Sep 29 2017

Will do, first thing tomorrow!
Not sure if it's related but I'm also seeing failures of this form:

test_200 (__main__.OAuthRpcServerTest) ... ERROR:root:No support for OpenSSL has been found, OAuth2 support requires it.
ERROR:root:Installing pyopenssl will probably solve this issue.
RuntimeError: No OpenSSL support

https://luci-logdog.appspot.com/v/?s=infra%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8967100806430922704%2F%2B%2Fsteps%2Fpresubmit%2F0%2Fstdout

Comment 8 by aga...@chromium.org, Sep 29 2017

I think the first set of failures started when I landed the changes (because the .sh tests pull in a local version of rietveld) and the second set of Oauth failures started when I deployed the change (because rietveld_test.py talks to prod, apparently). Both should be fixed by the change above.
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/0a1f3f6ab34fd2d14cab4dd7fdb86c9a5b77ffe4

commit 0a1f3f6ab34fd2d14cab4dd7fdb86c9a5b77ffe4
Author: Aaron Gable <agable@chromium.org>
Date: Fri Sep 29 18:04:04 2017

Remove defunct Rietveld end-to-end tests

R=tandrii@chromium.org

Bug:  770019 
Change-Id: I55d74d67281bd3f79cfd5ba9f57eea082359573e
Reviewed-on: https://chromium-review.googlesource.com/693034
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[delete] https://crrev.com/35c5b9ad1beb2550831fa1d39f5f12e354edd501/tests/abandon.sh
[delete] https://crrev.com/35c5b9ad1beb2550831fa1d39f5f12e354edd501/tests/patch.sh
[modify] https://crrev.com/0a1f3f6ab34fd2d14cab4dd7fdb86c9a5b77ffe4/PRESUBMIT.py
[delete] https://crrev.com/35c5b9ad1beb2550831fa1d39f5f12e354edd501/tests/upload-local-tracking-branch.sh
[delete] https://crrev.com/35c5b9ad1beb2550831fa1d39f5f12e354edd501/testing_support/local_rietveld.py
[delete] https://crrev.com/35c5b9ad1beb2550831fa1d39f5f12e354edd501/tests/basic.sh
[delete] https://crrev.com/35c5b9ad1beb2550831fa1d39f5f12e354edd501/tests/test-lib.sh
[delete] https://crrev.com/35c5b9ad1beb2550831fa1d39f5f12e354edd501/tests/post-land-hook-test.sh
[delete] https://crrev.com/35c5b9ad1beb2550831fa1d39f5f12e354edd501/tests/rietveld_test.py
[modify] https://crrev.com/0a1f3f6ab34fd2d14cab4dd7fdb86c9a5b77ffe4/fetch_configs/infra.py
[delete] https://crrev.com/35c5b9ad1beb2550831fa1d39f5f12e354edd501/tests/upload-stale.sh
[delete] https://crrev.com/35c5b9ad1beb2550831fa1d39f5f12e354edd501/tests/owners.sh
[delete] https://crrev.com/35c5b9ad1beb2550831fa1d39f5f12e354edd501/tests/push-from-logs.sh
[delete] https://crrev.com/35c5b9ad1beb2550831fa1d39f5f12e354edd501/tests/save-description-on-failure.sh
[delete] https://crrev.com/35c5b9ad1beb2550831fa1d39f5f12e354edd501/tests/submit-from-new-dir.sh
[delete] https://crrev.com/35c5b9ad1beb2550831fa1d39f5f12e354edd501/tests/hooks.sh

Status: Fixed (was: Started)

Comment 11 by d...@chromium.org, Sep 30 2017

Nice!

Sign in to add a comment