Reprompt on dismissal of install prompt. |
|
Issue descriptionWe wish to allow the install prompt to be triggered multiple times, so the beforeinstallprompt should be re-triggered if an install prompt is dismissed.
,
Sep 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7cd54a4dfb888f117cf652efbff2c71ff4269dd3 commit 7cd54a4dfb888f117cf652efbff2c71ff4269dd3 Author: Michael McGreevy <mcgreevy@chromium.org> Date: Fri Sep 29 09:03:10 2017 Split AppBannerManager::Stop() into two methods. This means that ReportStatus is only called in one place (apart from AppBannerManagerDesktop::ShowBannerUi), making it easier to verify that it is called the appropriate number of times. It also removes the need for hacks such as pre-updating the state to COMPLETE in AppBannerManager::DisplayAppBanner. Bug: 770016 Change-Id: Iedf93b7a3c6c211b2188032259906bd49bcd4555 Reviewed-on: https://chromium-review.googlesource.com/691494 Commit-Queue: Michael McGreevy <mcgreevy@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#505334} [modify] https://crrev.com/7cd54a4dfb888f117cf652efbff2c71ff4269dd3/chrome/browser/android/banners/app_banner_manager_android.cc [modify] https://crrev.com/7cd54a4dfb888f117cf652efbff2c71ff4269dd3/chrome/browser/banners/app_banner_manager.cc [modify] https://crrev.com/7cd54a4dfb888f117cf652efbff2c71ff4269dd3/chrome/browser/banners/app_banner_manager.h [modify] https://crrev.com/7cd54a4dfb888f117cf652efbff2c71ff4269dd3/chrome/browser/banners/app_banner_manager_browsertest.cc
,
Oct 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f477b994a01351395fa46c2265daefc06c9862d commit 3f477b994a01351395fa46c2265daefc06c9862d Author: Michael McGreevy <mcgreevy@chromium.org> Date: Wed Oct 18 03:37:19 2017 Re-trigger beforeinstallprompt when install prompt is dismissed. Bug: 770016 Change-Id: I3375293694ca5e124ae3a37224a150f495d76179 Reviewed-on: https://chromium-review.googlesource.com/718059 Commit-Queue: Michael McGreevy <mcgreevy@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#509678} [modify] https://crrev.com/3f477b994a01351395fa46c2265daefc06c9862d/chrome/browser/banners/app_banner_manager.cc [modify] https://crrev.com/3f477b994a01351395fa46c2265daefc06c9862d/chrome/browser/banners/app_banner_manager.h [modify] https://crrev.com/3f477b994a01351395fa46c2265daefc06c9862d/chrome/browser/banners/app_banner_manager_browsertest.cc [modify] https://crrev.com/3f477b994a01351395fa46c2265daefc06c9862d/chrome/browser/banners/app_banner_settings_helper.cc
,
Nov 9 2017
We are now retriggering when the app install banner is dismissed, but not when the app install dialog is dismissed. We should handle that case too.
,
Nov 29 2017
|
|
►
Sign in to add a comment |
|
Comment 1 by mcgreevy@chromium.org
, Sep 29 2017