New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 770014 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Sep 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

core system profile not fully filled out in UKM on ChromeOS

Project Member Reported by bmcquade@chromium.org, Sep 29 2017

Issue description

UKM fills out a minimal system profile using the MetricsLog::RecordCoreSystemProfile method.

However, some fields set in this method, such as hardware.hardware_class, are normally overridden in a platform-specific metrics provider on ChromeOS.

ChromeOSMetricsProvider::ProvideSystemProfileMetrics sets hardware.hardware_class using cros-specific logic, for example.

This cros-specific logic is not exercised when using UKM, which calls RecordCoreSystemProfile unconditionally on all platforms.

The end result is that hardware_class is unset on cros, and this confuses some of our code that determines which platform a given client uses, which expects hardware_class to be set for cros.

We should audit which SystemProfile fields can be set by platform-specific providers and make sure we exercise all platform-specific logic when filling out the system profile in UKM.
 

Comment 1 by rkaplow@google.com, Apr 10 2018

Owner: asvitk...@chromium.org
Status: Assigned (was: Untriaged)
Alexei, I think you covered much of this.

Are you interested in verifying other potential platform-specific issues?
Sounds good. I'll follow up on this when I have a chance. Probably after next week.
Status: WontFix (was: Assigned)
I haven't heard any requests for anything else beyond hw class for UKM. So I'm going to close this out. We can file new bugs if we hear specific requests from clients.

Sign in to add a comment