Files copied to Downloads folder doesn't appear in Recent root. |
||||||||||
Issue descriptionChrome Version: Chrome OS 9765.70.0, 61.0.3163.101 beta build Steps To Reproduce: 1. Files app>Download an image each to Downloads and Gdrive folder. 2. The downloaded ones appear in Recent root as well. 3. Now, copy/paste an image/any file to Downloads folder. Expected behavior: Files copied to Downloads folder must appear in Recent root. Actual behavior: Files that are copied to Downloads folder doesn't show up in Recent root. On the contrary, files copied to Gdrive does appear in Recent folder.
,
Sep 29 2017
Hi weifangsun, Even on closing the window and reopening Files app, I didn't see those files of Downloads folder under Recent root.
,
Sep 29 2017
nya@ - Could you please take a look this bug?
,
Oct 2 2017
I have several questions: - From which directory did you copy a file to Downloads folder? - What is the last modified timestamp of the file you copied?
,
Oct 2 2017
Hi nya, I tried copying existing file of USB/GDrive to Downloads folder. This file didn't appear in Recent root. The file that was copied had old date timestamp.
,
Oct 3 2017
Thanks for feedback. I believe it's WAI because last modified time of the copied files is preserved, and Recent root shows most recently modified files.
,
Oct 3 2017
But the same old file (i.e. of old date timestamp) copied from USB/Downloads to Gdrive causes the file to appear in Recent folder. As I have observed, when file is copied to Gdrive, its last modified time gets updated to current timestamp. So, similarly shouldn't the timestamp of file copied to Downloads folder change to current datetime?
,
Oct 3 2017
,
Oct 11 2017
Sorry for late reply. Yes, indeed this is inconsistent. To summarize, the problem is that: - When a file is copied from Downloads to Drive, last modified is NOT preserved. - This means that when an old file is copied from Downloads to Drive, it appears in Recent. - When a file is copied from Drive to Downloads, last modified is preserved. - This means that when an old file is copied from Drive to Downloads, it does NOT appear in Recent. I'll investigate why the timestamp handling is inconsistent by destination.
,
Oct 12 2017
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23c7a54d77b7efe746f355732df9d0fab64a069c commit 23c7a54d77b7efe746f355732df9d0fab64a069c Author: Shuhei Takahashi <nya@chromium.org> Date: Tue Nov 14 04:25:35 2017 Set correct file timestamp on streaming file copy. Today, on streaming file copy, the destination file is closed on the destruction of SnapshotCopyOrMoveImpl which happens after setting the timestamp of the file with TouchFile(). This works in an undesired way with some file systems which update timestamps on file close (including Drive): the timestamp set with TouchFile() is reverted immediately. This change updates SnapshotCopyOrMoveImpl to destruct StreamCopyHelper immediately after it is used so that the destination file is closed before TouchFile() is called. Bug: 770012 Test: Copying a file from Downloads to Drive retains its timestamp. Change-Id: I4a430a347e3d8d524c8b8d00bfe9479e22f7d5c9 Reviewed-on: https://chromium-review.googlesource.com/765748 Reviewed-by: Taiju Tsuiki <tzik@chromium.org> Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Shuhei Takahashi <nya@chromium.org> Cr-Commit-Position: refs/heads/master@{#516191} [modify] https://crrev.com/23c7a54d77b7efe746f355732df9d0fab64a069c/storage/browser/fileapi/copy_or_move_operation_delegate.cc
,
Nov 14 2017
,
Dec 12 2017
Copying a file from Downloads to Drive retains its timestamp. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by weifangsun@chromium.org
, Sep 29 2017