New issue
Advanced search Search tips

Issue 769994 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Replace ash::HighlighterControllerObserver with a mojo client

Project Member Reported by kaznacheev@chromium.org, Sep 28 2017

Issue description

This is required to make ArcVoiceInteractionFrameworkService mash-compatible.
 
Blocking: 761120
Blocking: -761120
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fa1eff47a519f8637f10ad65c0d81eef01597c0

commit 1fa1eff47a519f8637f10ad65c0d81eef01597c0
Author: Vladislav Kaznacheev <kaznacheev@google.com>
Date: Thu Oct 12 16:39:01 2017

Replace ash::HighlighterControllerObserver with a mojo client

This makes metalayer/highlighter features fully mash-compatible.

Bug:  769994 

Test: ash_unittests --gtest_filter=Palette*
Change-Id: I8344ffdd246357cc14866cf19dbfcc9644be00e5
Reviewed-on: https://chromium-review.googlesource.com/693346
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508366}
[modify] https://crrev.com/1fa1eff47a519f8637f10ad65c0d81eef01597c0/ash/BUILD.gn
[modify] https://crrev.com/1fa1eff47a519f8637f10ad65c0d81eef01597c0/ash/fast_ink/fast_ink_pointer_controller.h
[modify] https://crrev.com/1fa1eff47a519f8637f10ad65c0d81eef01597c0/ash/fast_ink/fast_ink_view.cc
[modify] https://crrev.com/1fa1eff47a519f8637f10ad65c0d81eef01597c0/ash/highlighter/highlighter_controller.cc
[modify] https://crrev.com/1fa1eff47a519f8637f10ad65c0d81eef01597c0/ash/highlighter/highlighter_controller.h
[modify] https://crrev.com/1fa1eff47a519f8637f10ad65c0d81eef01597c0/ash/highlighter/highlighter_controller_test_api.cc
[modify] https://crrev.com/1fa1eff47a519f8637f10ad65c0d81eef01597c0/ash/highlighter/highlighter_controller_test_api.h
[modify] https://crrev.com/1fa1eff47a519f8637f10ad65c0d81eef01597c0/ash/highlighter/highlighter_controller_unittest.cc
[delete] https://crrev.com/b0628ee9855d7cee1b0dd2634490aefbb0929a64/ash/highlighter/highlighter_selection_observer.h
[modify] https://crrev.com/1fa1eff47a519f8637f10ad65c0d81eef01597c0/ash/mojo_interface_factory.cc
[modify] https://crrev.com/1fa1eff47a519f8637f10ad65c0d81eef01597c0/ash/mus/manifest.json
[modify] https://crrev.com/1fa1eff47a519f8637f10ad65c0d81eef01597c0/ash/mus/standalone/manifest.json
[modify] https://crrev.com/1fa1eff47a519f8637f10ad65c0d81eef01597c0/ash/public/interfaces/BUILD.gn
[add] https://crrev.com/1fa1eff47a519f8637f10ad65c0d81eef01597c0/ash/public/interfaces/highlighter_controller.mojom
[modify] https://crrev.com/1fa1eff47a519f8637f10ad65c0d81eef01597c0/ash/system/palette/palette_tray_unittest.cc
[modify] https://crrev.com/1fa1eff47a519f8637f10ad65c0d81eef01597c0/ash/system/palette/tools/metalayer_unittest.cc
[modify] https://crrev.com/1fa1eff47a519f8637f10ad65c0d81eef01597c0/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc
[modify] https://crrev.com/1fa1eff47a519f8637f10ad65c0d81eef01597c0/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.h
[modify] https://crrev.com/1fa1eff47a519f8637f10ad65c0d81eef01597c0/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service_unittest.cc
[modify] https://crrev.com/1fa1eff47a519f8637f10ad65c0d81eef01597c0/chrome/browser/chromeos/arc/voice_interaction/highlighter_controller_client.cc
[modify] https://crrev.com/1fa1eff47a519f8637f10ad65c0d81eef01597c0/chrome/browser/chromeos/arc/voice_interaction/highlighter_controller_client.h
[modify] https://crrev.com/1fa1eff47a519f8637f10ad65c0d81eef01597c0/components/arc/test/fake_voice_interaction_framework_instance.cc
[modify] https://crrev.com/1fa1eff47a519f8637f10ad65c0d81eef01597c0/components/arc/test/fake_voice_interaction_framework_instance.h

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4dae233cd5f275f7913eee1cbbd7c7d8e67bfbc7

commit 4dae233cd5f275f7913eee1cbbd7c7d8e67bfbc7
Author: Vladislav Kaznacheev <kaznacheev@google.com>
Date: Wed Oct 18 19:48:48 2017

Improve unit test for HighlighterControllerClient

Instead of injecting a controller instance for testing
inject a connector. This makes the test code path closer
to the production path.

Bug:  769994 
Test: unit_tests --gtest_filter=ArcVoiceInteraction*
Change-Id: Id14f2cacd697436987c2211c7a3efdc535ed5262
Reviewed-on: https://chromium-review.googlesource.com/721885
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509842}
[modify] https://crrev.com/4dae233cd5f275f7913eee1cbbd7c7d8e67bfbc7/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service_unittest.cc
[modify] https://crrev.com/4dae233cd5f275f7913eee1cbbd7c7d8e67bfbc7/chrome/browser/chromeos/arc/voice_interaction/highlighter_controller_client.cc
[modify] https://crrev.com/4dae233cd5f275f7913eee1cbbd7c7d8e67bfbc7/chrome/browser/chromeos/arc/voice_interaction/highlighter_controller_client.h

Sign in to add a comment