New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 769993 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Proj-Servicification



Sign in to add a comment

Network service: DownloadContentTest.FetchErrorResponseBodyResumption failed

Project Member Reported by yzshen@chromium.org, Sep 28 2017

Issue description

Please see https://build.chromium.org/p/chromium.fyi/builders/Mojo%20Linux/builds/5793

Seems likely to be related to: https://chromium-review.googlesource.com/669300

You could run the test with the following flag to enable network service:

content_browsertests --enable-features=NetworkService 


[ RUN      ] DownloadContentTest.FetchErrorResponseBodyResumption
Xlib:  extension "RANDR" missing on display ":99".
DevTools listening on ws://127.0.0.1:39220/devtools/browser/087b5c12-8187-46e2-ba36-104a2176f195
[25676:25696:0928/154703.341355:29990109192:WARNING:child_process_launcher_helper_posix.cc(118)] Ignoring invalid file v8_context_snapshot.bin
[25702:25702:0928/154703.362772:29990130610:ERROR:gpu_info.cc(103)] No active GPU found, returning primary GPU.
[25705:25712:0928/154703.438660:29990206499:ERROR:url_loader_impl.cc(238)] Not implemented reached in virtual void content::URLLoaderImpl::SetPriority(net::RequestPriority, int32_t)
BrowserTestBase received signal: Terminated. Backtrace:
#0 0x00000258b367 base::debug::StackTrace::StackTrace()
#1 0x000002239351 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7f0adaec6cb0 <unknown>
#3 0x7f0adaf80c5d __poll
#4 0x7f0aded57fe4 <unknown>
#5 0x7f0aded580ec g_main_context_iteration
#6 0x0000025ade33 base::MessagePumpGlib::Run()
#7 0x0000025ab3fa base::MessageLoop::Run()
#8 0x0000025ce0b6 base::RunLoop::Run()
#9 0x0000022550cc content::RunMessageLoop()
#10 0x00000224290b content::DownloadUpdatedObserver::WaitForEvent()
#11 0x000000537fbb content::DownloadContentTest_FetchErrorResponseBodyResumption_Test::RunTestOnMainThread()
#12 0x0000022390bf content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#13 0x0000022a3299 content::ShellBrowserMainParts::PreMainMessageLoopRun()
#14 0x000001bcb7dd content::BrowserMainLoop::PreMainMessageLoopRun()
#15 0x000001ff6ac7 content::StartupTaskRunner::RunAllTasksNow()
#16 0x000001bc993e content::BrowserMainLoop::CreateStartupTasks()
#17 0x000001bce5b3 content::BrowserMainRunnerImpl::Initialize()
#18 0x0000022894ec ShellBrowserMain()
#19 0x00000228066e content::ShellMainDelegate::RunProcess()
#20 0x000001aebec6 content::RunNamedProcessTypeMain()
#21 0x000001aeca37 content::ContentMainRunnerImpl::Run()
#22 0x0000037a6d20 service_manager::Main()
#23 0x000000fbe3a2 content::ContentMain()
#24 0x000002238d49 content::BrowserTestBase::SetUp()
#25 0x00000222f66e content::ContentBrowserTest::SetUp()
#26 0x000000a634de testing::Test::Run()
#27 0x000000a63f50 testing::TestInfo::Run()
#28 0x000000a64437 testing::TestCase::Run()
#29 0x000000a6a927 testing::internal::UnitTestImpl::RunAllTests()
#30 0x000000a6a5b3 testing::UnitTest::Run()
#31 0x000002262008 base::TestSuite::Run()
#32 0x000002233043 content::ContentTestLauncherDelegate::RunTestSuite()
#33 0x000002250045 content::LaunchTests()
#34 0x000002232ff2 main
#35 0x7f0adaeb1f45 __libc_start_main
#36 0x000000486890 <unknown>
 
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09c1d10eddf5a4aee0fb7d137ba42f4d850e2d0e

commit 09c1d10eddf5a4aee0fb7d137ba42f4d850e2d0e
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Thu Sep 28 23:42:32 2017

Network service: suppress content browser test failure

DownloadContentTest.FetchErrorResponseBodyResumption

BUG= 769993 
TBR=xingliu@chromium.org

Change-Id: I9a807cb9107133526d38db3f4dc9e549630616a9
Reviewed-on: https://chromium-review.googlesource.com/691298
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505213}
[modify] https://crrev.com/09c1d10eddf5a4aee0fb7d137ba42f4d850e2d0e/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ade31776ad5ba07abeb0a3cbafb2cb7236f275d

commit 4ade31776ad5ba07abeb0a3cbafb2cb7236f275d
Author: Nicolas Dossou-gbete <dgn@chromium.org>
Date: Mon Oct 23 11:57:16 2017

Disable DownloadContentTest.FetchErrorResponseBodyResumption

Flaky passes on Android:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=FetchErrorResponseBodyResumption

TBR=qinmin@chromium.org

Bug:  769993 
Change-Id: I11555863a8569c2b57ab2bd67fa940c09ca1a26b
Reviewed-on: https://chromium-review.googlesource.com/732980
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510766}
[modify] https://crrev.com/4ade31776ad5ba07abeb0a3cbafb2cb7236f275d/content/browser/download/download_browsertest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/238d00c7f3b0ef8af6b95592e7a4b4e1dbe75716

commit 238d00c7f3b0ef8af6b95592e7a4b4e1dbe75716
Author: Min Qin <qinmin@chromium.org>
Date: Tue Oct 24 02:02:58 2017

Fix 2 flaky android download browsertests

Here are the fixes:
1. Chrome uses 100k write buffer, as defined in DownloadRequestCore.
So the current 10k data write is still too small.
Changed the pause offset to 100k in ParallelDownloadComplete test

2. ErrorInjectionDownloadFileFactory post a error injection task when creating a download file.
This task is executed after DownloadFileImpl::Initialize().
And the read call triggered by Initialize() could have already complete download.
This makes error injection to fail.
This CL fixes the behavior by injecting the error on file creation.

BUG= 769993 

Change-Id: I98a48b60b8cf5cb4b3219e603dd63127b65cec58
Reviewed-on: https://chromium-review.googlesource.com/734162
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511007}
[modify] https://crrev.com/238d00c7f3b0ef8af6b95592e7a4b4e1dbe75716/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/238d00c7f3b0ef8af6b95592e7a4b4e1dbe75716/content/browser/download/test_download_http_response.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8dcdec523ea5d34d5686f334b4b1325b4c9c80c

commit f8dcdec523ea5d34d5686f334b4b1325b4c9c80c
Author: Min Qin <qinmin@chromium.org>
Date: Sat Nov 04 15:17:27 2017

NetworkService: Populate fetch_error_body from DownloadUrlParameters to DownloadCreateInfo

DownloadResponseHandler takes the fetch_error_body value from DownloadUrlParameters.
However, it doesn't populate it to the DownloadCreateInfo.
And the DownloadItem will be created without setting fetch_error_body to true.

BUG= 715630 ,  769993 

Change-Id: Ia763b55ac363ad32cbf766755b49faa70b0647d2
Reviewed-on: https://chromium-review.googlesource.com/754331
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514051}
[modify] https://crrev.com/f8dcdec523ea5d34d5686f334b4b1325b4c9c80c/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/f8dcdec523ea5d34d5686f334b4b1325b4c9c80c/content/browser/download/download_response_handler.cc
[modify] https://crrev.com/f8dcdec523ea5d34d5686f334b4b1325b4c9c80c/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Comment 7 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.
Status: Fixed (was: Assigned)

Sign in to add a comment