I see this recently. Sometimes download home shows indefinite progress for a offline page even though it has completed (as per notifications)

I tracked down this to some observer callbacks in DownloadUIAdapter.
The sequence of callbacks are as follows.
1- DownloadUIAdapter::OnAdded
2- DownloadUIAdapter::OfflinePageAdded
3- DownloadUIAdapter::OnChanged
4- DownloadUIAdapter::OnCompleted

OnChanged sometimes comes before OfflinePageAdded and sometimes after. The DownloadUIAdapter state is dependent on this order and hence the UI breaks. In the failure case, we change the state from complete to in progress again because the OnChanged callback was delayed.

I guess the question is - is this expected in which case we should handle this case in the DownloadUIAdapter or fix it upstream.  

Steps (not fully repro)
1- open cnn.com. Start downloading.
2- Switch to google.com with some search text. Start downloading.
3- Open download home. You can see both are in progress, even though #2 is done.

 

I see this recently. Sometimes download home shows indefinite progress for a offline page even though it has completed (as per notifications)

I tracked down this to some observer callbacks in DownloadUIAdapter.
The sequence of callbacks as observed are as follows.
 DownloadUIAdapter::OnAdded
 DownloadUIAdapter::OfflinePageAdded
 DownloadUIAdapter::OnChanged
 DownloadUIAdapter::OnCompleted

OnChanged sometimes comes before OfflinePageAdded and sometimes after. The DownloadUIAdapter state is dependent on this order and hence the UI breaks. In the failure case, we change the state from complete to in progress again because the OnChanged callback was delayed.

I guess the question is - is this expected in which case we should handle this case in the DownloadUIAdapter or fix it upstream? 

Steps (not fully repro)
1- open cnn.com. Start downloading.
2- Switch to google.com with some search text. Start downloading.
3- Open download home. You can see both are in progress, even though #2 is done.