text-overflow conflict with left.
Reported by
d...@rewsllc.com,
Sep 28 2017
|
|||||||||||||||
Issue description
UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36
Example URL:
Steps to reproduce the problem:
1. view html
<style>
.test {
overflow:hidden;
width:100px;
white-space:nowrap;
display:inline-block;
text-overflow:ellipsis;
position:static;
word-wrap:break-word;
left:100px;
}
</style>
<div class="test">this is a long sentence of text that overflows</div>
<div class="test">https://thisisalongurl.com/fulloftext/that/overflows</div>
<div class="test"><a href="http://test.com">this is a long sentence of text that overflows</a></div>
<div class="test"><a href="http://test.com">https://thisisalongurl.com/fulloftext/that/overflows</a></div>
What is the expected behavior?
display:
"this is a long... https://thisis... this is a long... https://thisis..."
or some slight variation based on font rendering.
What went wrong?
white page was rendered.
Does it occur on multiple sites: Yes
Is it a problem with a plugin? No
Did this work before? Yes Uncertain.
Does this work in other browsers? N/A
Chrome version: 61.0.3163.100 Channel: stable
OS Version: 10.0
Flash Version:
the issue appears when left is set, left in this configuration should be no-op, since the position is static.
Tested and confirmed as working in latest edge, and firefox.
,
Sep 29 2017
,
Sep 29 2017
Able to reproduce the issue on Windows 10, Ubuntu 14.04 and Mac 10.12.6 using chrome stable version #61.0.3163.100 and latest canary #63.0.3226.0. Bisect Information: ===================== Good build: 61.0.3156.0 Revision(486205) Bad Build : 61.0.3158.0 Revision(486952) Change Log URL: https://chromium.googlesource.com/chromium/src/+log/b694253de687440c5e180ffef488f5e1b6a6eee3..74bd1c084916b057eb7936bf9871721eb0e61fa3 From the above change log suspecting below change Change-Id: I66c848299a93b2b796f2f831d9237f41aa50e962 Reviewed-on: https://chromium-review.googlesource.com/563625 robhogan@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: Adding label ReleaseBlock-Stable as it seems to be a recent regression. Please feel free to remove the same if not appropriate. ccing the reviewer of the issue as the owner's chromium account seems to have some issue. Thanks...!!
,
Sep 29 2017
,
Sep 29 2017
,
Sep 30 2017
Does this break any existing web sites? If not it shouldn't be marked as a blocker or even be a P1.
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4faf23a5c80243570afa152d42c8a76c7c1930b5 commit 4faf23a5c80243570afa152d42c8a76c7c1930b5 Author: Robert Hogan <robhogan@gmail.com> Date: Mon Oct 02 18:30:33 2017 Don't apply relative offset when element is not relative positioned Bug: 769980 Change-Id: Ibb010a3a2ca834471e35ee8d54e5bc5b65f5176f Reviewed-on: https://chromium-review.googlesource.com/692936 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#505684} [add] https://crrev.com/4faf23a5c80243570afa152d42c8a76c7c1930b5/third_party/WebKit/LayoutTests/fast/text/ellipsis-in-static-div-with-left-specified-expected.html [add] https://crrev.com/4faf23a5c80243570afa152d42c8a76c7c1930b5/third_party/WebKit/LayoutTests/fast/text/ellipsis-in-static-div-with-left-specified.html [modify] https://crrev.com/4faf23a5c80243570afa152d42c8a76c7c1930b5/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp [modify] https://crrev.com/4faf23a5c80243570afa152d42c8a76c7c1930b5/third_party/WebKit/Source/core/layout/api/LineLayoutItem.h [modify] https://crrev.com/4faf23a5c80243570afa152d42c8a76c7c1930b5/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
,
Oct 2 2017
,
Oct 2 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-61; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-61 label, otherwise remove Merge-TBD label. Thanks.
,
Oct 2 2017
Please request a merge to M61 (No M62 stable respin plan at this point unless critical issue arise) and M62 if needed. +abdulsyed@ to keep an eye on merge request.
,
Oct 3 2017
eae@ - can you please request this to M62 if it's needed?
,
Oct 3 2017
,
Oct 3 2017
This bug requires manual review: We are only 13 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 4 2017
Approving merge to M62. Branch:3202
,
Oct 5 2017
Mm, patch doesn't apply to M62. Not merging.
,
Oct 5 2017
Thanks robhogan@ can you please provide more details? Seems like this is present in both M61 and M62 (based on labels). can you elaborate why this patch does not apply for M62?
,
Oct 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21c25258e0fad8b995fbdc5790d45304d544b319 commit 21c25258e0fad8b995fbdc5790d45304d544b319 Author: Robert Hogan <robhogan@gmail.com> Date: Sat Oct 07 10:45:54 2017 Don't apply relative offset when element is not relative positioned TBR=robhogan@gmail.com (cherry picked from commit 4faf23a5c80243570afa152d42c8a76c7c1930b5) Bug: 769980 Change-Id: Ibb010a3a2ca834471e35ee8d54e5bc5b65f5176f Reviewed-on: https://chromium-review.googlesource.com/692936 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#505684} Reviewed-on: https://chromium-review.googlesource.com/706774 Reviewed-by: Robert Hogan <robhogan@gmail.com> Cr-Commit-Position: refs/branch-heads/3202@{#611} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [add] https://crrev.com/21c25258e0fad8b995fbdc5790d45304d544b319/third_party/WebKit/LayoutTests/fast/text/ellipsis-in-static-div-with-left-specified-expected.html [add] https://crrev.com/21c25258e0fad8b995fbdc5790d45304d544b319/third_party/WebKit/LayoutTests/fast/text/ellipsis-in-static-div-with-left-specified.html [modify] https://crrev.com/21c25258e0fad8b995fbdc5790d45304d544b319/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp [modify] https://crrev.com/21c25258e0fad8b995fbdc5790d45304d544b319/third_party/WebKit/Source/core/layout/api/LineLayoutItem.h [modify] https://crrev.com/21c25258e0fad8b995fbdc5790d45304d544b319/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
,
Oct 9 2017
This bug was originally approved for M62 at #14 but rejected at #16. abdulsyed@, are you ok with this merge to M62 (it is already merged at #17)?
,
Oct 10 2017
Confirmed with eae@ that this is a safe merge overall. Removing Merge-TBD and marking it as merge-approved.
,
Oct 10 2017
Removing merge-approved, since it's already merged. |
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by woxxom@gmail.com
, Sep 28 2017