Issue metadata
Sign in to add a comment
|
DevTools network conditions setup does not work for service workers. |
||||||||||||||||||||||
Issue descriptionThis is a regression caused by an "Off-main-thread fetch for Web Workers" 1. Switch page to "Offline" mode using the DevTools. 2. Attempt a fetch from a service worker. Expected: no request sent to a server Actual: request is sent to a server
,
Oct 9 2017
horo@, this is causing some problems for us, I am not sure if you already have a bug around this or not?
,
Oct 9 2017
What version are you using? We enabled off-main-thread-fetch by default in M62. Did you enable chrome://flags/#enable-off-main-thread-fetch?
,
Oct 9 2017
I am using tip of tree. This issue manifests itself when the flag is enabled.
,
Oct 9 2017
Ah, I can reproduce the issue. I will take a look today.
,
Oct 10 2017
,
Oct 10 2017
Setting flags, based on the theory that this is caused by off-main-thread Fetch. allada@: Is P3 correct or would you consider this bug blocking for M62, or somewhere in between? jimmyshen@: Can you confirm if you're using the off-main-thread Fetch flag in 61? Or are you possibly seeing a different bug, like issue 749884 ?
,
Oct 10 2017
I created a cl for this bug: https://chromium-review.googlesource.com/c/chromium/src/+/708158
,
Oct 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c29cb533e1614ed64521fe737b7af36447213296 commit c29cb533e1614ed64521fe737b7af36447213296 Author: Tsuyoshi Horo <horo@chromium.org> Date: Tue Oct 10 07:46:47 2017 DevTools: Support resource throttling with off-main-thread-fetch When off-main-thread-fetch is not enabled, the X-DevTools-Emulate-Network-Conditions-Client-Id header is set in the main thread. But when off-main-thread-fetch is enabled, the header must be set in the worker thread. This CL change the DevTools code to pass the host ID from the main thread to the worker thread, and set it in the header. Bug: 769972 Change-Id: I2ef7e840abea4afd23f6a058fb1eb39615677a30 Reviewed-on: https://chromium-review.googlesource.com/708158 Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#507613} [modify] https://crrev.com/c29cb533e1614ed64521fe737b7af36447213296/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp [modify] https://crrev.com/c29cb533e1614ed64521fe737b7af36447213296/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp [modify] https://crrev.com/c29cb533e1614ed64521fe737b7af36447213296/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp [modify] https://crrev.com/c29cb533e1614ed64521fe737b7af36447213296/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h [modify] https://crrev.com/c29cb533e1614ed64521fe737b7af36447213296/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp [modify] https://crrev.com/c29cb533e1614ed64521fe737b7af36447213296/third_party/WebKit/Source/core/inspector/WorkerInspectorController.h [modify] https://crrev.com/c29cb533e1614ed64521fe737b7af36447213296/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp [modify] https://crrev.com/c29cb533e1614ed64521fe737b7af36447213296/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.h
,
Oct 11 2017
Fixed in 63.0.3237.0 $ git find-releases c29cb533e1614ed64521fe737b7af36447213296 commit c29cb533e1614ed64521fe737b7af36447213296 was: initially in 63.0.3237.0 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by jimmyshen@google.com
, Oct 5 2017