New issue
Advanced search Search tips

Issue 769963 link

Starred by 2 users
Status: Fixed
Owner:
bpastene@chromium.org
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Respawn android_docker containers on new CIPD package.

Project Member Reported by bpastene@chromium.org, Sep 28 2017 
This prevent the fix for bug 768915 from taking effect immediately. I had to wait up to 4 hours for the containers to exceed their max uptime.

I should make it so when a new version of the android_docker package is downloaded, all containers get reset. This can be done by applying a label to each container that specifies the current version when it was created. When that label doesn't match the current version, we just respawn.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/2f54897012aed337b47d91b472ffea1d5dbb07a4

commit 2f54897012aed337b47d91b472ffea1d5dbb07a4
Author: Benjamin Pastene <bpastene@chromium.org>
Date: Wed Oct 04 17:14:57 2017

android_docker: Label containers with current cipd package.

And also respawn any containers that don't match the current version.

Bug:  769963 
Change-Id: I6a55e0f069f64d2f4192b3bb9b70878a59326026
Reviewed-on: https://chromium-review.googlesource.com/691219
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Benjamin Pastene <bpastene@chromium.org>

[modify] https://crrev.com/2f54897012aed337b47d91b472ffea1d5dbb07a4/infra/services/android_docker/containers.py
[modify] https://crrev.com/2f54897012aed337b47d91b472ffea1d5dbb07a4/infra/services/android_docker/__main__.py
[modify] https://crrev.com/2f54897012aed337b47d91b472ffea1d5dbb07a4/infra/services/android_docker/test/containers_test.py

Comment 2 by bpastene@chromium.org, May 25 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment