New issue
Advanced search Search tips

Issue 769949 link

Starred by 2 users
Status: Assigned
Owner:
ctzsm@chromium.org
Cc:
boliu@chromium.org
amaralp@chromium.org
changwan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

[Smart Selection] Remove requesting surrounding text IPC.

Project Member Reported by ctzsm@chromium.org, Sep 28 2017 
To simplify the code path, reduce the possibility of race condition.

Idea is to get surrounding text from showSelectionMenu() call directly.

+ amaralp@ and boliu@, you are reviewers of https://codereview.chromium.org/2740103006, any concern about this?

Comment 1 by amaralp@chromium.org, Sep 28 2017 

To be clear, do you mean you'd pass the surrounding text as an extra parameter to showSelectionMenu()? I think that would be a good idea.

Comment 2 by ctzsm@chromium.org, Sep 28 2017 

Re#1, yeah, actually thinking of a struct to contain surrounding text and position of selection text to showSelectionMenu() to replace the current |selectionText| parameter.
►

Sign in to add a comment