New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 769946 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

MD Extensions: Permissions list doesn't include sub-permissions

Project Member Reported by rdevlin....@chromium.org, Sep 28 2017

Issue description

What steps will reproduce the problem?
1. Install the extension with the attached manifest
2. Look at permissions

What is the expected result?
It should say "Read and change your data on a number of websites" and give a way of seeing those sites.


What happens instead of that?
It only says "Read and change your data on a number of websites" with no indication of which sites they are.
 
manifest.json
242 bytes View Download
Status: Started (was: Assigned)
manifest.json
1.2 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8b178389a991ace9678a0db6e8b570fb42950a2

commit b8b178389a991ace9678a0db6e8b570fb42950a2
Author: Scott Chen <scottchen@chromium.org>
Date: Sat Oct 21 01:45:04 2017

MD Extensions: pass subpermissions through extensionsInfo

Bug:  769946 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9c42a190e244e1ee4144e42a687589179f544aad
Reviewed-on: https://chromium-review.googlesource.com/717573
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510639}
[modify] https://crrev.com/b8b178389a991ace9678a0db6e8b570fb42950a2/chrome/browser/extensions/api/developer_private/extension_info_generator.cc
[modify] https://crrev.com/b8b178389a991ace9678a0db6e8b570fb42950a2/chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc
[modify] https://crrev.com/b8b178389a991ace9678a0db6e8b570fb42950a2/chrome/browser/resources/md_extensions/detail_view.html
[modify] https://crrev.com/b8b178389a991ace9678a0db6e8b570fb42950a2/chrome/browser/resources/md_extensions/detail_view.js
[modify] https://crrev.com/b8b178389a991ace9678a0db6e8b570fb42950a2/chrome/common/extensions/api/developer_private.idl
[modify] https://crrev.com/b8b178389a991ace9678a0db6e8b570fb42950a2/third_party/closure_compiler/externs/developer_private.js

Comment 4 by dpa...@chromium.org, Oct 25 2017

Status: Fixed (was: Started)
I believe this is fixed now. Please re-open if not.

Sign in to add a comment