New issue
Advanced search Search tips

Issue 769934 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Snap to 100% zoom if a trackpad pinch ends very close to 100%

Project Member Reported by seobrien@chromium.org, Sep 28 2017

Issue description

If the user ends a trackpad pinch with 105% zoom or lower, they probably intended to zoom out completely.  Add a scale animation to bring zoom to 100%
 

Comment 1 by shrike@chromium.org, Oct 11 2017

This screencast shows the current proposed implementation - note that on release the content jerks slightly to the right before scaling down.
ScaleAnimationTo100.mov
8.8 MB Download
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09fb8b74136673deff299b41e26619767c8928cd

commit 09fb8b74136673deff299b41e26619767c8928cd
Author: Sean O'Brien <seobrien@google.com>
Date: Thu Nov 30 20:45:47 2017

Blink: Snap page scale to 100% on trackpad pinch end

If a trackpad pinch ends at scale level 105% or lower, snap to 100% with
a scale animation.

BUG= 769934 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I6d7e185951900f11afadf80c7eeea16f8a4156b6
Reviewed-on: https://chromium-review.googlesource.com/691202
Commit-Queue: Sean O'Brien <seobrien@chromium.org>
Reviewed-by: Mike Pinkerton <pinkerton@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520667}
[modify] https://crrev.com/09fb8b74136673deff299b41e26619767c8928cd/cc/input/input_handler.h
[modify] https://crrev.com/09fb8b74136673deff299b41e26619767c8928cd/cc/input/page_scale_animation.cc
[modify] https://crrev.com/09fb8b74136673deff299b41e26619767c8928cd/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/09fb8b74136673deff299b41e26619767c8928cd/cc/layers/viewport.cc
[modify] https://crrev.com/09fb8b74136673deff299b41e26619767c8928cd/cc/layers/viewport.h
[modify] https://crrev.com/09fb8b74136673deff299b41e26619767c8928cd/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/09fb8b74136673deff299b41e26619767c8928cd/cc/trees/layer_tree_host_impl.h
[modify] https://crrev.com/09fb8b74136673deff299b41e26619767c8928cd/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/09fb8b74136673deff299b41e26619767c8928cd/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/09fb8b74136673deff299b41e26619767c8928cd/cc/trees/layer_tree_host_unittest_picture.cc
[modify] https://crrev.com/09fb8b74136673deff299b41e26619767c8928cd/third_party/WebKit/Source/core/exported/WebViewImpl.cpp
[modify] https://crrev.com/09fb8b74136673deff299b41e26619767c8928cd/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/09fb8b74136673deff299b41e26619767c8928cd/ui/events/blink/input_handler_proxy_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment