New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 769898 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Horizontal stripe connected to border across section. Disappears when clicked or text is selected.

Reported by murray...@gmail.com, Sep 28 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36

Steps to reproduce the problem:
1. Just view the page, look for red horizontal band.
2. If not visible, try resizing window. Maximize, restore, etc.
3. Have confirmed on several different machines, but unable to reproduce on other similar machines.
4. Large display size (4k) seems to make it easier to reproduce.

What is the expected behavior?

What went wrong?
Large red (same color as border) stripe shouldn't appear.

Did this work before? N/A 

Does this work in other browsers? Yes

Chrome version: 61.0.3163.100  Channel: canary
OS Version: 10.0
Flash Version: 

I tried to strip down the CSS as much as possible. Removing most any remaining line of CSS seems to influence it, usually removing it. Really bizarre, seemingly unrelated code will affect it: Page margins, background color, borders, etc.
 
bug.html
9.8 KB View Download
2017-09-28 16_00_32-bug.html.png
312 KB View Download
Labels: Needs-Triage-M61
Cc: mmnchala@chromium.org
Components: Blink>CSS
Labels: -Type-Bug -Pri-2 hasbisect-per-revision M-63 Pri-1 Type-Bug-Regression
Owner: brianosman@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on reported version 61.0.3163.100 and on latest canary 63.0.3232.0 on Windows 7 and 10. Unable to reproduce on Ubuntu 14.04 and Mac OS 10.12.6.

Bisect Information:
===================
Good Build:60.0.3094.0
Bad Build: 60.0.3095.0

You are probably looking for a change made after 480608 (known good), but no later than 480609 (first known bad).

CHANGELOG URL:
 https://chromium.googlesource.com/chromium/src/+log/b0ec883fdeea4c3b2b13900650c744d22e0b0f22..f41443c03b03d8e2d83314ae4690f402beada8b4

Blink CL:
https://skia.googlesource.com/skia.git/+log/05814de6ba50..6410d29e1173

Suspecting https://skia.googlesource.com/skia.git/+/d2da87d0b8d127da0530c661618f059eb1cc0f1e from the above Blink CL

@brianosman: Could you please look into this issue and help in re-assigning if not related to your change

Thanks!

Comment 3 by shend@chromium.org, Oct 5 2017

Components: -Blink>CSS Internals>Skia
Bisect range doesn't contain any CSS related changes. Redirecting to skia based on #c2.
Labels: -hasbisect-per-revision hasbisect
Cc: brianosman@chromium.org
Owner: robertphillips@chromium.org
Rob, I bisected into the Skia roll, and found that this broke when deferred proxies were enabled: https://skia.googlesource.com/skia.git/+/b37208f11a022dfbff0e54eb8246ed9b7951c58e

Sounds like you've been re-disabling this lately?
On a Win10 Z620 with an nVidia Quadro K620, I've able to repro this in:

61.0.3163.100 stable
62.0.3202.45 beta
63.0.3236.0 canary

The last repro case is interesting because deferred proxies were disabled in: 

63.0.3231.0 via https://skia-review.googlesource.com/c/skia/+/54004

to address  crbug.com/769760 .

So, something is going on here.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 9 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/c7e66ea989006b6f21ccf4e4c33644a55b5455ec

commit c7e66ea989006b6f21ccf4e4c33644a55b5455ec
Author: Robert Phillips <robertphillips@google.com>
Date: Mon Oct 09 18:07:34 2017

Disable deferred proxies a different way in Chrome

This keeps  crbug.com/769760  working but also fixes the new bug ( crbug.com/769898 )

Bug:  769898 
Change-Id: I53c00e2bca602fa9c33e5a50a98274c1ce8b2534
Reviewed-on: https://skia-review.googlesource.com/57282
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>

[modify] https://crrev.com/c7e66ea989006b6f21ccf4e4c33644a55b5455ec/src/gpu/GrSurfaceProxy.cpp

The fix in #7 rolled into Chrome on 10/10 in https://chromium-review.googlesource.com/c/chromium/src/+/709074 at r507663. It does not appear to have made into a Canary yet.
Labels: Merge-Request-62
The fix in #7 has been running on the Chrome bots for 2 days and is in the 63.0.3237.0 (and above) Canaries. I've verified that the bug is fixed in the 63.0.3237.7 Windows Canary.

I'm requesting a cherry-pick back to M62.

Note that this CL is very safe. Proxies were already disabled in Skia prior to the fix in #7. The CL in #7 just disables the proxies in a different manner. In fact, we have had to disable deferred proxies before and #7 more closely matches how we have done so in the past.
Project Member

Comment 10 by sheriffbot@chromium.org, Oct 12 2017

Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: We are only 4 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-62 Merge-Rejected-62
We are only 4 days away from M62 Stable. Can you please confirm why this is critical to take in for M62? My recommendation is to wait until M63, as this doesn't appear to be a release blocking issue. Marking bug as rejected for now; but please re-request if you disagree.
Cc: bsalo...@google.com
This bug is actually a different manifestation of  crbug.com/769760  which is marked M62 ReleaseBlock-Stable. 

In both cases, Skia is inappropriately recycling a GL texture.

The fix for  crbug.com/769760  was not sufficient to fix this manifestation.
Labels: -Merge-Rejected-62 Merge-Request-62
I'm requesting a second look at cherry-picking the fix in #7 back to M62.

It is a very safe CL and more closely matches how we have disabled deferred proxies in the past.

Also please see the comments in #12.
Project Member

Comment 14 by sheriffbot@chromium.org, Oct 13 2017

Labels: -Merge-Request-62 Merge-Review-62
This bug requires manual review: We are only 3 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-62 Merge-Approved-62
Thanks for the feedback. Approving merge to M62 based on #9 and #12. Branch:3202
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 15 2017

Labels: merge-merged-m62
The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/f06e581d4013d8290e8de81f9afc557deaf762c2

commit f06e581d4013d8290e8de81f9afc557deaf762c2
Author: Robert Phillips <robertphillips@google.com>
Date: Fri Oct 13 19:26:41 2017

[M62 cherry-pick] Disable deferred proxies a different way in Chrome

This keeps  crbug.com/769760  working but also fixes the new bug ( crbug.com/769898 )

One can compare with https://skia-review.googlesource.com/c/skia/+/18592 ([M60 cherry-pick] Disable deferred proxies for M60 branch)

No-Tree-Checks: true
No-Try: true
No-Presubmit: true
Bug:  769898 
Change-Id: Iaae59ae6534e5ee9a1fc8f30149e32bd5e022b78
Reviewed-on: https://skia-review.googlesource.com/59683
Reviewed-by: Brian Salomon <bsalomon@google.com>

[modify] https://crrev.com/f06e581d4013d8290e8de81f9afc557deaf762c2/tests/DetermineDomainModeTest.cpp
[modify] https://crrev.com/f06e581d4013d8290e8de81f9afc557deaf762c2/src/gpu/GrSurfaceProxy.cpp
[modify] https://crrev.com/f06e581d4013d8290e8de81f9afc557deaf762c2/tests/ProxyTest.cpp
[modify] https://crrev.com/f06e581d4013d8290e8de81f9afc557deaf762c2/tests/ProxyRefTest.cpp

Project Member

Comment 17 by bugdroid1@chromium.org, Oct 15 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/87a71e3405ff51c93aa9f0ee68904b6f27080d65

commit 87a71e3405ff51c93aa9f0ee68904b6f27080d65
Author: Robert Phillips <robertphillips@google.com>
Date: Fri Oct 13 19:42:55 2017

Revert "[M62 cherry-pick] Disable deferred proxies a different way in Chrome"

This reverts commit f06e581d4013d8290e8de81f9afc557deaf762c2.

Reason for revert: nag bot

Original change's description:
> [M62 cherry-pick] Disable deferred proxies a different way in Chrome
> 
> This keeps  crbug.com/769760  working but also fixes the new bug ( crbug.com/769898 )
> 
> One can compare with https://skia-review.googlesource.com/c/skia/+/18592 ([M60 cherry-pick] Disable deferred proxies for M60 branch)
> 
> No-Tree-Checks: true
> No-Try: true
> No-Presubmit: true
> Bug:  769898 
> Change-Id: Iaae59ae6534e5ee9a1fc8f30149e32bd5e022b78
> Reviewed-on: https://skia-review.googlesource.com/59683
> Reviewed-by: Brian Salomon <bsalomon@google.com>

TBR=bsalomon@google.com,robertphillips@google.com

Change-Id: I3a61ccb59e6027e0b344e723e9cb6b79b2eb3f47
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  769898 
Reviewed-on: https://skia-review.googlesource.com/59780
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>

[modify] https://crrev.com/87a71e3405ff51c93aa9f0ee68904b6f27080d65/tests/DetermineDomainModeTest.cpp
[modify] https://crrev.com/87a71e3405ff51c93aa9f0ee68904b6f27080d65/src/gpu/GrSurfaceProxy.cpp
[modify] https://crrev.com/87a71e3405ff51c93aa9f0ee68904b6f27080d65/tests/ProxyTest.cpp
[modify] https://crrev.com/87a71e3405ff51c93aa9f0ee68904b6f27080d65/tests/ProxyRefTest.cpp

Project Member

Comment 18 by bugdroid1@chromium.org, Oct 15 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/e74b41c6c84638d5a9ee6d254a715bcd9e17c603

commit e74b41c6c84638d5a9ee6d254a715bcd9e17c603
Author: Robert Phillips <robertphillips@google.com>
Date: Fri Oct 13 21:45:28 2017

[M62 cherry-pick] Disable deferred proxies a different way in Chrome

This keeps  crbug.com/769760  working but also fixes the new bug ( crbug.com/769898 )

One can compare with https://skia-review.googlesource.com/c/skia/+/18592 ([M60 cherry-pick] Disable deferred proxies for M60 branch)

No-Tree-Checks: true
No-Try: true
No-Presubmit: true
Bug:  769898 
Change-Id: Ic9a9f8cd540bda04624f79e679744ccb4feaa75f
Reviewed-on: https://skia-review.googlesource.com/59746
Reviewed-by: Robert Phillips <robertphillips@google.com>

[modify] https://crrev.com/e74b41c6c84638d5a9ee6d254a715bcd9e17c603/tests/DetermineDomainModeTest.cpp
[modify] https://crrev.com/e74b41c6c84638d5a9ee6d254a715bcd9e17c603/src/gpu/GrSurfaceProxy.cpp
[modify] https://crrev.com/e74b41c6c84638d5a9ee6d254a715bcd9e17c603/tests/ProxyTest.cpp
[modify] https://crrev.com/e74b41c6c84638d5a9ee6d254a715bcd9e17c603/tests/ProxyRefTest.cpp

Labels: -Merge-Approved-62
Removing Merge-Approved, as it has been Merged.
Cc: hcm@chromium.org mtklein@chromium.org divya.pa...@techmahindra.com robertphillips@chromium.org krajshree@chromium.org hdodda@chromium.org
 Issue 773465  has been merged into this issue.
The fix in #18 is now available in 62.0.3202.62.

Comment 22 by g33...@gmail.com, Oct 18 2017

Thanks!!!
Project Member

Comment 24 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/fc28138c0422637741ac2839914ef10c56438054

commit fc28138c0422637741ac2839914ef10c56438054
Author: Robert Phillips <robertphillips@google.com>
Date: Mon Oct 30 15:58:03 2017

Revert "Fix GrDefaultPathRender inversely wound path bug"

This reverts commit 511a9d49998ec6a74c375e6cfc55f660f7987c40.

Reason for revert: vulkan

Original change's description:
> Fix GrDefaultPathRender inversely wound path bug
> 
> Bug:  769898 
> Change-Id: I3b1a43b1e114b35105493a0cfa01a1f01b65fa56
> Reviewed-on: https://skia-review.googlesource.com/64065
> Commit-Queue: Robert Phillips <robertphillips@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>

TBR=bsalomon@google.com,robertphillips@google.com

Change-Id: Ib1a987294d14f0526bf5ff5a8fd90bbd5f6f3a0d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  769898 
Reviewed-on: https://skia-review.googlesource.com/65201
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>

[modify] https://crrev.com/fc28138c0422637741ac2839914ef10c56438054/src/gpu/ops/GrDefaultPathRenderer.cpp
[modify] https://crrev.com/fc28138c0422637741ac2839914ef10c56438054/dm/DM.cpp
[delete] https://crrev.com/dd992c4a461040e798a02cba028e55cdcd856026/tests/DefaultPathRendererTest.cpp
[modify] https://crrev.com/fc28138c0422637741ac2839914ef10c56438054/tests/ResourceCacheTest.cpp
[modify] https://crrev.com/fc28138c0422637741ac2839914ef10c56438054/gn/tests.gni
[modify] https://crrev.com/fc28138c0422637741ac2839914ef10c56438054/src/gpu/ops/GrMSAAPathRenderer.cpp
[modify] https://crrev.com/fc28138c0422637741ac2839914ef10c56438054/tests/Test.h

Project Member

Comment 25 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/ec3253472947b0df618261479336a7b50b24f0c8

commit ec3253472947b0df618261479336a7b50b24f0c8
Author: Robert Phillips <robertphillips@google.com>
Date: Mon Oct 30 18:02:59 2017

Revert "Revert "Fix GrDefaultPathRender inversely wound path bug""

This reverts commit fc28138c0422637741ac2839914ef10c56438054.

Reason for revert: Suppression have landed for failing tests

Original change's description:
> Revert "Fix GrDefaultPathRender inversely wound path bug"
> 
> This reverts commit 511a9d49998ec6a74c375e6cfc55f660f7987c40.
> 
> Reason for revert: vulkan
> 
> Original change's description:
> > Fix GrDefaultPathRender inversely wound path bug
> > 
> > Bug:  769898 
> > Change-Id: I3b1a43b1e114b35105493a0cfa01a1f01b65fa56
> > Reviewed-on: https://skia-review.googlesource.com/64065
> > Commit-Queue: Robert Phillips <robertphillips@google.com>
> > Reviewed-by: Brian Salomon <bsalomon@google.com>
> 
> TBR=bsalomon@google.com,robertphillips@google.com
> 
> Change-Id: Ib1a987294d14f0526bf5ff5a8fd90bbd5f6f3a0d
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  769898 
> Reviewed-on: https://skia-review.googlesource.com/65201
> Reviewed-by: Robert Phillips <robertphillips@google.com>
> Commit-Queue: Robert Phillips <robertphillips@google.com>

TBR=bsalomon@google.com,robertphillips@google.com

Change-Id: I3a3543c46b3192f1ffd31a5566cf337dc03561a8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  769898 
Reviewed-on: https://skia-review.googlesource.com/65202
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>

[modify] https://crrev.com/ec3253472947b0df618261479336a7b50b24f0c8/src/gpu/ops/GrDefaultPathRenderer.cpp
[modify] https://crrev.com/ec3253472947b0df618261479336a7b50b24f0c8/dm/DM.cpp
[add] https://crrev.com/ec3253472947b0df618261479336a7b50b24f0c8/tests/DefaultPathRendererTest.cpp
[modify] https://crrev.com/ec3253472947b0df618261479336a7b50b24f0c8/tests/ResourceCacheTest.cpp
[modify] https://crrev.com/ec3253472947b0df618261479336a7b50b24f0c8/gn/tests.gni
[modify] https://crrev.com/ec3253472947b0df618261479336a7b50b24f0c8/src/gpu/ops/GrMSAAPathRenderer.cpp
[modify] https://crrev.com/ec3253472947b0df618261479336a7b50b24f0c8/tests/Test.h

Project Member

Comment 26 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a92fe336f8d823fa96c5916508303f10ce30629e

commit a92fe336f8d823fa96c5916508303f10ce30629e
Author: Robert Phillips <robertphillips@google.com>
Date: Tue Oct 31 20:36:30 2017

Reenable Skia's deferred proxies

Bug:  774090 ,  769898 ,  769760 
Change-Id: Id6ddfa82a2c16da476b2caaa93d5d3cd99aaedc8
Reviewed-on: https://chromium-review.googlesource.com/744683
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512944}
[modify] https://crrev.com/a92fe336f8d823fa96c5916508303f10ce30629e/skia/config/SkUserConfig.h
[modify] https://crrev.com/a92fe336f8d823fa96c5916508303f10ce30629e/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-expected.png
[modify] https://crrev.com/a92fe336f8d823fa96c5916508303f10ce30629e/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-png-expected.png
[modify] https://crrev.com/a92fe336f8d823fa96c5916508303f10ce30629e/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-mask-image-svg-expected.png
[modify] https://crrev.com/a92fe336f8d823fa96c5916508303f10ce30629e/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-expected.png
[modify] https://crrev.com/a92fe336f8d823fa96c5916508303f10ce30629e/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-png-expected.png
[modify] https://crrev.com/a92fe336f8d823fa96c5916508303f10ce30629e/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-mask-image-svg-expected.png

The fix in #26 landed in Chrome at 512944 and is in the 64.0.3255.0 Canary.

I have verified that this bug remains fixed in that Canary even though the causal feature has been re-enabled.
Status: Fixed (was: Assigned)

Sign in to add a comment