New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 769885 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

webkit_layout_tests failing on chromium.webkit/WebKit Linux Trusty Leak

Project Member Reported by dmu...@chromium.org, Sep 28 2017

Issue description

webkit_layout_tests failing on chromium.webkit/WebKit Linux Trusty Leak

Builders failed on: 
- WebKit Linux Trusty Leak: 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak


virtual/android/fullscreen/full-screen-frameset.html ( Code Search )

Flaky test.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b45e77eeaad08e79641779c9a2f181cdd750d958

commit b45e77eeaad08e79641779c9a2f181cdd750d958
Author: Mike West <mkwst@chromium.org>
Date: Mon Oct 02 09:51:11 2017

Skip 'virtual/android/fullscreen/full-screen-frameset.html'.

This test flakily leaks:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fandroid%2Ffullscreen%2Ffull-screen-frameset.html&testType=webkit_layout_tests

First leaky build was http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/10289
but that just adds a test, so it must be something earlier. :/

Bug: 769885
Change-Id: I67a6e71cf0aba6d0906eacf20c1711ef2c86ab39
TBR: fsamuel@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/695301
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505565}
[modify] https://crrev.com/b45e77eeaad08e79641779c9a2f181cdd750d958/third_party/WebKit/LayoutTests/TestExpectations

Labels: -Sheriff-Chromium
Owner: fsam...@chromium.org
Status: Assigned (was: Available)
This bug is not actionable. Please set at least a component and/or CC someone so it doesn't just sit here forever.

Maybe fsamuel@chromium.org can decide what to do?

Components: Blink
I'm going to resurrect this bug.

It is very daunting, but here it is.
Since turning green March 26 a number of runs have failed.

I've looked through the CLS in build https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/17057 and none seem likely to cause a leak.
Nor are any of the CLs isted for 17058 likely to have fixed one.

I suspect there is a racy/flaky leak that could be found by holistic pressure and rr on one of the sensitive tests, but there is no reason to presume any particular component smaller than Blink.

Comment 4 by tkent@chromium.org, Apr 4 2018

Components: -Blink Blink>Fullscreen
Cc: fsam...@chromium.org
Owner: chrishtr@chromium.org
I'm really not the right person for this bug as it's in blink as far as I can tell. I'm assigning to chrishtr@ for triage.
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d3a6a25101efa2b610008c00f7b74aa6407ba0d

commit 5d3a6a25101efa2b610008c00f7b74aa6407ba0d
Author: Philip Rogers <pdr@chromium.org>
Date: Fri Dec 07 19:01:02 2018

Mark virtual/android/fullscreen/video-scrolled-iframe.html as flaky

The leak detector bot is more flaky on virtual/android/fullscreen tests
for unknown reasons (see: https://crbug.com/769885). With BGPT,
virtual/android/fullscreen/video-scrolled-iframe.html recently got more
flaky, though it flaked before BGPT was enabled too.

This patch marks virtual/android/fullscreen/video-scrolled-iframe.html
as skipped due to 2px of flakiness.

Bug:  912979 , 769885
Change-Id: I941413dcd52b36401703ffdf85f52114aa7600aa
Reviewed-on: https://chromium-review.googlesource.com/c/1368107
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614769}
[modify] https://crrev.com/5d3a6a25101efa2b610008c00f7b74aa6407ba0d/third_party/blink/web_tests/TestExpectations

Labels: Pri-2
Setting defect without priority to Pri-2.

Sign in to add a comment