Issue metadata
Sign in to add a comment
|
view-source: doesn't work on individual chrome://interstitials anymore |
||||||||||||||||||||||||
Issue descriptionChrome 63.0.3218.0 macOS 10.12.6 What steps will reproduce the problem? (1) view-source:chrome://interstitials/ssl?overridable=1&strict_enforcement=0 What is the expected result? Source for the interstitial. What happens instead? Source for the chrome://interstitials front page. The regression range [1] points to https://chromium-review.googlesource.com/c/chromium/src/+/663204 Carlos, could you look into this? [1] https://chromium.googlesource.com/chromium/src/+log/247e39e3715d0f0c9d4c2d0c6ac506c467b0f3e9..347624883210ae4aa94bfc6b0c84e9faf5ecca2b
,
Sep 29 2017
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5dc1ae293b358e440896706273c609854664c58f commit 5dc1ae293b358e440896706273c609854664c58f Author: Carlos IL <carlosil@chromium.org> Date: Mon Oct 02 19:14:35 2017 View-source now works on chrome://interstitials/... View source was not working correctly on individual subsites of chrome://interstitials (e.g. chrome://interstitials/ssl) due to web_contents not holding a correct URL when a call to StartDataRequest was triggered from a view-source: url. The "chrome://interstitials/" URL is now hardcoded in InterstitialHTMLSource::StartDataRequest (since calls to that function only happen when opening a chrome://interstitials page). Tests were also added for this case. R=estark@chromium.org Bug: 769876 Change-Id: I432c02be1b873918ac2bb9a8e0f17dea39aa5043 Reviewed-on: https://chromium-review.googlesource.com/692976 Reviewed-by: Emily Stark <estark@chromium.org> Reviewed-by: Lucas Garron <lgarron@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#505709} [modify] https://crrev.com/5dc1ae293b358e440896706273c609854664c58f/chrome/browser/ui/webui/interstitials/interstitial_ui.cc [modify] https://crrev.com/5dc1ae293b358e440896706273c609854664c58f/chrome/browser/ui/webui/interstitials/interstitial_ui_browsertest.cc
,
Oct 2 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by carlosil@chromium.org
, Sep 28 2017