[LUCI-Beta-Feedback] Inline line break elements should be rendered / honored |
||||||||||||||||
Issue descriptionIn this LUCI try job on linux_chromium_rel_ng: https://ci.chromium.org/swarming/task/38de8e66360d5010?server=chromium-swarm.appspot.com Many steps include <br> or <br/> elements in their text. These used to be honored in the old step rendering code, but aren't on the LUCI trybot.
,
Sep 28 2017
,
Oct 3 2017
Maybe for now we should whitelist <br> tags in the step name like we do for the step body.
,
Oct 7 2017
,
Nov 8 2017
hinoka did this for buildbot builds but I think we would need to redo it for buildbucket builds since it's a different buildsource - is that right, Ryan?
,
Nov 9 2017
i think that is right, here https://cs.chromium.org/chromium/infra/go/src/go.chromium.org/luci/milo/buildsource/rawpresentation/logDogBuild.go?sq=package:chromium&l=74
,
Nov 9 2017
,
Nov 13 2017
,
Nov 16 2017
,
Nov 16 2017
Not a blocker for LUCI UI since this is for LUCI builders and we're only launching for buildbot builders.
,
Nov 21 2017
,
Nov 22 2017
,
Nov 27 2017
This blocks M4 but not UI launch since it doesn't affect buildbot.
,
Dec 1 2017
,
Dec 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-go.git/+/c0bc826f6f83291a6bf7c53909979fce1db41023 commit c0bc826f6f83291a6bf7c53909979fce1db41023 Author: Ryan Tseng <hinoka@google.com> Date: Fri Dec 08 01:13:51 2017 [milo] Split step text by <br> everywhere Before this was only done for buildbot, this CL changes to cover luci builds too. Bug: 769859 Change-Id: I8ace935c4f9426db87b651424dd20b96e4265591 Reviewed-on: https://chromium-review.googlesource.com/815894 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> [modify] https://crrev.com/c0bc826f6f83291a6bf7c53909979fce1db41023/milo/buildsource/buildbot/build.go [modify] https://crrev.com/c0bc826f6f83291a6bf7c53909979fce1db41023/milo/buildsource/buildbot/expectations/chromium_presubmit.426944.build.json [modify] https://crrev.com/c0bc826f6f83291a6bf7c53909979fce1db41023/milo/buildsource/buildbot/expectations/gerritCL.1234.build.json [modify] https://crrev.com/c0bc826f6f83291a6bf7c53909979fce1db41023/milo/buildsource/buildbot/expectations/newline.1234.build.json [modify] https://crrev.com/c0bc826f6f83291a6bf7c53909979fce1db41023/milo/buildsource/buildbot/expectations/win_chromium_rel_ng.246309.build.json [modify] https://crrev.com/c0bc826f6f83291a6bf7c53909979fce1db41023/milo/frontend/appengine/templates/pages/build.html [modify] https://crrev.com/c0bc826f6f83291a6bf7c53909979fce1db41023/milo/frontend/ui/build.go
,
Dec 8 2017
,
Jan 31 2018
,
Feb 13 2018
|
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by no...@chromium.org
, Sep 28 2017