New issue
Advanced search Search tips

Issue 769833 link

Starred by 2 users
Status: Assigned
Owner:
xhw...@chromium.org
Cc:
jrumm...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Reorganize media/cdm/ppapi folder structure

Project Member Reported by xhw...@chromium.org, Sep 28 2017 
After moving from pepper CDM to mojo CDM, media/cdm/ppapi should be renamed and reorganized.

Here are some thoughts:
- rename media/cdm/ppapi to be media/cdm/library_cdm
- move media/cdm/api to media/cdm/library_cdm/api
- move library CDM specific files (e.g. cdm_adapter.*, cdm_module.*) into media/cdm/library_cdm
- create a new BUILD.gn file in media/cdm/library_cdm

Comment 1 by xhw...@chromium.org, Nov 2 2017

Labels: -M-64 M-65
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa911adb4d24f2f76e21df2e84ea1549b08fab6b

commit fa911adb4d24f2f76e21df2e84ea1549b08fab6b
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Wed Dec 20 22:42:04 2017

media: Rename external_clear_key folder to clear_key_cdm

External Clear Key (ECK) is the name of the key system while Clear Key
CDM is the name of the library CDM implementation. On desktop platforms
ECK is supported using Clear Key CDM. On other platforms, ECK is
supported by running AesDecryptor in a remote process, using MojoCdm.

Given this folder is actually the implementation of the Clear Key CDM,
rename it to "clear_key_cdm" to avoid confusion.

Also add a README.md file for Clear Key CDM.

BUG=769833
TEST=No functionality change.

Change-Id: I5a67cbf4c101a4b275eba297e013c37bf096d5fb
Reviewed-on: https://chromium-review.googlesource.com/837489
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525499}
[modify] https://crrev.com/fa911adb4d24f2f76e21df2e84ea1549b08fab6b/media/cdm/ppapi/BUILD.gn
[rename] https://crrev.com/fa911adb4d24f2f76e21df2e84ea1549b08fab6b/media/cdm/ppapi/clear_key_cdm/BRANDING
[add] https://crrev.com/fa911adb4d24f2f76e21df2e84ea1549b08fab6b/media/cdm/ppapi/clear_key_cdm/README.md
[rename] https://crrev.com/fa911adb4d24f2f76e21df2e84ea1549b08fab6b/media/cdm/ppapi/clear_key_cdm/cdm_file_adapter.cc
[rename] https://crrev.com/fa911adb4d24f2f76e21df2e84ea1549b08fab6b/media/cdm/ppapi/clear_key_cdm/cdm_file_adapter.h
[rename] https://crrev.com/fa911adb4d24f2f76e21df2e84ea1549b08fab6b/media/cdm/ppapi/clear_key_cdm/cdm_host_proxy.h
[rename] https://crrev.com/fa911adb4d24f2f76e21df2e84ea1549b08fab6b/media/cdm/ppapi/clear_key_cdm/cdm_video_decoder.cc
[rename] https://crrev.com/fa911adb4d24f2f76e21df2e84ea1549b08fab6b/media/cdm/ppapi/clear_key_cdm/cdm_video_decoder.h
[rename] https://crrev.com/fa911adb4d24f2f76e21df2e84ea1549b08fab6b/media/cdm/ppapi/clear_key_cdm/clear_key_cdm.cc
[rename] https://crrev.com/fa911adb4d24f2f76e21df2e84ea1549b08fab6b/media/cdm/ppapi/clear_key_cdm/clear_key_cdm.h
[rename] https://crrev.com/fa911adb4d24f2f76e21df2e84ea1549b08fab6b/media/cdm/ppapi/clear_key_cdm/clear_key_persistent_session_cdm.cc
[rename] https://crrev.com/fa911adb4d24f2f76e21df2e84ea1549b08fab6b/media/cdm/ppapi/clear_key_cdm/clear_key_persistent_session_cdm.h
[rename] https://crrev.com/fa911adb4d24f2f76e21df2e84ea1549b08fab6b/media/cdm/ppapi/clear_key_cdm/ffmpeg_cdm_audio_decoder.cc
[rename] https://crrev.com/fa911adb4d24f2f76e21df2e84ea1549b08fab6b/media/cdm/ppapi/clear_key_cdm/ffmpeg_cdm_audio_decoder.h
[rename] https://crrev.com/fa911adb4d24f2f76e21df2e84ea1549b08fab6b/media/cdm/ppapi/clear_key_cdm/ffmpeg_cdm_video_decoder.cc
[rename] https://crrev.com/fa911adb4d24f2f76e21df2e84ea1549b08fab6b/media/cdm/ppapi/clear_key_cdm/ffmpeg_cdm_video_decoder.h
[rename] https://crrev.com/fa911adb4d24f2f76e21df2e84ea1549b08fab6b/media/cdm/ppapi/clear_key_cdm/libvpx_cdm_video_decoder.cc
[rename] https://crrev.com/fa911adb4d24f2f76e21df2e84ea1549b08fab6b/media/cdm/ppapi/clear_key_cdm/libvpx_cdm_video_decoder.h

Comment 3 by xhw...@chromium.org, Jan 25 2018

Labels: -M-65 M-66
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc32f2eded1755314dc3a3b494be1b1196c98d7a

commit cc32f2eded1755314dc3a3b494be1b1196c98d7a
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Tue Jan 30 01:09:05 2018

media: Rename media/cdm/ppapi to media/cdm/library_cdm

This folder contains "library CDM" related code and will soon be
unrelated to ppapi.

This CL only renames the folder. More clean-up will follow in later CLs.

TBR=thestig@chromium.org
BUG=769833

Change-Id: I346a59d23838d5d4cd93bfea5afd3f28827e147f
Reviewed-on: https://chromium-review.googlesource.com/889693
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532709}
[modify] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/chrome/BUILD.gn
[modify] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/chrome/gpu/BUILD.gn
[modify] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/chrome/gpu/chrome_content_gpu_client.cc
[modify] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/chrome/installer/linux/BUILD.gn
[modify] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/chrome/test/BUILD.gn
[modify] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/BUILD.gn
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/BUILD.gn
[add] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/DEPS
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/cdm_file_io_impl.cc
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/cdm_file_io_impl.h
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/cdm_logging.cc
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/cdm_logging.h
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/cdm_paths.gni
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/clear_key_cdm/BRANDING
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/clear_key_cdm/BUILD.gn
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/clear_key_cdm/README.md
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/clear_key_cdm/cdm_file_adapter.cc
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/clear_key_cdm/cdm_file_adapter.h
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/clear_key_cdm/cdm_file_io_test.cc
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/clear_key_cdm/cdm_file_io_test.h
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/clear_key_cdm/cdm_host_proxy.h
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/clear_key_cdm/cdm_host_proxy_impl.h
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/clear_key_cdm/cdm_proxy_common.h
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/clear_key_cdm/cdm_proxy_test.cc
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/clear_key_cdm/cdm_proxy_test.h
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/clear_key_cdm/cdm_video_decoder.cc
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/clear_key_cdm/cdm_video_decoder.h
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/clear_key_cdm/clear_key_cdm.cc
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/clear_key_cdm/clear_key_cdm.h
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/clear_key_cdm/clear_key_cdm_proxy.cc
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/clear_key_cdm/clear_key_cdm_proxy.h
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/clear_key_cdm/clear_key_persistent_session_cdm.cc
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/clear_key_cdm/clear_key_persistent_session_cdm.h
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/clear_key_cdm/ffmpeg_cdm_audio_decoder.cc
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/clear_key_cdm/ffmpeg_cdm_audio_decoder.h
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/clear_key_cdm/ffmpeg_cdm_video_decoder.cc
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/clear_key_cdm/ffmpeg_cdm_video_decoder.h
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/clear_key_cdm/libvpx_cdm_video_decoder.cc
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/clear_key_cdm/libvpx_cdm_video_decoder.h
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/clearkeycdmadapter.ver
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/linked_ptr.h
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/ppapi_cdm_adapter.cc
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/ppapi_cdm_adapter.gni
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/ppapi_cdm_adapter.h
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/ppapi_cdm_buffer.cc
[rename] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/media/cdm/library_cdm/ppapi_cdm_buffer.h
[delete] https://crrev.com/54daef614af9b25fa81985ab6e94bc4aadd5bf75/media/cdm/ppapi/DEPS
[modify] https://crrev.com/cc32f2eded1755314dc3a3b494be1b1196c98d7a/third_party/widevine/cdm/BUILD.gn

Comment 5 by xhw...@chromium.org, Jan 31 2018

Labels: Pri-2

Comment 6 by xhw...@chromium.org, Feb 20 2018

Labels: -M-66 M-67

Comment 7 by xhw...@chromium.org, Mar 23 2018

Labels: -M-67 M-68

Comment 8 by xhw...@chromium.org, Apr 13 2018

Labels: -M-68
►

Sign in to add a comment