Issue metadata
Sign in to add a comment
|
Clicking text in Gerrit causes scroll offset to jump wildly |
||||||||||||||||||||||||
Issue descriptionChrome version: 63.0.3225.0 (Official Build) canary (64-bit) Describe infrastructure request/issue: In PolyGerrit code reviews, clicking text causes the scroll offset to jump down a long distance. This makes code reviews nearly unusable. Video demonstrating the problem: https://drive.google.com/open?id=0B5DES7PYkZBLLVJBNC1YWkhrMkE To reproduce: 1) Go to https://chromium-review.googlesource.com/685403 with Chrome Canary on a MacBook Pro with Retina Display (didn't try on other platforms) 2) Click "Show diffs" 3) Click anywhere in the green text on the right The page will jump far down in the code review. It's necessary to scroll back up in order to continue with the operation. Clicking line numbers in the code review also causes the scroll offset to jump, though not as badly. This might well be a regression in Canary rather than in the Gerrit tool. CC'ing a couple of folks who may be able to help triage.
,
Sep 29 2017
Sorry, didn't realize the bug would reproduce without logging in to PolyGerrit. It does. Per-revision bisect with the args: --no-first-run https://chromium-review.googlesource.com/691147 opening the diffs, and clicking inside them, reveals it's: You are probably looking for a change made after 503703 (known good), but no later than 503704 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/aaea11cf400c7c2af3f1e9dab3a2519f616c4c89..8adb99901d515d445cc398bf78e8b1accedc0613 karlo@, reassigning to you. (Apologies, you won't be able to see the video, but the bug's easily reproducible.)
,
Sep 30 2017
,
Oct 2 2017
,
Oct 2 2017
This is making it quite hard to do code reviews. Can we revert until the root cause is understood?
,
Oct 3 2017
This was fixed by reverting (tracked in 638177), right?
,
Oct 3 2017
,
Oct 26 2017
Issue gerrit:7292 has been merged into this issue. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by dtapu...@chromium.org
, Sep 28 2017