New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 769828 link

Starred by 1 user
Status: Untriaged
Owner: ----
Cc:
█ phajdan.jr@chromium.org
vapier@chromium.org
chromeos-continuous-integration-fire-hose@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

cbuildbot_launch should update path to refer to depot_tools from manifest, not recipe.

Project Member Reported by dgarr...@chromium.org, Sep 28 2017 
We have many different depot_tools pins, but most of our tools just get tools from there based on the path.

cbuildbot_launch needs a bootstrap version of depot_tools for the initial checkout. 

But, when it launches cbuildbot from the manifest checkout, it could set the path to use depot_tools from the manifest checkout. This would make the version of depot_tools used inside and outside the chroot identical. This would also make the version of depot_tools used be pinned for branches in the way that we expect.

We've had to make/coordinate a lot of duplicated bin bumps recently to make new depot_tools versions available to cbuildbot outside the chroot, and this would have reduced a lot of the complexity around managing that.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/a50bf49a7dbd98d0d65eae5a3eab8c9c3e2d2610

commit a50bf49a7dbd98d0d65eae5a3eab8c9c3e2d2610
Author: Don Garrett <dgarrett@google.com>
Date: Fri Sep 29 20:06:14 2017

cbuildbot_launch: Insert pinned depot_tools into path.

Before invoking cbuildbot, insert the depot_tools instance checked out
from the manifest pin into the path. This means that cbuildbot will
always use the same version of depot_tools, both inside and outside of
the chroot.

depot_tools versions before this CL:
  cbuildbot_launch (TOT) gets the recipe version (TOT).
  cbuildbot (top of branch) gets the recipe version (TOT) outside the
    chroot, and the manifest pinned version (branch) inside.

depot_tools versions after this CL:
  cbuildbot_launch (TOT) gets the recipe version (TOT).
  cbuildbot (top of branch) gets the same manifest version (branched)
    both inside and outside the chroot.

BUG=chromium:769828
TEST=run_tests
     cros tryjob --local lumpy-compile-only-pre-cq

Change-Id: I566f08af684c3b8c3805bb2ef80ccb8939fc8611
Reviewed-on: https://chromium-review.googlesource.com/691437
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Trybot-Ready: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/a50bf49a7dbd98d0d65eae5a3eab8c9c3e2d2610/lib/constants.py
[modify] https://crrev.com/a50bf49a7dbd98d0d65eae5a3eab8c9c3e2d2610/scripts/cbuildbot_launch.py
[modify] https://crrev.com/a50bf49a7dbd98d0d65eae5a3eab8c9c3e2d2610/scripts/cbuildbot_launch_unittest.py

Comment 2 by akes...@chromium.org, Mar 30 2018

Components: Infra>Client>ChromeOS>CI

Comment 3 by akes...@chromium.org, Mar 30 2018

Components: -Infra>Client>ChromeOS
►

Sign in to add a comment