New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 769811 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

use_system_harfbuzz = true undeclared identifier 'hb_variation_t'

Reported by dntsp...@gmail.com, Sep 28 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3130.0 Safari/537.36

Steps to reproduce the problem:
1. gn args out/Default
2. use_system_harfbuzz = true
3. ninja -C out/Default chrome

What is the expected behavior?
-I/usr/include/harfbuzz

What went wrong?
-I../../build/linux/debian_jessie_amd64-sysroot/usr/include/harfbuzz

[24135/24827] CXX obj/third_party/WebKit/Source/platform/platform/HarfBuzzFace.o
FAILED: obj/third_party/WebKit/Source/platform/platform/HarfBuzzFace.o 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_part
y/WebKit/Source/platform/platform/HarfBuzzFace.o.d -DV8_DEPRECATION_WARNINGS -DU
SE_UDEV -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 
-DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -D
CHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=\"313786-1\" -D_
FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_
MACROS -D__STDC_FORMAT_MACROS -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXX
ABI_DISABLE_VISIBILITY_ANNOTATIONS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DBLINK_IMPLEMENTATION=1 -DINSIDE_BLINK -DBLINK_PLATFORM_IMPLEMENTATION=1 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_32 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_26 -DGL_GLEXT_PROTOTYPES -DUSE_GLX -DUSE_EGL -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_HAS_JPEG_LIBRARY -DSK_SUPPORT_GPU=1 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -DENABLE_IPC_FUZZER -DWTF_USE_WEBAUDIO_FFMPEG=1 -DWTF_USE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -I../../third_party/ffmpeg -I../.. -Igen -Igen/blink -I../../third_party/WebKit/Source -I../../third_party/WebKit -Igen/blink -Igen/third_party/WebKit -I../../build/linux/debian_jessie_amd64-sysroot/usr/include/glib-2.0 -I../../build/linux/debian_jessie_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -I../../third_party/libwebp/src -I../../third_party/khronos -I../../gpu -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/encode -I../../third_party/skia/include/gpu -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/third_party/vulkan -I../../third_party/skia/include/codec -I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl -I../../third_party/libwebm/source -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/boringssl/src/include -I../../build/linux/debian_jessie_amd64-sysroot/usr/include/nss -I../../build/linux/debian_jessie_amd64-sysroot/usr/include/nspr -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/WebKit/Source -I../../third_party/WebKit -Igen/blink -Igen/third_party/WebKit -I../../third_party/libjpeg_turbo -I../../third_party/iccjpeg -I../../third_party/libpng -I../../third_party/zlib -I../../third_party/ots/include -I../../v8/include -Igen/v8/include -I../../build/linux/debian_jessie_amd64-sysroot/usr/include/harfbuzz -I../../third_party/ffmpeg/chromium/config/Chrome/linux/x64 -I../../third_party/ffmpeg -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -pthread -fcolor-diagnostics -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=1 -m64 -march=x86-64 -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -Wno-tautological-unsigned-zero-compare -Wno-null-pointer-arithmetic -Wno-tautological-unsigned-enum-zero-compare -O2 -fno-ident -fdata-sections -ffunction-sections -fomit-frame-pointer -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-auto-raw-pointer -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin.so -Xclang -add-plugin -Xclang blink-gc-plugin -Wglobal-constructors -g0 -Wno-header-guard -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin.so -Xclang -add-plugin -Xclang blink-gc-plugin -std=gnu++14 -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include --sysroot=../../build/linux/debian_jessie_amd64-sysroot -fno-exceptions -fvisibility-inlines-hidden -c ../../third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp -o obj/third_party/WebKit/Source/platform/platform/HarfBuzzFace.o
../../third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp:324:27: error: use of undeclared identifier 'hb_variation_t'
                 decltype(hb_variation_t::tag)>::value &&

Did this work before? Yes 61.0.3130.0

Chrome version: 63.0.3226.0  Channel: n/a
OS Version: LFS-8+
Flash Version: 

similar to
https://bugs.chromium.org/p/chromium/issues/detail?id=769245
https://bugs.chromium.org/p/chromium/issues/detail?id=765914
 

Comment 1 by dntsp...@gmail.com, Sep 28 2017

These are working:
use_system_freetype = true
use_system_libdrm = true and
use_system_zlib = true

Comment 2 by dntsp...@gmail.com, Sep 28 2017

expected behaviour:
 $ pkg-config --cflags harfbuzz
-I/usr/include/harfbuzz -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include
Cc: divya.pa...@techmahindra.com
Labels: Triagd-ET TE-NeedsTriageHelp
Unable to build the Chrome  from our end, hence adding TE-Needs-TriageHelp label for further triage of the issue
Components: -Platform>DevTools Build

Comment 5 Deleted

Comment 6 by dntsp...@gmail.com, Dec 10 2017

Disregard previous comment. I missed the error in the logs
65.0.3289.0 still no -I/usr/include/harfbuzz
Owner: thomasanderson@chromium.org
Status: Started (was: Unconfirmed)

Comment 8 by dntsp...@gmail.com, Dec 13 2017

see https://bugs.chromium.org/p/chromium/issues/detail?id=769245
my PKG_CONFIG_PATH was not set

2017-12-13 0:32 GMT+01:00 thomasan… via monorail <
monorail+v2.2036812778@chromium.org>:
Status: WontFix (was: Started)
It appears the problematic part of the command in the original report is "-I../../build/linux/debian_jessie_amd64-sysroot/usr/include/harfbuzz" which indicated includes from the sysroot were being used instead of the system includes. When building with system libraries "use_sysroot=false" should be used in args.gn in order to use the system instead of sysroot resources.

Comment 10 by dntsp...@gmail.com, Jan 28 2018

@bunge - use_sysroot=false is on my todo list because mentioned in  Issue 769245 

Comment 11 by dntsp...@gmail.com, Mar 21 2018

Version: 67.0.3373.0
use_system_freetype = true
use_system_harfbuzz = true      
use_system_libdrm = true
use_system_zlib = true

works.

use_sysroot=false results in
ERROR at //extensions/shell/installer/linux/BUILD.gn:205:19: Empty directory path.
      rebase_path(sysroot, root_build_dir),
c#11 sync to ToT and it should be fixed.

Comment 13 by dntsp...@gmail.com, Mar 21 2018

c#12 
use_system_harfbuzz = true
works
use_sysroot=false
was a response to c#9

Comment 14 by dntsp...@gmail.com, Jun 22 2018

Status can be set to fixed

69.0.3467.0

enable_nacl = false
ffmpeg_branding = "Chrome"
is_debug = false
proprietary_codecs = true
remove_webcore_debug_symbols = true
use_sysroot = false
use_system_freetype = true
use_system_harfbuzz = true
use_system_lcms2 = true
use_system_libdrm = true
use_system_libjpeg = true
use_system_libpng = true
use_system_zlib = true
works and chrome running now
Status: Fixed (was: WontFix)

Sign in to add a comment